Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1245653 > unrolled thread
| Started by | Marc Zyngier <marc.zyngier@arm.com> |
|---|---|
| First post | 2015-10-13 14:00 +0200 |
| Last post | 2015-10-13 18:40 +0200 |
| Articles | 5 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH v2 00/17] Divorcing irqdomain and device_node Marc Zyngier <marc.zyngier@arm.com> - 2015-10-13 14:00 +0200
Re: [PATCH v2 00/17] Divorcing irqdomain and device_node Hanjun Guo <hanjun.guo@linaro.org> - 2015-10-13 16:00 +0200
Re: [PATCH v2 00/17] Divorcing irqdomain and device_node Marc Zyngier <marc.zyngier@arm.com> - 2015-10-13 17:40 +0200
Re: [PATCH v2 00/17] Divorcing irqdomain and device_node Hanjun Guo <hanjun.guo@linaro.org> - 2015-10-13 17:40 +0200
Re: [PATCH v2 00/17] Divorcing irqdomain and device_node Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> - 2015-10-13 18:40 +0200
| From | Marc Zyngier <marc.zyngier@arm.com> |
|---|---|
| Date | 2015-10-13 14:00 +0200 |
| Subject | [PATCH v2 00/17] Divorcing irqdomain and device_node |
| Message-ID | <qj6pj-5Fz-3@gated-at.bofh.it> |
[This patch series used to be called "Making the generic ACPI GSI
layer irqdomain aware", but as I've radically changed my approach to
this problem, I've decided to reset the counters...]
The irqdomain code is not entierely ACPI friendly, as it has some
built-in knowledge of the device-tree. Nothing too harmful, but enough
to scare the ARM ACPI developpers which end up with their own version
of the square wheel. And some of the ramifications actually run deeper
than initially expected.
This series adapts the irqdomain code to use 'struct fwnode_handle'
instead of 'struct device_node' as the identifier for a domain
(compatibility interfaces are of course added). It also introduces a
generic IRQ specifier that firmware interfaces (DT or ACPI) can
directly use to configure interrupts, and allow the ACPI GSI code to
be plugged into this.
As examples, we convert the ARM GIC ACPI support to use irqdomains as
originally intended, and rework the MSI code to also move away from
using device nodes when using irqdomains.
Overall, this gives us a way to use irqdomains on both DT and ACPI
enabled platforms, having very little changes made to the actual
drivers (other than the probing infrastructure). Because we keep the
flow of information between the various layers identical between ACPI
and DT, we immediately benefit from the existing infrastructure.
This has been test-booted on Juno, is based on 4.3-rc5 + tip/irq/core
(in order to avoid potential conflicts), and available at:
git://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git irq/irq-domain-fwnode-v2
* From v1:
- Dropped irq_domain_get_of_node() from the first patch (merged into
4.3-rc5)
- Fixed a few missing accessors in the first patch
- Added EXPORT_SYMBOL_GPL for irq_find_matching_fwnode
- Added some documentation update
- Added Acks from Rafael
- Rebased on top of 4.3-rc5 + tip/irq/core
Marc Zyngier (17):
irqdomain: Use irq_domain_get_of_node() instead of direct field access
irqdomain: Convert irqdomain->of_node to fwnode
irqdomain: Allow irq domain lookup by fwnode
irqdomain: Introduce a firmware-specific IRQ specifier structure
irqchip: Convert all alloc/xlate users from of_node to fwnode
irqdomain: Introduce irq_create_fwspec_mapping
irqdomain: Introduce irq_domain_create_{linear,tree}
irqdomain: Add a fwnode_handle allocator
acpi/gsi: Always perform an irq domain lookup
acpi/gsi: Add acpi_set_irq_model to initialize the GSI layer
irqchip/gic: Get rid of gic_init_bases()
irqchip/gic: Switch ACPI support to stacked domains
irqchip/gic: Kill the xlate method
acpi/gsi: Cleanup acpi_register_gsi
irqdomain: Introduce irq_domain_create_hierarchy
irqdomain/msi: Use fwnode instead of of_node
irqdomain: Documentation updates
Documentation/IRQ-domain.txt | 9 +-
arch/arm/mach-exynos/suspend.c | 55 ++++----
arch/arm/mach-imx/gpc.c | 55 ++++----
arch/arm/mach-omap2/omap-wakeupgen.c | 55 ++++----
arch/c6x/platforms/megamod-pic.c | 2 +-
arch/mips/cavium-octeon/octeon-irq.c | 4 +-
arch/powerpc/platforms/cell/axon_msi.c | 2 +-
arch/powerpc/platforms/cell/spider-pic.c | 9 +-
arch/powerpc/platforms/pasemi/msi.c | 6 +-
arch/powerpc/platforms/powernv/opal-irqchip.c | 2 +-
arch/powerpc/sysdev/ehv_pic.c | 3 +-
arch/powerpc/sysdev/fsl_msi.c | 2 +-
arch/powerpc/sysdev/i8259.c | 3 +-
arch/powerpc/sysdev/ipic.c | 3 +-
arch/powerpc/sysdev/mpic.c | 3 +-
arch/powerpc/sysdev/mpic_msi.c | 2 +-
arch/powerpc/sysdev/qe_lib/qe_ic.c | 3 +-
drivers/acpi/gsi.c | 54 +++++---
drivers/base/platform-msi.c | 6 +-
drivers/gpio/gpio-sodaville.c | 2 +-
drivers/irqchip/exynos-combiner.c | 2 +-
drivers/irqchip/irq-atmel-aic-common.c | 2 +-
drivers/irqchip/irq-crossbar.c | 62 +++++----
drivers/irqchip/irq-gic-v2m.c | 23 ++--
drivers/irqchip/irq-gic-v3-its-pci-msi.c | 3 +-
drivers/irqchip/irq-gic-v3-its-platform-msi.c | 3 +-
drivers/irqchip/irq-gic-v3-its.c | 20 +--
drivers/irqchip/irq-gic-v3.c | 49 ++++---
drivers/irqchip/irq-gic.c | 94 ++++++++------
drivers/irqchip/irq-hip04.c | 2 +-
drivers/irqchip/irq-imx-gpcv2.c | 64 +++++-----
drivers/irqchip/irq-mtk-sysirq.c | 49 +++----
drivers/irqchip/irq-nvic.c | 18 ++-
drivers/irqchip/irq-s3c24xx.c | 4 +-
drivers/irqchip/irq-tegra.c | 55 ++++----
drivers/irqchip/irq-vf610-mscm-ir.c | 45 +++++--
drivers/pci/host/pci-xgene-msi.c | 2 +-
drivers/pci/msi.c | 14 +-
drivers/spmi/spmi-pmic-arb.c | 2 +-
include/linux/acpi.h | 3 +
include/linux/fwnode.h | 1 +
include/linux/irqchip/arm-gic.h | 9 +-
include/linux/irqdomain.h | 106 +++++++++++----
include/linux/msi.h | 9 +-
kernel/irq/irqdomain.c | 177 ++++++++++++++++++++------
kernel/irq/msi.c | 8 +-
46 files changed, 678 insertions(+), 428 deletions(-)
--
2.1.4
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Hanjun Guo <hanjun.guo@linaro.org> |
|---|---|
| Date | 2015-10-13 16:00 +0200 |
| Message-ID | <qj8hs-8pd-11@gated-at.bofh.it> |
| In reply to | #1245653 |
On 10/13/2015 07:51 PM, Marc Zyngier wrote:
> [This patch series used to be called "Making the generic ACPI GSI
> layer irqdomain aware", but as I've radically changed my approach to
> this problem, I've decided to reset the counters...]
>
> The irqdomain code is not entierely ACPI friendly, as it has some
> built-in knowledge of the device-tree. Nothing too harmful, but enough
> to scare the ARM ACPI developpers which end up with their own version
> of the square wheel. And some of the ramifications actually run deeper
> than initially expected.
>
> This series adapts the irqdomain code to use 'struct fwnode_handle'
> instead of 'struct device_node' as the identifier for a domain
> (compatibility interfaces are of course added). It also introduces a
> generic IRQ specifier that firmware interfaces (DT or ACPI) can
> directly use to configure interrupts, and allow the ACPI GSI code to
> be plugged into this.
>
> As examples, we convert the ARM GIC ACPI support to use irqdomains as
> originally intended, and rework the MSI code to also move away from
> using device nodes when using irqdomains.
>
> Overall, this gives us a way to use irqdomains on both DT and ACPI
> enabled platforms, having very little changes made to the actual
> drivers (other than the probing infrastructure). Because we keep the
> flow of information between the various layers identical between ACPI
> and DT, we immediately benefit from the existing infrastructure.
>
> This has been test-booted on Juno, is based on 4.3-rc5 + tip/irq/core
> (in order to avoid potential conflicts), and available at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git irq/irq-domain-fwnode-v2
>
> * From v1:
> - Dropped irq_domain_get_of_node() from the first patch (merged into
> 4.3-rc5)
> - Fixed a few missing accessors in the first patch
> - Added EXPORT_SYMBOL_GPL for irq_find_matching_fwnode
> - Added some documentation update
> - Added Acks from Rafael
> - Rebased on top of 4.3-rc5 + tip/irq/core
>
> Marc Zyngier (17):
> irqdomain: Use irq_domain_get_of_node() instead of direct field access
> irqdomain: Convert irqdomain->of_node to fwnode
> irqdomain: Allow irq domain lookup by fwnode
> irqdomain: Introduce a firmware-specific IRQ specifier structure
> irqchip: Convert all alloc/xlate users from of_node to fwnode
> irqdomain: Introduce irq_create_fwspec_mapping
> irqdomain: Introduce irq_domain_create_{linear,tree}
> irqdomain: Add a fwnode_handle allocator
> acpi/gsi: Always perform an irq domain lookup
> acpi/gsi: Add acpi_set_irq_model to initialize the GSI layer
> irqchip/gic: Get rid of gic_init_bases()
> irqchip/gic: Switch ACPI support to stacked domains
> irqchip/gic: Kill the xlate method
> acpi/gsi: Cleanup acpi_register_gsi
> irqdomain: Introduce irq_domain_create_hierarchy
> irqdomain/msi: Use fwnode instead of of_node
> irqdomain: Documentation updates
For this patch series,
Reviewed-by: Hanjun Guo <hanjun.guo@linaro.org>
For patch 1 to patch14,
Tested-by: Hanjun Guo <hanjun.guo@linaro.org>
Thanks a lot!
Hanjun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Marc Zyngier <marc.zyngier@arm.com> |
|---|---|
| Date | 2015-10-13 17:40 +0200 |
| Message-ID | <qj9Qe-2jW-29@gated-at.bofh.it> |
| In reply to | #1245738 |
On 13/10/15 14:49, Hanjun Guo wrote:
> On 10/13/2015 07:51 PM, Marc Zyngier wrote:
[...]
>> Marc Zyngier (17):
>> irqdomain: Use irq_domain_get_of_node() instead of direct field access
>> irqdomain: Convert irqdomain->of_node to fwnode
>> irqdomain: Allow irq domain lookup by fwnode
>> irqdomain: Introduce a firmware-specific IRQ specifier structure
>> irqchip: Convert all alloc/xlate users from of_node to fwnode
>> irqdomain: Introduce irq_create_fwspec_mapping
>> irqdomain: Introduce irq_domain_create_{linear,tree}
>> irqdomain: Add a fwnode_handle allocator
>> acpi/gsi: Always perform an irq domain lookup
>> acpi/gsi: Add acpi_set_irq_model to initialize the GSI layer
>> irqchip/gic: Get rid of gic_init_bases()
>> irqchip/gic: Switch ACPI support to stacked domains
>> irqchip/gic: Kill the xlate method
>> acpi/gsi: Cleanup acpi_register_gsi
>> irqdomain: Introduce irq_domain_create_hierarchy
>> irqdomain/msi: Use fwnode instead of of_node
>> irqdomain: Documentation updates
>
> For this patch series,
>
> Reviewed-by: Hanjun Guo <hanjun.guo@linaro.org>
>
> For patch 1 to patch14,
>
> Tested-by: Hanjun Guo <hanjun.guo@linaro.org>
Thanks for reviewing/testing.
M.
--
Jazz is not dead. It just smells funny...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Hanjun Guo <hanjun.guo@linaro.org> |
|---|---|
| Date | 2015-10-13 17:40 +0200 |
| Message-ID | <qj9Qe-2jW-33@gated-at.bofh.it> |
| In reply to | #1245738 |
On 10/13/2015 09:49 PM, Hanjun Guo wrote:
> On 10/13/2015 07:51 PM, Marc Zyngier wrote:
>> [This patch series used to be called "Making the generic ACPI GSI
>> layer irqdomain aware", but as I've radically changed my approach to
>> this problem, I've decided to reset the counters...]
>>
>> The irqdomain code is not entierely ACPI friendly, as it has some
>> built-in knowledge of the device-tree. Nothing too harmful, but enough
>> to scare the ARM ACPI developpers which end up with their own version
>> of the square wheel. And some of the ramifications actually run deeper
>> than initially expected.
>>
>> This series adapts the irqdomain code to use 'struct fwnode_handle'
>> instead of 'struct device_node' as the identifier for a domain
>> (compatibility interfaces are of course added). It also introduces a
>> generic IRQ specifier that firmware interfaces (DT or ACPI) can
>> directly use to configure interrupts, and allow the ACPI GSI code to
>> be plugged into this.
>>
>> As examples, we convert the ARM GIC ACPI support to use irqdomains as
>> originally intended, and rework the MSI code to also move away from
>> using device nodes when using irqdomains.
>>
>> Overall, this gives us a way to use irqdomains on both DT and ACPI
>> enabled platforms, having very little changes made to the actual
>> drivers (other than the probing infrastructure). Because we keep the
>> flow of information between the various layers identical between ACPI
>> and DT, we immediately benefit from the existing infrastructure.
>>
>> This has been test-booted on Juno, is based on 4.3-rc5 + tip/irq/core
>> (in order to avoid potential conflicts), and available at:
>>
>> git://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git
>> irq/irq-domain-fwnode-v2
>>
>> * From v1:
>> - Dropped irq_domain_get_of_node() from the first patch (merged into
>> 4.3-rc5)
>> - Fixed a few missing accessors in the first patch
>> - Added EXPORT_SYMBOL_GPL for irq_find_matching_fwnode
>> - Added some documentation update
>> - Added Acks from Rafael
>> - Rebased on top of 4.3-rc5 + tip/irq/core
>>
>> Marc Zyngier (17):
>> irqdomain: Use irq_domain_get_of_node() instead of direct field access
>> irqdomain: Convert irqdomain->of_node to fwnode
>> irqdomain: Allow irq domain lookup by fwnode
>> irqdomain: Introduce a firmware-specific IRQ specifier structure
>> irqchip: Convert all alloc/xlate users from of_node to fwnode
>> irqdomain: Introduce irq_create_fwspec_mapping
>> irqdomain: Introduce irq_domain_create_{linear,tree}
>> irqdomain: Add a fwnode_handle allocator
>> acpi/gsi: Always perform an irq domain lookup
>> acpi/gsi: Add acpi_set_irq_model to initialize the GSI layer
>> irqchip/gic: Get rid of gic_init_bases()
>> irqchip/gic: Switch ACPI support to stacked domains
>> irqchip/gic: Kill the xlate method
>> acpi/gsi: Cleanup acpi_register_gsi
>> irqdomain: Introduce irq_domain_create_hierarchy
>> irqdomain/msi: Use fwnode instead of of_node
>> irqdomain: Documentation updates
>
> For this patch series,
>
> Reviewed-by: Hanjun Guo <hanjun.guo@linaro.org>
>
> For patch 1 to patch14,
Oops, I mean patch 01/17 to patch 14/17,
>
> Tested-by: Hanjun Guo <hanjun.guo@linaro.org>
Thanks
Hanjun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> |
|---|---|
| Date | 2015-10-13 18:40 +0200 |
| Message-ID | <qjaMj-3HR-25@gated-at.bofh.it> |
| In reply to | #1245653 |
On Tue, Oct 13, 2015 at 12:51:28PM +0100, Marc Zyngier wrote: > [This patch series used to be called "Making the generic ACPI GSI > layer irqdomain aware", but as I've radically changed my approach to > this problem, I've decided to reset the counters...] > > The irqdomain code is not entierely ACPI friendly, as it has some > built-in knowledge of the device-tree. Nothing too harmful, but enough > to scare the ARM ACPI developpers which end up with their own version > of the square wheel. And some of the ramifications actually run deeper > than initially expected. > > This series adapts the irqdomain code to use 'struct fwnode_handle' > instead of 'struct device_node' as the identifier for a domain > (compatibility interfaces are of course added). It also introduces a > generic IRQ specifier that firmware interfaces (DT or ACPI) can > directly use to configure interrupts, and allow the ACPI GSI code to > be plugged into this. > > As examples, we convert the ARM GIC ACPI support to use irqdomains as > originally intended, and rework the MSI code to also move away from > using device nodes when using irqdomains. > > Overall, this gives us a way to use irqdomains on both DT and ACPI > enabled platforms, having very little changes made to the actual > drivers (other than the probing infrastructure). Because we keep the > flow of information between the various layers identical between ACPI > and DT, we immediately benefit from the existing infrastructure. > > This has been test-booted on Juno, is based on 4.3-rc5 + tip/irq/core > (in order to avoid potential conflicts), and available at: > > git://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git irq/irq-domain-fwnode-v2 Tested on AMD Supercharger (ACPI PCI+MSI), by applying dependent series [0,1] and some code soon to be posted to match gic v2m fwnode using this neat patch series :-) Tested-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> [0] https://lkml.org/lkml/2015/6/8/443 [1] http://comments.gmane.org/gmane.linux.kernel.pci/40904 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web