Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1245731 > unrolled thread

[PATCH] ARM: DRA7: hwmod: Remove elm address space from hwmod data

Started byFranklin S Cooper Jr <fcooper@ti.com>
First post2015-10-13 15:50 +0200
Last post2015-10-15 08:30 +0200
Articles 5 — 5 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] ARM: DRA7: hwmod: Remove elm address space from hwmod data Franklin S Cooper Jr <fcooper@ti.com> - 2015-10-13 15:50 +0200
    Re: [PATCH] ARM: DRA7: hwmod: Remove elm address space from hwmod  data Lokesh Vutla <a0131933@ti.com> - 2015-10-13 16:10 +0200
    Re: [PATCH] ARM: DRA7: hwmod: Remove elm address space from hwmod  data Roger Quadros <rogerq@ti.com> - 2015-10-14 09:00 +0200
      Re: [PATCH] ARM: DRA7: hwmod: Remove elm address space from hwmod  data "Franklin S Cooper Jr." <fcooper@ti.com> - 2015-10-14 15:10 +0200
        Re: [PATCH] ARM: DRA7: hwmod: Remove elm address space from hwmod  data Paul Walmsley <paul@pwsan.com> - 2015-10-15 08:30 +0200

#1245731 — [PATCH] ARM: DRA7: hwmod: Remove elm address space from hwmod data

FromFranklin S Cooper Jr <fcooper@ti.com>
Date2015-10-13 15:50 +0200
Subject[PATCH] ARM: DRA7: hwmod: Remove elm address space from hwmod data
Message-ID<qj87N-8dT-33@gated-at.bofh.it>
ELM address information is provided by device tree. No longer need
to include this information within hwmod.

Signed-off-by: Franklin S Cooper Jr <fcooper@ti.com>
---
 arch/arm/mach-omap2/omap_hwmod_7xx_data.c | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
index 562247b..ad2cc7a 100644
--- a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
+++ b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
@@ -2566,21 +2566,11 @@ static struct omap_hwmod_ocp_if dra7xx_l3_main_1__hdmi = {
 	.user		= OCP_USER_MPU | OCP_USER_SDMA,
 };
 
-static struct omap_hwmod_addr_space dra7xx_elm_addrs[] = {
-	{
-		.pa_start	= 0x48078000,
-		.pa_end		= 0x48078fff,
-		.flags		= ADDR_TYPE_RT
-	},
-	{ }
-};
-
 /* l4_per1 -> elm */
 static struct omap_hwmod_ocp_if dra7xx_l4_per1__elm = {
 	.master		= &dra7xx_l4_per1_hwmod,
 	.slave		= &dra7xx_elm_hwmod,
 	.clk		= "l3_iclk_div",
-	.addr		= dra7xx_elm_addrs,
 	.user		= OCP_USER_MPU | OCP_USER_SDMA,
 };
 
-- 
2.6.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]


#1245749 — Re: [PATCH] ARM: DRA7: hwmod: Remove elm address space from hwmod data

FromLokesh Vutla <a0131933@ti.com>
Date2015-10-13 16:10 +0200
SubjectRe: [PATCH] ARM: DRA7: hwmod: Remove elm address space from hwmod data
Message-ID<qj8r7-ok-7@gated-at.bofh.it>
In reply to#1245731

On Tuesday 13 October 2015 07:14 PM, Franklin S Cooper Jr wrote:
> ELM address information is provided by device tree. No longer need
> to include this information within hwmod.

Reviewed-by: Lokesh Vutla <lokeshvutla@ti.com>

Thanks and regards,
Lokesh
> 
> Signed-off-by: Franklin S Cooper Jr <fcooper@ti.com>
> ---
>  arch/arm/mach-omap2/omap_hwmod_7xx_data.c | 10 ----------
>  1 file changed, 10 deletions(-)
> 
> diff --git a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
> index 562247b..ad2cc7a 100644
> --- a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
> +++ b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
> @@ -2566,21 +2566,11 @@ static struct omap_hwmod_ocp_if dra7xx_l3_main_1__hdmi = {
>  	.user		= OCP_USER_MPU | OCP_USER_SDMA,
>  };
>  
> -static struct omap_hwmod_addr_space dra7xx_elm_addrs[] = {
> -	{
> -		.pa_start	= 0x48078000,
> -		.pa_end		= 0x48078fff,
> -		.flags		= ADDR_TYPE_RT
> -	},
> -	{ }
> -};
> -
>  /* l4_per1 -> elm */
>  static struct omap_hwmod_ocp_if dra7xx_l4_per1__elm = {
>  	.master		= &dra7xx_l4_per1_hwmod,
>  	.slave		= &dra7xx_elm_hwmod,
>  	.clk		= "l3_iclk_div",
> -	.addr		= dra7xx_elm_addrs,
>  	.user		= OCP_USER_MPU | OCP_USER_SDMA,
>  };
>  
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]


#1246344 — Re: [PATCH] ARM: DRA7: hwmod: Remove elm address space from hwmod data

FromRoger Quadros <rogerq@ti.com>
Date2015-10-14 09:00 +0200
SubjectRe: [PATCH] ARM: DRA7: hwmod: Remove elm address space from hwmod data
Message-ID<qjocx-7w1-5@gated-at.bofh.it>
In reply to#1245731
On 13/10/15 16:44, Franklin S Cooper Jr wrote:
> ELM address information is provided by device tree. No longer need
> to include this information within hwmod.
> 
> Signed-off-by: Franklin S Cooper Jr <fcooper@ti.com>

Acked-by: Roger Quadros <rogerq@ti.com>

Franklin,

Can you please do the same for gpmc_addr as well?

And looks like elm_addr needs to be removed from
omap_hwmod_33xx_43xx_interconnect_data.c and omap_hwmod_44xx_data.c as well, no?

cheers,
-roger

> ---
>  arch/arm/mach-omap2/omap_hwmod_7xx_data.c | 10 ----------
>  1 file changed, 10 deletions(-)
> 
> diff --git a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
> index 562247b..ad2cc7a 100644
> --- a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
> +++ b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
> @@ -2566,21 +2566,11 @@ static struct omap_hwmod_ocp_if dra7xx_l3_main_1__hdmi = {
>  	.user		= OCP_USER_MPU | OCP_USER_SDMA,
>  };
>  
> -static struct omap_hwmod_addr_space dra7xx_elm_addrs[] = {
> -	{
> -		.pa_start	= 0x48078000,
> -		.pa_end		= 0x48078fff,
> -		.flags		= ADDR_TYPE_RT
> -	},
> -	{ }
> -};
> -
>  /* l4_per1 -> elm */
>  static struct omap_hwmod_ocp_if dra7xx_l4_per1__elm = {
>  	.master		= &dra7xx_l4_per1_hwmod,
>  	.slave		= &dra7xx_elm_hwmod,
>  	.clk		= "l3_iclk_div",
> -	.addr		= dra7xx_elm_addrs,
>  	.user		= OCP_USER_MPU | OCP_USER_SDMA,
>  };
>  
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]


#1246692 — Re: [PATCH] ARM: DRA7: hwmod: Remove elm address space from hwmod data

From"Franklin S Cooper Jr." <fcooper@ti.com>
Date2015-10-14 15:10 +0200
SubjectRe: [PATCH] ARM: DRA7: hwmod: Remove elm address space from hwmod data
Message-ID<qjtYB-7PD-1@gated-at.bofh.it>
In reply to#1246344

On 10/14/2015 01:58 AM, Roger Quadros wrote:
> On 13/10/15 16:44, Franklin S Cooper Jr wrote:
>> ELM address information is provided by device tree. No longer need
>> to include this information within hwmod.
>>
>> Signed-off-by: Franklin S Cooper Jr <fcooper@ti.com>
> Acked-by: Roger Quadros <rogerq@ti.com>
>
> Franklin,
>
> Can you please do the same for gpmc_addr as well?
>
> And looks like elm_addr needs to be removed from
> omap_hwmod_33xx_43xx_interconnect_data.c and omap_hwmod_44xx_data.c as well, no?
Sure I'll combine the 335x and 44x elm removal with this patch and then create a separate patch for the gpmc version.
>
> cheers,
> -roger
>
>> ---
>>  arch/arm/mach-omap2/omap_hwmod_7xx_data.c | 10 ----------
>>  1 file changed, 10 deletions(-)
>>
>> diff --git a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
>> index 562247b..ad2cc7a 100644
>> --- a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
>> +++ b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
>> @@ -2566,21 +2566,11 @@ static struct omap_hwmod_ocp_if dra7xx_l3_main_1__hdmi = {
>>  	.user		= OCP_USER_MPU | OCP_USER_SDMA,
>>  };
>>  
>> -static struct omap_hwmod_addr_space dra7xx_elm_addrs[] = {
>> -	{
>> -		.pa_start	= 0x48078000,
>> -		.pa_end		= 0x48078fff,
>> -		.flags		= ADDR_TYPE_RT
>> -	},
>> -	{ }
>> -};
>> -
>>  /* l4_per1 -> elm */
>>  static struct omap_hwmod_ocp_if dra7xx_l4_per1__elm = {
>>  	.master		= &dra7xx_l4_per1_hwmod,
>>  	.slave		= &dra7xx_elm_hwmod,
>>  	.clk		= "l3_iclk_div",
>> -	.addr		= dra7xx_elm_addrs,
>>  	.user		= OCP_USER_MPU | OCP_USER_SDMA,
>>  };
>>  
>>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]


#1247462 — Re: [PATCH] ARM: DRA7: hwmod: Remove elm address space from hwmod data

FromPaul Walmsley <paul@pwsan.com>
Date2015-10-15 08:30 +0200
SubjectRe: [PATCH] ARM: DRA7: hwmod: Remove elm address space from hwmod data
Message-ID<qjKd3-6vf-7@gated-at.bofh.it>
In reply to#1246692
On Wed, 14 Oct 2015, Franklin S Cooper Jr. wrote:

> 
> 
> On 10/14/2015 01:58 AM, Roger Quadros wrote:
> > On 13/10/15 16:44, Franklin S Cooper Jr wrote:
> >> ELM address information is provided by device tree. No longer need
> >> to include this information within hwmod.
> >>
> >> Signed-off-by: Franklin S Cooper Jr <fcooper@ti.com>
> > Acked-by: Roger Quadros <rogerq@ti.com>
> >
> > Franklin,
> >
> > Can you please do the same for gpmc_addr as well?
> >
> > And looks like elm_addr needs to be removed from
> > omap_hwmod_33xx_43xx_interconnect_data.c and omap_hwmod_44xx_data.c as well, no?
> Sure I'll combine the 335x and 44x elm removal with this patch and then create a separate patch for the gpmc version.

OK, holding off on this until you update the patch.


- Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web