Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1245543 > unrolled thread

[RFC v2 PATCH 05/14] irq: add struct ipi_mask to irq_data

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [RFC v2 PATCH 05/14] irq: add struct ipi_mask to irq_data Qais Yousef <qais.yousef@imgtec.com> - 2015-10-13 12:20 +0200
    Re: [RFC v2 PATCH 05/14] irq: add struct ipi_mask to irq_data kbuild test robot <lkp@intel.com> - 2015-10-13 14:40 +0200
    Re: [RFC v2 PATCH 05/14] irq: add struct ipi_mask to irq_data Davidlohr Bueso <dave@stgolabs.net> - 2015-10-14 17:00 +0200
      Re: [RFC v2 PATCH 05/14] irq: add struct ipi_mask to irq_data Qais Yousef <qais.yousef@imgtec.com> - 2015-10-14 17:50 +0200

#1245543 — [RFC v2 PATCH 05/14] irq: add struct ipi_mask to irq_data

It has a similar role to affinity mask, but tracks the IPI affinity instead.

Signed-off-by: Qais Yousef <qais.yousef@imgtec.com>
---
 include/linux/irq.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/linux/irq.h b/include/linux/irq.h
index 504133671985..b000b217ea24 100644
--- a/include/linux/irq.h
+++ b/include/linux/irq.h
@@ -157,6 +157,7 @@ struct irq_common_data {
 	void			*handler_data;
 	struct msi_desc		*msi_desc;
 	cpumask_var_t		affinity;
+	struct ipi_mask		ipi_mask;
 };
 
 /**
-- 
2.1.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1245676

[Multipart message — attachments visible in raw view] — view raw

Hi Qais,

[auto build test WARNING on v4.3-rc5 -- if it's inappropriate base, please suggest rules for selecting the more suitable base]

url:    https://github.com/0day-ci/linux/commits/Qais-Yousef/Implement-generic-IPI-support-mechanism/20151013-182314
reproduce: make htmldocs

All warnings (new ones prefixed by >>):

>> include/linux/irq.h:161: warning: No description found for parameter 'ipi_mask'
   kernel/irq/handle.c:1: warning: no structured comments found

vim +/ipi_mask +161 include/linux/irq.h

0d0b4c86 Jiang Liu       2015-06-01  145   * @state_use_accessors: status information for irq chip functions.
0d0b4c86 Jiang Liu       2015-06-01  146   *			Use accessor functions to deal with it
449e9cae Jiang Liu       2015-06-01  147   * @node:		node index useful for balancing
af7080e0 Jiang Liu       2015-06-01  148   * @handler_data:	per-IRQ data for the irq_chip methods
9df872fa Jiang Liu       2015-06-03  149   * @affinity:		IRQ affinity on SMP
b237721c Jiang Liu       2015-06-01  150   * @msi_desc:		MSI descriptor
0d0b4c86 Jiang Liu       2015-06-01  151   */
0d0b4c86 Jiang Liu       2015-06-01  152  struct irq_common_data {
0d0b4c86 Jiang Liu       2015-06-01  153  	unsigned int		state_use_accessors;
449e9cae Jiang Liu       2015-06-01  154  #ifdef CONFIG_NUMA
449e9cae Jiang Liu       2015-06-01  155  	unsigned int		node;
449e9cae Jiang Liu       2015-06-01  156  #endif
af7080e0 Jiang Liu       2015-06-01  157  	void			*handler_data;
b237721c Jiang Liu       2015-06-01  158  	struct msi_desc		*msi_desc;
9df872fa Jiang Liu       2015-06-03  159  	cpumask_var_t		affinity;
9bed7dd6 Qais Yousef     2015-10-13  160  	struct ipi_mask		ipi_mask;
0d0b4c86 Jiang Liu       2015-06-01 @161  };
0d0b4c86 Jiang Liu       2015-06-01  162  
0d0b4c86 Jiang Liu       2015-06-01  163  /**
0d0b4c86 Jiang Liu       2015-06-01  164   * struct irq_data - per irq chip data passed down to chip functions
966dc736 Thomas Gleixner 2013-05-06  165   * @mask:		precomputed bitmask for accessing the chip registers
ff7dcd44 Thomas Gleixner 2010-09-27  166   * @irq:		interrupt number
08a543ad Grant Likely    2011-07-26  167   * @hwirq:		hardware interrupt number, local to the interrupt domain
0d0b4c86 Jiang Liu       2015-06-01  168   * @common:		point to data shared by all irqchips
ff7dcd44 Thomas Gleixner 2010-09-27  169   * @chip:		low level interrupt hardware access

:::::: The code at line 161 was first introduced by commit
:::::: 0d0b4c866bcce647f40d73efe5e90aeeb079050a genirq: Introduce struct irq_common_data to host shared irq data

:::::: TO: Jiang Liu <jiang.liu@linux.intel.com>
:::::: CC: Thomas Gleixner <tglx@linutronix.de>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[toc] | [prev] | [next] | [standalone]

#1246860

On Tue, 13 Oct 2015, Qais Yousef wrote:

>It has a similar role to affinity mask, but tracks the IPI affinity instead.
>
>Signed-off-by: Qais Yousef <qais.yousef@imgtec.com>
>---
> include/linux/irq.h | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/include/linux/irq.h b/include/linux/irq.h
>index 504133671985..b000b217ea24 100644
>--- a/include/linux/irq.h
>+++ b/include/linux/irq.h
>@@ -157,6 +157,7 @@ struct irq_common_data {
> 	void			*handler_data;
> 	struct msi_desc		*msi_desc;
> 	cpumask_var_t		affinity;
>+	struct ipi_mask		ipi_mask;
> };

This should be folded into patch 3, no?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1246923

On 10/14/2015 03:50 PM, Davidlohr Bueso wrote:
> On Tue, 13 Oct 2015, Qais Yousef wrote:
>
>> It has a similar role to affinity mask, but tracks the IPI affinity 
>> instead.
>>
>> Signed-off-by: Qais Yousef <qais.yousef@imgtec.com>
>> ---
>> include/linux/irq.h | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/include/linux/irq.h b/include/linux/irq.h
>> index 504133671985..b000b217ea24 100644
>> --- a/include/linux/irq.h
>> +++ b/include/linux/irq.h
>> @@ -157,6 +157,7 @@ struct irq_common_data {
>>     void            *handler_data;
>>     struct msi_desc        *msi_desc;
>>     cpumask_var_t        affinity;
>> +    struct ipi_mask        ipi_mask;
>> };
>
> This should be folded into patch 3, no?

For me they are 2 separate changes, hence the 2 commits. They could be 
folded but I prefer the septation unless there's a strong opinion not to.

Thanks,
Qais
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web