Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1245115 > unrolled thread

Re: [PATCH] x86: Fix thermal throttling reporting after kexec

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] x86: Fix thermal throttling reporting after kexec Thomas Gleixner <tglx@linutronix.de> - 2015-10-12 22:40 +0200
    Re: [PATCH] x86: Fix thermal throttling reporting after kexec Borislav Petkov <bp@alien8.de> - 2015-10-13 13:10 +0200

#1245115 — Re: [PATCH] x86: Fix thermal throttling reporting after kexec

On Mon, 12 Oct 2015, Andi Kleen wrote:
> From: Andi Kleen <ak@linux.intel.com>
> 
> The per CPU thermal vector init code checks if the thermal
> vector is already installed and complains and bails out if
> it is.
> 
> This happens after kexec, as kernel shut down does
> not clear the thermal vector APIC register.
> 
> This causes two problems:
> 
> So we always do not fully initialize thermal reports
> after kexec. The CPU is still likely initialized,
> as the previous kernel should have done it. But
> we don't set up the software pointer to the thermal
> vector, so reporting may end up with a unknown thermal
> interrupt message.
> 
> Also it complains for every logical CPU, even though the
> value is actually derived from BP only.
> 
> The problem is that we end up with one message per CPU,
> so on larger systems it becomes very noisy and messes up
> the otherwise nicely formatted CPU bootup numbers in
> the kernel log.
> 
> Just remove the check. I checked the code and there's
> no valid code paths where the thermal init code for a CPU
> could be called multiple times.
> 
> Why the kernel does not clean up this value on shutdown:
> 
> The thermal monitoring is controlled per logical CPU thread.
> Normal shutdown code is just running on one CPU.
> To disable it we would need a broadcast NMI to all CPUs
> on shut down. That's overkill for this. So we just
> ignore it after kexec.
> 
> v2: Updated commit log to discuss why the value is not
> cleaned up on shutdown.
> Signed-off-by: Andi Kleen <ak@linux.intel.com>

Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1245591

On Mon, Oct 12, 2015 at 10:33:53PM +0200, Thomas Gleixner wrote:
> On Mon, 12 Oct 2015, Andi Kleen wrote:
> > From: Andi Kleen <ak@linux.intel.com>
> > 
> > The per CPU thermal vector init code checks if the thermal
> > vector is already installed and complains and bails out if
> > it is.
> > 
> > This happens after kexec, as kernel shut down does
> > not clear the thermal vector APIC register.
> > 
> > This causes two problems:
> > 
> > So we always do not fully initialize thermal reports
> > after kexec. The CPU is still likely initialized,
> > as the previous kernel should have done it. But
> > we don't set up the software pointer to the thermal
> > vector, so reporting may end up with a unknown thermal
> > interrupt message.
> > 
> > Also it complains for every logical CPU, even though the
> > value is actually derived from BP only.
> > 
> > The problem is that we end up with one message per CPU,
> > so on larger systems it becomes very noisy and messes up
> > the otherwise nicely formatted CPU bootup numbers in
> > the kernel log.
> > 
> > Just remove the check. I checked the code and there's
> > no valid code paths where the thermal init code for a CPU
> > could be called multiple times.
> > 
> > Why the kernel does not clean up this value on shutdown:
> > 
> > The thermal monitoring is controlled per logical CPU thread.
> > Normal shutdown code is just running on one CPU.
> > To disable it we would need a broadcast NMI to all CPUs
> > on shut down. That's overkill for this. So we just
> > ignore it after kexec.
> > 
> > v2: Updated commit log to discuss why the value is not
> > cleaned up on shutdown.
> > Signed-off-by: Andi Kleen <ak@linux.intel.com>
> 
> Reviewed-by: Thomas Gleixner <tglx@linutronix.de>

Applied,
thanks!

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web