Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1244996 > unrolled thread

[PATCH v2 2/4] Staging: rtl8712: Use ether_addr_equal() over memcmp()

Back to article view | Back to linux.kernel

Contents

  [PATCH v2 2/4] Staging: rtl8712: Use ether_addr_equal() over memcmp() Punit Vara <punitvara@gmail.com> - 2015-10-12 20:50 +0200
    Re: [PATCH v2 2/4] Staging: rtl8712: Use ether_addr_equal() over memcmp() punit vara <punitvara@gmail.com> - 2015-10-12 20:50 +0200
      Re: [PATCH v2 2/4] Staging: rtl8712: Use ether_addr_equal() over  memcmp() Greg KH <gregkh@linuxfoundation.org> - 2015-10-13 07:50 +0200

#1244996 — [PATCH v2 2/4] Staging: rtl8712: Use ether_addr_equal() over memcmp()

This patch is to the rtl871x_ioctl_linux.c file that fixes up following
warning reported by checkpatch.pl :

-Prefer ether_addr_equal() or ether_addr_equal_unaligned() over memcmp()

bssid and pnetwork->network.MacAddress both are 6 byte
array which aligned with u16

Signed-off-by: Punit Vara <punitvara@gmail.com>
---
 drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
index 143be0f..b19556a 100644
--- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
+++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
@@ -2008,7 +2008,7 @@ static int r871x_get_ap_info(struct net_device *dev,
 			return -EINVAL;
 		}
 		netdev_info(dev, "r8712u: BSSID:%pM\n", bssid);
-		if (!memcmp(bssid, pnetwork->network.MacAddress, ETH_ALEN)) {
+		if (ether_addr_equal(bssid, pnetwork->network.MacAddress)) {
 			/* BSSID match, then check if supporting wpa/wpa2 */
 			pbuf = r8712_get_wpa_ie(&pnetwork->network.IEs[12],
 			       &wpa_ielen, pnetwork->network.IELength-12);
-- 
2.5.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1245009

On Tue, Oct 13, 2015 at 12:16 AM, Punit Vara <punitvara@gmail.com> wrote:
> This patch is to the rtl871x_ioctl_linux.c file that fixes up following
> warning reported by checkpatch.pl :
>
> -Prefer ether_addr_equal() or ether_addr_equal_unaligned() over memcmp()
>
> bssid and pnetwork->network.MacAddress both are 6 byte
> array which aligned with u16
>
> Signed-off-by: Punit Vara <punitvara@gmail.com>
> ---
>  drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
> index 143be0f..b19556a 100644
> --- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
> +++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
> @@ -2008,7 +2008,7 @@ static int r871x_get_ap_info(struct net_device *dev,
>                         return -EINVAL;
>                 }
>                 netdev_info(dev, "r8712u: BSSID:%pM\n", bssid);
> -               if (!memcmp(bssid, pnetwork->network.MacAddress, ETH_ALEN)) {
> +               if (ether_addr_equal(bssid, pnetwork->network.MacAddress)) {
>                         /* BSSID match, then check if supporting wpa/wpa2 */
>                         pbuf = r8712_get_wpa_ie(&pnetwork->network.IEs[12],
>                                &wpa_ielen, pnetwork->network.IELength-12);
> --
> 2.5.3
>

I have updated the patch as per feedback from various developers. As I
am sending second time subject should be patch v2 right ?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1245356 — Re: [PATCH v2 2/4] Staging: rtl8712: Use ether_addr_equal() over memcmp()

On Tue, Oct 13, 2015 at 12:19:12AM +0530, punit vara wrote:
> On Tue, Oct 13, 2015 at 12:16 AM, Punit Vara <punitvara@gmail.com> wrote:
> > This patch is to the rtl871x_ioctl_linux.c file that fixes up following
> > warning reported by checkpatch.pl :
> >
> > -Prefer ether_addr_equal() or ether_addr_equal_unaligned() over memcmp()
> >
> > bssid and pnetwork->network.MacAddress both are 6 byte
> > array which aligned with u16
> >
> > Signed-off-by: Punit Vara <punitvara@gmail.com>
> > ---
> >  drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
> > index 143be0f..b19556a 100644
> > --- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
> > +++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
> > @@ -2008,7 +2008,7 @@ static int r871x_get_ap_info(struct net_device *dev,
> >                         return -EINVAL;
> >                 }
> >                 netdev_info(dev, "r8712u: BSSID:%pM\n", bssid);
> > -               if (!memcmp(bssid, pnetwork->network.MacAddress, ETH_ALEN)) {
> > +               if (ether_addr_equal(bssid, pnetwork->network.MacAddress)) {
> >                         /* BSSID match, then check if supporting wpa/wpa2 */
> >                         pbuf = r8712_get_wpa_ie(&pnetwork->network.IEs[12],
> >                                &wpa_ielen, pnetwork->network.IELength-12);
> > --
> > 2.5.3
> >
> 
> I have updated the patch as per feedback from various developers. As I
> am sending second time subject should be patch v2 right ?

Please resend the whole series please.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web