Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1245317 > unrolled thread

[PATCH] drivers :staging: android: make alignment match open parenthesis

Back to article view | Back to linux.kernel

Contents

  [PATCH] drivers :staging: android: make alignment match open parenthesis Liao Tonglang <liaotonglang@gmail.com> - 2015-10-13 05:40 +0200
    Re: [PATCH] drivers :staging: android: make alignment match open  parenthesis Greg KH <gregkh@linuxfoundation.org> - 2015-10-13 08:00 +0200
      Re: [PATCH] drivers :staging: android: make alignment match open  parenthesis Liao Tonglang <liaotonglang@gmail.com> - 2015-10-13 08:30 +0200

#1245317 — [PATCH] drivers :staging: android: make alignment match open parenthesis

Cleanup for checkpatch.pl warn below:
	CHECK: Alignment should match open parenthesis
	#836: FILE: drivers/staging/android/ashmem.c:836:
by split three lines to four.

Signed-off-by: Liao Tonglang <liaotonglang@gmail.com>
---
 drivers/staging/android/ashmem.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/android/ashmem.c b/drivers/staging/android/ashmem.c
index 60200a3..99fc7dc 100644
--- a/drivers/staging/android/ashmem.c
+++ b/drivers/staging/android/ashmem.c
@@ -832,9 +832,10 @@ static int __init ashmem_init(void)
 {
 	int ret;
 
-	ashmem_area_cachep = kmem_cache_create("ashmem_area_cache",
-					  sizeof(struct ashmem_area),
-					  0, 0, NULL);
+	ashmem_area_cachep =
+		kmem_cache_create("ashmem_area_cache",
+				  sizeof(struct ashmem_area),
+				  0, 0, NULL);
 	if (unlikely(!ashmem_area_cachep)) {
 		pr_err("failed to create slab cache\n");
 		return -ENOMEM;
-- 
1.8.3.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1245359 — Re: [PATCH] drivers :staging: android: make alignment match open parenthesis

On Tue, Oct 13, 2015 at 11:32:31AM +0800, Liao Tonglang wrote:
> Cleanup for checkpatch.pl warn below:
> 	CHECK: Alignment should match open parenthesis
> 	#836: FILE: drivers/staging/android/ashmem.c:836:
> by split three lines to four.
> 
> Signed-off-by: Liao Tonglang <liaotonglang@gmail.com>
> ---
>  drivers/staging/android/ashmem.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/android/ashmem.c b/drivers/staging/android/ashmem.c
> index 60200a3..99fc7dc 100644
> --- a/drivers/staging/android/ashmem.c
> +++ b/drivers/staging/android/ashmem.c
> @@ -832,9 +832,10 @@ static int __init ashmem_init(void)
>  {
>  	int ret;
>  
> -	ashmem_area_cachep = kmem_cache_create("ashmem_area_cache",
> -					  sizeof(struct ashmem_area),
> -					  0, 0, NULL);
> +	ashmem_area_cachep =
> +		kmem_cache_create("ashmem_area_cache",
> +				  sizeof(struct ashmem_area),
> +				  0, 0, NULL);


Now you are just getting very picky for checkpatch issues, is this
really more readable?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1245370 — Re: [PATCH] drivers :staging: android: make alignment match open parenthesis

On Tue, Oct 13, 2015 at 11:40:00AM +0800, Greg KH wrote:
>> -	ashmem_area_cachep = kmem_cache_create("ashmem_area_cache",
>> -					  sizeof(struct ashmem_area),
>> -					  0, 0, NULL);
>> +	ashmem_area_cachep =
>> +		kmem_cache_create("ashmem_area_cache",
>> +				  sizeof(struct ashmem_area),
>> +				  0, 0, NULL);
> is this really more readable?

You are right. The four-line version looks stupid. Just ignore
these changes.

Thanks for your patience,

liao
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web