Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1245178 > unrolled thread

Re: randconfig build error with next-20151009, in lib/zlib_deflate/deftree.c

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: randconfig build error with next-20151009, in  lib/zlib_deflate/deftree.c Andrew Morton <akpm@linux-foundation.org> - 2015-10-13 00:00 +0200

#1245178 — Re: randconfig build error with next-20151009, in lib/zlib_deflate/deftree.c

On Fri, 9 Oct 2015 13:38:25 -0700 Jim Davis <jim.epost@gmail.com> wrote:

> Building with the attached random configuration file,
> 
> lib/built-in.o: In function `__bitrev32':
> deftree.c:(.text+0x1e799): undefined reference to `byte_rev_table'
> deftree.c:(.text+0x1e7a0): undefined reference to `byte_rev_table'
> deftree.c:(.text+0x1e7b4): undefined reference to `byte_rev_table'
> deftree.c:(.text+0x1e7c1): undefined reference to `byte_rev_table'

This is really irritating.  We save 287 bytes in kernels which don't
use bitrev.  It isn't worth the hassle, but let's keep plugging.



From: Andrew Morton <akpm@linux-foundation.org>
Subject: lib/Kconfig: ZLIB_DEFLATE must select BITREVERSE

lib/built-in.o: In function `__bitrev32':
deftree.c:(.text+0x1e799): undefined reference to `byte_rev_table'
deftree.c:(.text+0x1e7a0): undefined reference to `byte_rev_table'
deftree.c:(.text+0x1e7b4): undefined reference to `byte_rev_table'
deftree.c:(.text+0x1e7c1): undefined reference to `byte_rev_table'

Anything which uses bitrevX() has to select BITREVERSE, to grab
lib/bitrev.o.

Reported-by: Jim Davis <jim.epost@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 lib/Kconfig |    1 +
 1 file changed, 1 insertion(+)

diff -puN lib/Kconfig~lib-kconfig-zlib_deflate-must-select-bitreverse lib/Kconfig
--- a/lib/Kconfig~lib-kconfig-zlib_deflate-must-select-bitreverse
+++ a/lib/Kconfig
@@ -220,6 +220,7 @@ config ZLIB_INFLATE
 
 config ZLIB_DEFLATE
 	tristate
+	select BITREVERSE
 
 config LZO_COMPRESS
 	tristate
_


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [standalone]

Back to top | Article view | linux.kernel

csiph-web