Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1242835 > unrolled thread

Re: [PATCH] vfs: remove stale comment in inode_operations

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] vfs: remove stale comment in inode_operations Ross Zwisler <ross.zwisler@linux.intel.com> - 2015-10-09 01:10 +0200
    Re: [PATCH] vfs: remove stale comment in inode_operations Jan Kara <jack@suse.cz> - 2015-10-12 15:50 +0200

#1242835 — Re: [PATCH] vfs: remove stale comment in inode_operations

On Tue, Sep 08, 2015 at 04:59:20PM -0600, Ross Zwisler wrote:
> The big warning comment that is currently at the end of struct
> inode_operations was added as part of this commit:
> 
> 4aa7c6346be3 ("vfs: add i_op->dentry_open()")
> 
> It was added to warn people not to use the newly added 'dentry_open'
> function pointer.
> 
> This function pointer was removed as part of this commit:
> 
> 4bacc9c9234c ("overlayfs: Make f_path always point to the overlay and
> 		f_inode to the underlay")
> 
> The comment was left behind and now refers to nothing, so remove it.
> 
> Signed-off-by: Ross Zwisler <ross.zwisler@linux.intel.com>
> ---
>  include/linux/fs.h | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/include/linux/fs.h b/include/linux/fs.h
> index b2f9b9c..b3ff479 100644
> --- a/include/linux/fs.h
> +++ b/include/linux/fs.h
> @@ -1679,8 +1679,6 @@ struct inode_operations {
>  			   umode_t create_mode, int *opened);
>  	int (*tmpfile) (struct inode *, struct dentry *, umode_t);
>  	int (*set_acl)(struct inode *, struct posix_acl *, int);
> -
> -	/* WARNING: probably going away soon, do not use! */
>  } ____cacheline_aligned;
>  
>  ssize_t rw_copy_check_uvector(int type, const struct iovec __user * uvector,

Ping?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1244703

On Thu 08-10-15 17:07:20, Ross Zwisler wrote:
> On Tue, Sep 08, 2015 at 04:59:20PM -0600, Ross Zwisler wrote:
> > The big warning comment that is currently at the end of struct
> > inode_operations was added as part of this commit:
> > 
> > 4aa7c6346be3 ("vfs: add i_op->dentry_open()")
> > 
> > It was added to warn people not to use the newly added 'dentry_open'
> > function pointer.
> > 
> > This function pointer was removed as part of this commit:
> > 
> > 4bacc9c9234c ("overlayfs: Make f_path always point to the overlay and
> > 		f_inode to the underlay")
> > 
> > The comment was left behind and now refers to nothing, so remove it.
> > 
> > Signed-off-by: Ross Zwisler <ross.zwisler@linux.intel.com>
> > ---
> >  include/linux/fs.h | 2 --
> >  1 file changed, 2 deletions(-)
> > 
> > diff --git a/include/linux/fs.h b/include/linux/fs.h
> > index b2f9b9c..b3ff479 100644
> > --- a/include/linux/fs.h
> > +++ b/include/linux/fs.h
> > @@ -1679,8 +1679,6 @@ struct inode_operations {
> >  			   umode_t create_mode, int *opened);
> >  	int (*tmpfile) (struct inode *, struct dentry *, umode_t);
> >  	int (*set_acl)(struct inode *, struct posix_acl *, int);
> > -
> > -	/* WARNING: probably going away soon, do not use! */
> >  } ____cacheline_aligned;
> >  
> >  ssize_t rw_copy_check_uvector(int type, const struct iovec __user * uvector,
> 
> Ping?

Probably should go to Al. Added to CC.

								Honza
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web