Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1243425 > unrolled thread

[PATCH v2 1/1] x86/early_printk: Use __iomem address space for IO

Started byAndy Shevchenko <andriy.shevchenko@linux.intel.com>
First post2015-10-09 16:30 +0200
Last post2015-10-12 11:20 +0200
Articles 5 — 2 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH v2 1/1] x86/early_printk: Use __iomem address space for IO Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2015-10-09 16:30 +0200
    Re: [PATCH v2 1/1] x86/early_printk: Use __iomem address space for  IO Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2015-10-09 16:40 +0200
    Re: [PATCH v2 1/1] x86/early_printk: Use __iomem address space for  IO Thomas Gleixner <tglx@linutronix.de> - 2015-10-11 21:20 +0200
      Re: [PATCH v2 1/1] x86/early_printk: Use __iomem address space for  IO Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2015-10-12 10:20 +0200
        Re: [PATCH v2 1/1] x86/early_printk: Use __iomem address space for  IO Thomas Gleixner <tglx@linutronix.de> - 2015-10-12 11:20 +0200

#1243425 — [PATCH v2 1/1] x86/early_printk: Use __iomem address space for IO

FromAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Date2015-10-09 16:30 +0200
Subject[PATCH v2 1/1] x86/early_printk: Use __iomem address space for IO
Message-ID<qhGQk-4IM-43@gated-at.bofh.it>
There are following warnings on unpatched code:

arch/x86/kernel/early_printk.c:198:32: warning: incorrect type in initializer (different address spaces)
arch/x86/kernel/early_printk.c:198:32:    expected void [noderef] <asn:2>*vaddr
arch/x86/kernel/early_printk.c:198:32:    got unsigned int [usertype] *<noident>
arch/x86/kernel/early_printk.c:205:32: warning: incorrect type in initializer (different address spaces)
arch/x86/kernel/early_printk.c:205:32:    expected void [noderef] <asn:2>*vaddr
arch/x86/kernel/early_printk.c:205:32:    got unsigned int [usertype] *<noident>

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
v2:
- amend subject line
 arch/x86/kernel/early_printk.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/kernel/early_printk.c b/arch/x86/kernel/early_printk.c
index 076a4a7..77f2f5c 100644
--- a/arch/x86/kernel/early_printk.c
+++ b/arch/x86/kernel/early_printk.c
@@ -195,14 +195,14 @@ static __init void early_serial_init(char *s)
 #ifdef CONFIG_PCI
 static void mem32_serial_out(unsigned long addr, int offset, int value)
 {
-	u32 *vaddr = (u32 *)addr;
+	void __iomem *vaddr = (void __iomem *)addr;
 	/* shift implied by pointer type */
 	writel(value, vaddr + offset);
 }
 
 static unsigned int mem32_serial_in(unsigned long addr, int offset)
 {
-	u32 *vaddr = (u32 *)addr;
+	void __iomem *vaddr = (void __iomem *)addr;
 	/* shift implied by pointer type */
 	return readl(vaddr + offset);
 }
-- 
2.5.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1243435 — Re: [PATCH v2 1/1] x86/early_printk: Use __iomem address space for IO

FromAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Date2015-10-09 16:40 +0200
SubjectRe: [PATCH v2 1/1] x86/early_printk: Use __iomem address space for IO
Message-ID<qhGZZ-4Tm-29@gated-at.bofh.it>
In reply to#1243425
On Fri, 2015-10-09 at 17:29 +0300, Andy Shevchenko wrote:
> There are following warnings on unpatched code:
> 
> arch/x86/kernel/early_printk.c:198:32: warning: incorrect type in 
> initializer (different address spaces)
> arch/x86/kernel/early_printk.c:198:32:    expected void [noderef] 
> <asn:2>*vaddr
> arch/x86/kernel/early_printk.c:198:32:    got unsigned int [usertype] 
> *<noident>
> arch/x86/kernel/early_printk.c:205:32: warning: incorrect type in 
> initializer (different address spaces)
> arch/x86/kernel/early_printk.c:205:32:    expected void [noderef] 
> <asn:2>*vaddr
> arch/x86/kernel/early_printk.c:205:32:    got unsigned int [usertype] 
> *<noident>

This one is wrong, sorry for noise.

> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> v2:
> - amend subject line
>  arch/x86/kernel/early_printk.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/x86/kernel/early_printk.c 
> b/arch/x86/kernel/early_printk.c
> index 076a4a7..77f2f5c 100644
> --- a/arch/x86/kernel/early_printk.c
> +++ b/arch/x86/kernel/early_printk.c
> @@ -195,14 +195,14 @@ static __init void early_serial_init(char *s)
>  #ifdef CONFIG_PCI
>  static void mem32_serial_out(unsigned long addr, int offset, int 
> value)
>  {
> -	u32 *vaddr = (u32 *)addr;
> +	void __iomem *vaddr = (void __iomem *)addr;
>  	/* shift implied by pointer type */
>  	writel(value, vaddr + offset);
>  }
>  
>  static unsigned int mem32_serial_in(unsigned long addr, int offset)
>  {
> -	u32 *vaddr = (u32 *)addr;
> +	void __iomem *vaddr = (void __iomem *)addr;
>  	/* shift implied by pointer type */
>  	return readl(vaddr + offset);
>  }

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1244191 — Re: [PATCH v2 1/1] x86/early_printk: Use __iomem address space for IO

FromThomas Gleixner <tglx@linutronix.de>
Date2015-10-11 21:20 +0200
SubjectRe: [PATCH v2 1/1] x86/early_printk: Use __iomem address space for IO
Message-ID<qiuk1-L5-3@gated-at.bofh.it>
In reply to#1243425
Andy,

On Fri, 9 Oct 2015, Andy Shevchenko wrote:
>  #ifdef CONFIG_PCI
>  static void mem32_serial_out(unsigned long addr, int offset, int value)
>  {
> -	u32 *vaddr = (u32 *)addr;
> +	void __iomem *vaddr = (void __iomem *)addr;
>  	/* shift implied by pointer type */
>  	writel(value, vaddr + offset);

This is broken. Assume vaddr = 0x1000 and offset = 1

==>  u32 *vaddr = 0x1000;
==>  vaddr + offset = 0x1004

with your change

==>  void __iomem *vaddr = 0x1000;

==>  vaddr + offset = 0x1001

This comment is there for a reason:
>  	/* shift implied by pointer type */

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1244470 — Re: [PATCH v2 1/1] x86/early_printk: Use __iomem address space for IO

FromAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Date2015-10-12 10:20 +0200
SubjectRe: [PATCH v2 1/1] x86/early_printk: Use __iomem address space for IO
Message-ID<qiGuR-1Ag-3@gated-at.bofh.it>
In reply to#1244191
On Sun, 2015-10-11 at 21:18 +0200, Thomas Gleixner wrote:
> Andy,
> 
> On Fri, 9 Oct 2015, Andy Shevchenko wrote:
> >  #ifdef CONFIG_PCI
> >  static void mem32_serial_out(unsigned long addr, int offset, int 
> value)
> >  {
> > -     u32 *vaddr = (u32 *)addr;
> > +     void __iomem *vaddr = (void __iomem *)addr;
> >       /* shift implied by pointer type */
> >       writel(value, vaddr + offset);
> 
> This is broken. Assume vaddr = 0x1000 and offset = 1

Yes, I noticed in reply to myself  
http://www.spinics.net/lists/kernel/msg2094143.html

Tests were okay because platform I have is using 8-bit I/O.

Does it make sense to use the following approach?

 void __iomem *vaddr = (void __iomem *)addr;
 writel(value, vaddr + offset << 2);
 

> 
> ==>  u32 *vaddr = 0x1000;
> ==>  vaddr + offset = 0x1004
> 
> with your change
> 
> ==>  void __iomem *vaddr = 0x1000;
> 
> ==>  vaddr + offset = 0x1001
> 
> This comment is there for a reason:
> >       /* shift implied by pointer type */
> 
> Thanks,
> 
>         tglx

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1244513 — Re: [PATCH v2 1/1] x86/early_printk: Use __iomem address space for IO

FromThomas Gleixner <tglx@linutronix.de>
Date2015-10-12 11:20 +0200
SubjectRe: [PATCH v2 1/1] x86/early_printk: Use __iomem address space for IO
Message-ID<qiHqV-2Xd-5@gated-at.bofh.it>
In reply to#1244470
On Mon, 12 Oct 2015, Andy Shevchenko wrote:
> On Sun, 2015-10-11 at 21:18 +0200, Thomas Gleixner wrote:
> > Andy,
> > 
> > On Fri, 9 Oct 2015, Andy Shevchenko wrote:
> > >  #ifdef CONFIG_PCI
> > >  static void mem32_serial_out(unsigned long addr, int offset, int 
> > value)
> > >  {
> > > -     u32 *vaddr = (u32 *)addr;
> > > +     void __iomem *vaddr = (void __iomem *)addr;
> > >       /* shift implied by pointer type */
> > >       writel(value, vaddr + offset);
> > 
> > This is broken. Assume vaddr = 0x1000 and offset = 1
> 
> Yes, I noticed in reply to myself  
> http://www.spinics.net/lists/kernel/msg2094143.html
> 
> Tests were okay because platform I have is using 8-bit I/O.
> 
> Does it make sense to use the following approach?
> 
>  void __iomem *vaddr = (void __iomem *)addr;
>  writel(value, vaddr + offset << 2);

What's wrong with: u32 __iomem *vaddr ?

Thanks,

	tglx


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web