Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1244452 > unrolled thread

[PATCH] linux/compiler.h: fix stale comment on {READ,WRITE}_ONCE

Started byRasmus Villemoes <linux@rasmusvillemoes.dk>
First post2015-10-12 09:50 +0200
Last post2015-10-12 10:10 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] linux/compiler.h: fix stale comment on {READ,WRITE}_ONCE Rasmus Villemoes <linux@rasmusvillemoes.dk> - 2015-10-12 09:50 +0200
    Re: [PATCH] linux/compiler.h: fix stale comment on {READ,WRITE}_ONCE Christian Borntraeger <borntraeger@de.ibm.com> - 2015-10-12 10:10 +0200

#1244452 — [PATCH] linux/compiler.h: fix stale comment on {READ,WRITE}_ONCE

FromRasmus Villemoes <linux@rasmusvillemoes.dk>
Date2015-10-12 09:50 +0200
Subject[PATCH] linux/compiler.h: fix stale comment on {READ,WRITE}_ONCE
Message-ID<qiG1P-MT-9@gated-at.bofh.it>
Commit 7bd3e239d6c6 ("locking: Remove atomicy checks from
{READ,WRITE}_ONCE") removed said warning.

Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
---
 include/linux/compiler.h | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/include/linux/compiler.h b/include/linux/compiler.h
index c836eb2dc44d..1dd0034e15e2 100644
--- a/include/linux/compiler.h
+++ b/include/linux/compiler.h
@@ -237,8 +237,7 @@ static __always_inline void __write_once_size(volatile void *p, void *res, int s
  * In contrast to ACCESS_ONCE these two macros will also work on aggregate
  * data types like structs or unions. If the size of the accessed data
  * type exceeds the word size of the machine (e.g., 32 bits or 64 bits)
- * READ_ONCE() and WRITE_ONCE()  will fall back to memcpy and print a
- * compile-time warning.
+ * READ_ONCE() and WRITE_ONCE()  will fall back to memcpy.
  *
  * Their two major use cases are: (1) Mediating communication between
  * process-level code and irq/NMI handlers, all running on the same CPU,
-- 
2.1.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]


#1244466

FromChristian Borntraeger <borntraeger@de.ibm.com>
Date2015-10-12 10:10 +0200
Message-ID<qiGlc-1p0-5@gated-at.bofh.it>
In reply to#1244452
Am 12.10.2015 um 09:46 schrieb Rasmus Villemoes:
> Commit 7bd3e239d6c6 ("locking: Remove atomicy checks from
> {READ,WRITE}_ONCE") removed said warning.
> 
> Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
> ---
>  include/linux/compiler.h | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/include/linux/compiler.h b/include/linux/compiler.h
> index c836eb2dc44d..1dd0034e15e2 100644
> --- a/include/linux/compiler.h
> +++ b/include/linux/compiler.h
> @@ -237,8 +237,7 @@ static __always_inline void __write_once_size(volatile void *p, void *res, int s
>   * In contrast to ACCESS_ONCE these two macros will also work on aggregate
>   * data types like structs or unions. If the size of the accessed data
>   * type exceeds the word size of the machine (e.g., 32 bits or 64 bits)
> - * READ_ONCE() and WRITE_ONCE()  will fall back to memcpy and print a
> - * compile-time warning.
> + * READ_ONCE() and WRITE_ONCE()  will fall back to memcpy.
>   *
>   * Their two major use cases are: (1) Mediating communication between
>   * process-level code and irq/NMI handlers, all running on the same CPU,
> 

Acked-by: Christian Borntraeger <borntraeger@de.ibm.com>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web