Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1244427 > unrolled thread
| Started by | Borun Fu <borun.fu@linux.intel.com> |
|---|---|
| First post | 2015-10-12 09:20 +0200 |
| Last post | 2015-10-14 10:10 +0200 |
| Articles | 6 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] mfd: axp20x: Add a cell for the power button part of the,axp288 PMICs Borun Fu <borun.fu@linux.intel.com> - 2015-10-12 09:20 +0200
Re: [PATCH] mfd: axp20x: Add a cell for the power button part of the,axp288 PMICs Lee Jones <lee.jones@linaro.org> - 2015-10-13 10:20 +0200
RE: [PATCH] mfd: axp20x: Add a cell for the power button part of the,axp288 PMICs "Yang, Fei" <fei.yang@intel.com> - 2015-10-13 20:40 +0200
Re: [PATCH] mfd: axp20x: Add a cell for the power button part of the,axp288 PMICs Lee Jones <lee.jones@linaro.org> - 2015-10-14 09:10 +0200
Re: [PATCH] mfd: axp20x: Add a cell for the power button part of the,axp288 PMICs Borun Fu <borun.fu@linux.intel.com> - 2015-10-14 09:50 +0200
Re: [PATCH] mfd: axp20x: Add a cell for the power button part of the,axp288 PMICs Lee Jones <lee.jones@linaro.org> - 2015-10-14 10:10 +0200
| From | Borun Fu <borun.fu@linux.intel.com> |
|---|---|
| Date | 2015-10-12 09:20 +0200 |
| Subject | [PATCH] mfd: axp20x: Add a cell for the power button part of the,axp288 PMICs |
| Message-ID | <qiFyN-em-1@gated-at.bofh.it> |
This patch adds the mfd cell info for axp288 power key device.
Signed-off-by: Borun Fu <borun.fu@linux.intel.com>
Signed-off-by: Fei Yang <fei.yang@intel.com>
---
drivers/mfd/axp20x.c | 20 ++++++++++++++++++++
1 file changed, 20 insertions(+)
diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c
index 3f576b7..3f4e11f 100644
--- a/drivers/mfd/axp20x.c
+++ b/drivers/mfd/axp20x.c
@@ -161,6 +161,21 @@ static struct resource axp22x_pek_resources[] = {
},
};
+static struct resource axp288_power_button_resources[] = {
+ {
+ .name = "PEK_DBR",
+ .start = AXP288_IRQ_POKN,
+ .end = AXP288_IRQ_POKN,
+ .flags = IORESOURCE_IRQ,
+ },
+ {
+ .name = "PEK_DBF",
+ .start = AXP288_IRQ_POKP,
+ .end = AXP288_IRQ_POKP,
+ .flags = IORESOURCE_IRQ,
+ },
+};
+
static struct resource axp288_fuel_gauge_resources[] = {
{
.start = AXP288_IRQ_QWBTU,
@@ -572,6 +587,11 @@ static struct mfd_cell axp288_cells[] = {
.resources = axp288_fuel_gauge_resources,
},
{
+ .name = "axp20x-pek", /* axp20x-pek works for AXP288 as well */
+ .num_resources = ARRAY_SIZE(axp288_power_button_resources),
+ .resources = axp288_power_button_resources,
+ },
+ {
.name = "axp288_pmic_acpi",
},
};
--
1.7.10.4
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Lee Jones <lee.jones@linaro.org> |
|---|---|
| Date | 2015-10-13 10:20 +0200 |
| Message-ID | <qj2Yr-Lw-35@gated-at.bofh.it> |
| In reply to | #1244427 |
On Mon, 12 Oct 2015, Borun Fu wrote:
> This patch adds the mfd cell info for axp288 power key device.
>
> Signed-off-by: Borun Fu <borun.fu@linux.intel.com>
> Signed-off-by: Fei Yang <fei.yang@intel.com>
> ---
> drivers/mfd/axp20x.c | 20 ++++++++++++++++++++
> 1 file changed, 20 insertions(+)
>
> diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c
> index 3f576b7..3f4e11f 100644
> --- a/drivers/mfd/axp20x.c
> +++ b/drivers/mfd/axp20x.c
> @@ -161,6 +161,21 @@ static struct resource axp22x_pek_resources[] = {
> },
> };
>
> +static struct resource axp288_power_button_resources[] = {
> + {
> + .name = "PEK_DBR",
> + .start = AXP288_IRQ_POKN,
> + .end = AXP288_IRQ_POKN,
> + .flags = IORESOURCE_IRQ,
> + },
> + {
> + .name = "PEK_DBF",
> + .start = AXP288_IRQ_POKP,
> + .end = AXP288_IRQ_POKP,
> + .flags = IORESOURCE_IRQ,
> + },
> +};
> +
> static struct resource axp288_fuel_gauge_resources[] = {
> {
> .start = AXP288_IRQ_QWBTU,
> @@ -572,6 +587,11 @@ static struct mfd_cell axp288_cells[] = {
> .resources = axp288_fuel_gauge_resources,
> },
> {
> + .name = "axp20x-pek", /* axp20x-pek works for AXP288 as well */
Doesn't this change insinuate that?
If axp20x-pek didn't work for AXP288 you wouldn't have put it in this
structure right?
> + .num_resources = ARRAY_SIZE(axp288_power_button_resources),
> + .resources = axp288_power_button_resources,
> + },
> + {
> .name = "axp288_pmic_acpi",
> },
> };
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | "Yang, Fei" <fei.yang@intel.com> |
|---|---|
| Date | 2015-10-13 20:40 +0200 |
| Message-ID | <qjcEq-6q9-19@gated-at.bofh.it> |
| In reply to | #1245451 |
Pj4gIHN0YXRpYyBzdHJ1Y3QgcmVzb3VyY2UgYXhwMjg4X2Z1ZWxfZ2F1Z2VfcmVzb3VyY2VzW10g PSB7DQo+PiAgCXsNCj4+ICAJCS5zdGFydCA9IEFYUDI4OF9JUlFfUVdCVFUsDQo+PiBAQCAtNTcy LDYgKzU4NywxMSBAQCBzdGF0aWMgc3RydWN0IG1mZF9jZWxsIGF4cDI4OF9jZWxsc1tdID0gew0K Pj4gIAkJLnJlc291cmNlcyA9IGF4cDI4OF9mdWVsX2dhdWdlX3Jlc291cmNlcywNCj4+ICAJfSwN Cj4+ICAJew0KPj4gKwkJLm5hbWUgPSAiYXhwMjB4LXBlayIsIC8qIGF4cDIweC1wZWsgd29ya3Mg Zm9yIEFYUDI4OCBhcyB3ZWxsICovDQo+DQo+RG9lc24ndCB0aGlzIGNoYW5nZSBpbnNpbnVhdGUg dGhhdD8NCj4NCj5JZiBheHAyMHgtcGVrIGRpZG4ndCB3b3JrIGZvciBBWFAyODggeW91IHdvdWxk bid0IGhhdmUgcHV0IGl0IGluIHRoaXMgc3RydWN0dXJlIHJpZ2h0PyANCj4NCg0KQXJlIHlvdSBz dWdnZXN0aW5nIHRvIHJlbW92ZSB0aGUgY29tbWVudD8gSnVzdCB3YW50IHRvIG1ha2Ugc3VyZSBJ IHVuZGVyc3RhbmQgeW91IGNvcnJlY3RseS4NCg0KPj4gKwkJLm51bV9yZXNvdXJjZXMgPSBBUlJB WV9TSVpFKGF4cDI4OF9wb3dlcl9idXR0b25fcmVzb3VyY2VzKSwNCj4+ICsJCS5yZXNvdXJjZXMg PSBheHAyODhfcG93ZXJfYnV0dG9uX3Jlc291cmNlcywNCj4+ICsJfSwNCj4+ICsJew0KPj4gIAkJ Lm5hbWUgPSAiYXhwMjg4X3BtaWNfYWNwaSIsDQo+PiAgCX0sDQo+PiAgfTsNCg0KLS0NCkxlZSBK b25lcw0KTGluYXJvIFNUTWljcm9lbGVjdHJvbmljcyBMYW5kaW5nIFRlYW0gTGVhZCBMaW5hcm8u b3JnIOKUgiBPcGVuIHNvdXJjZSBzb2Z0d2FyZSBmb3IgQVJNIFNvQ3MgRm9sbG93IExpbmFybzog RmFjZWJvb2sgfCBUd2l0dGVyIHwgQmxvZw0K -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Lee Jones <lee.jones@linaro.org> |
|---|---|
| Date | 2015-10-14 09:10 +0200 |
| Message-ID | <qjome-7X8-13@gated-at.bofh.it> |
| In reply to | #1246040 |
On Tue, 13 Oct 2015, Yang, Fei wrote:
> >> static struct resource axp288_fuel_gauge_resources[] = {
> >> {
> >> .start = AXP288_IRQ_QWBTU,
> >> @@ -572,6 +587,11 @@ static struct mfd_cell axp288_cells[] = {
> >> .resources = axp288_fuel_gauge_resources,
> >> },
> >> {
> >> + .name = "axp20x-pek", /* axp20x-pek works for AXP288 as well */
> >
> >Doesn't this change insinuate that?
> >
> >If axp20x-pek didn't work for AXP288 you wouldn't have put it in this structure right?
>
> Are you suggesting to remove the comment? Just want to make sure I understand you correctly.
I am.
> >> + .num_resources = ARRAY_SIZE(axp288_power_button_resources),
> >> + .resources = axp288_power_button_resources,
> >> + },
> >> + {
> >> .name = "axp288_pmic_acpi",
> >> },
> >> };
>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Borun Fu <borun.fu@linux.intel.com> |
|---|---|
| Date | 2015-10-14 09:50 +0200 |
| Message-ID | <qjoYW-ib-23@gated-at.bofh.it> |
| In reply to | #1246349 |
So the patch will be refined to remove the comment as follows. Any else comments?
@@ -572,6 +587,11 @@ static struct mfd_cell axp288_cells[] = {
.resources = axp288_fuel_gauge_resources,
},
{
+ .name = "axp20x-pek",
+ .num_resources = ARRAY_SIZE(axp288_power_button_resources),
+ .resources = axp288_power_button_resources,
+ },
+ {
.name = "axp288_pmic_acpi",
},
};
On 10/14/2015 15:08, Lee Jones wrote:
> On Tue, 13 Oct 2015, Yang, Fei wrote:
>
>>>> static struct resource axp288_fuel_gauge_resources[] = {
>>>> {
>>>> .start = AXP288_IRQ_QWBTU,
>>>> @@ -572,6 +587,11 @@ static struct mfd_cell axp288_cells[] = {
>>>> .resources = axp288_fuel_gauge_resources,
>>>> },
>>>> {
>>>> + .name = "axp20x-pek", /* axp20x-pek works for AXP288 as well */
>>>
>>> Doesn't this change insinuate that?
>>>
>>> If axp20x-pek didn't work for AXP288 you wouldn't have put it in this structure right?
>>
>> Are you suggesting to remove the comment? Just want to make sure I understand you correctly.
>
> I am.
>
>>>> + .num_resources = ARRAY_SIZE(axp288_power_button_resources),
>>>> + .resources = axp288_power_button_resources,
>>>> + },
>>>> + {
>>>> .name = "axp288_pmic_acpi",
>>>> },
>>>> };
>>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Lee Jones <lee.jones@linaro.org> |
|---|---|
| Date | 2015-10-14 10:10 +0200 |
| Message-ID | <qjpii-Uj-13@gated-at.bofh.it> |
| In reply to | #1246377 |
On Wed, 14 Oct 2015, Borun Fu wrote:
> So the patch will be refined to remove the comment as follows. Any
> else comments?
Please don't top post. If you have a comment about something that was
said, please make your comment directly _after_ it (a.k.a inline).
> @@ -572,6 +587,11 @@ static struct mfd_cell axp288_cells[] = {
> .resources = axp288_fuel_gauge_resources,
> },
> {
> + .name = "axp20x-pek",
> + .num_resources = ARRAY_SIZE(axp288_power_button_resources),
> + .resources = axp288_power_button_resources,
> + },
> + {
> .name = "axp288_pmic_acpi",
> },
> };
No need to do this. It doesn't save anyone any time.
Just resubmit the next version of the patch.
> On 10/14/2015 15:08, Lee Jones wrote:
> > On Tue, 13 Oct 2015, Yang, Fei wrote:
> >
> >>>> static struct resource axp288_fuel_gauge_resources[] = {
> >>>> {
> >>>> .start = AXP288_IRQ_QWBTU,
> >>>> @@ -572,6 +587,11 @@ static struct mfd_cell axp288_cells[] = {
> >>>> .resources = axp288_fuel_gauge_resources,
> >>>> },
> >>>> {
> >>>> + .name = "axp20x-pek", /* axp20x-pek works for AXP288 as well */
> >>>
> >>> Doesn't this change insinuate that?
> >>>
> >>> If axp20x-pek didn't work for AXP288 you wouldn't have put it in this structure right?
> >>
> >> Are you suggesting to remove the comment? Just want to make sure I understand you correctly.
> >
> > I am.
> >
> >>>> + .num_resources = ARRAY_SIZE(axp288_power_button_resources),
> >>>> + .resources = axp288_power_button_resources,
> >>>> + },
> >>>> + {
> >>>> .name = "axp288_pmic_acpi",
> >>>> },
> >>>> };
> >>
> >
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web