Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1244102 > unrolled thread

[PATCH] i2c: return probe deferred status on dev_pm_domain_attach

Back to article view | Back to linux.kernel

Contents

  [PATCH] i2c: return probe deferred status on dev_pm_domain_attach Kieran Bingham <kieranbingham@gmail.com> - 2015-10-11 13:40 +0200
    Re: [PATCH] i2c: return probe deferred status on dev_pm_domain_attach Wolfram Sang <wsa@the-dreams.de> - 2015-10-12 09:30 +0200
      Re: [PATCH] i2c: return probe deferred status on dev_pm_domain_attach Wolfram Sang <wsa@the-dreams.de> - 2015-10-12 09:30 +0200
        Re: [PATCH] i2c: return probe deferred status on dev_pm_domain_attach Kieran Bingham <kieranbingham@gmail.com> - 2015-10-12 13:20 +0200
          Re: [PATCH] i2c: return probe deferred status on dev_pm_domain_attach Wolfram Sang <wsa@the-dreams.de> - 2015-10-12 21:50 +0200
            Re: [PATCH] i2c: return probe deferred status on dev_pm_domain_attach Kieran Bingham <kieranbingham@gmail.com> - 2015-10-12 22:00 +0200
      Re: [PATCH] i2c: return probe deferred status on dev_pm_domain_attach Kieran Bingham <kieranbingham@gmail.com> - 2015-10-12 13:20 +0200

#1244102 — [PATCH] i2c: return probe deferred status on dev_pm_domain_attach

A change of return status was introduced in commit 3fffd1283927
("i2c: allow specifying separate wakeup interrupt in device tree")

The commit prevents the defer status being passed up the call stack
appropriately when dev_pm_domain_attach returns -EPROBE_DEFER.

To fix we change this back to the original return status;

Signed-off-by: Kieran Bingham <kieranbingham@gmail.com>
---

 drivers/i2c/i2c-core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c
index 5f89f1e..df83015 100644
--- a/drivers/i2c/i2c-core.c
+++ b/drivers/i2c/i2c-core.c
@@ -701,7 +701,7 @@ static int i2c_device_probe(struct device *dev)
 			goto err_detach_pm_domain;
 	}
 
-	return 0;
+	return status;
 
 err_detach_pm_domain:
 	dev_pm_domain_detach(&client->dev, true);
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1244435

[Multipart message — attachments visible in raw view] — view raw

Hi Kiera,

On Sun, Oct 11, 2015 at 12:39:31PM +0100, Kieran Bingham wrote:
> A change of return status was introduced in commit 3fffd1283927
> ("i2c: allow specifying separate wakeup interrupt in device tree")

Thanks for catching this!

> The commit prevents the defer status being passed up the call stack
> appropriately when dev_pm_domain_attach returns -EPROBE_DEFER.
> 
> To fix we change this back to the original return status;

What about going to the error path?

> Signed-off-by: Kieran Bingham <kieranbingham@gmail.com>

Please add a "Fixes: <sha1>" tag here.

   Wolfram

[toc] | [prev] | [next] | [standalone]

#1244439

[Multipart message — attachments visible in raw view] — view raw

And add the original patch author to CC when resending.

[toc] | [prev] | [next] | [standalone]

#1244595

On 12 October 2015 at 08:24, Wolfram Sang <wsa@the-dreams.de> wrote:
>
> And add the original patch author to CC when resending.
>

Bah - I was sure I'd added him ... must have slipped.

Should I add Cc: stable? or are they notified from the Fixes: tag?
--
Regards

Kieran
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1245071

[Multipart message — attachments visible in raw view] — view raw

> Should I add Cc: stable? or are they notified from the Fixes: tag?

My preference is: I'll add stable when I commit to my tree. I am happy
if people tell me when they think this should be done.

In this case, it should :)

[toc] | [prev] | [next] | [standalone]

#1245083

On 12 October 2015 at 20:40, Wolfram Sang <wsa@the-dreams.de> wrote:
>
>> Should I add Cc: stable? or are they notified from the Fixes: tag?
>
> My preference is: I'll add stable when I commit to my tree. I am happy
> if people tell me when they think this should be done.
>
> In this case, it should :)
>

Agreed :)
I'm happy to follow your process and preference and let you add.

- Patch v2 posted.

--
Regards

Kieran
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1244597

Hi Wolfram,

On 12 October 2015 at 08:23, Wolfram Sang <wsa@the-dreams.de> wrote:
> Hi Kiera,
>
> On Sun, Oct 11, 2015 at 12:39:31PM +0100, Kieran Bingham wrote:
>> A change of return status was introduced in commit 3fffd1283927
>> ("i2c: allow specifying separate wakeup interrupt in device tree")
>
> Thanks for catching this!

NP : Saw it when re-basing my other series.

>> The commit prevents the defer status being passed up the call stack
>> appropriately when dev_pm_domain_attach returns -EPROBE_DEFER.
>>
>> To fix we change this back to the original return status;
>
> What about going to the error path?

Sounds reasonable :D


>> Signed-off-by: Kieran Bingham <kieranbingham@gmail.com>
>
> Please add a "Fixes: <sha1>" tag here.

Sure.

>
>    Wolfram
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web