Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1244340 > unrolled thread

[RFC] arm64: ioremap: add ioremap_cache macro

Started byyalin wang <yalin.wang2010@gmail.com>
First post2015-10-12 04:30 +0200
Last post2015-10-14 14:10 +0200
Articles 8 — 4 participants

Back to article view | Back to linux.kernel

Contents

  [RFC] arm64: ioremap: add ioremap_cache macro yalin wang <yalin.wang2010@gmail.com> - 2015-10-12 04:30 +0200
    Re: [RFC] arm64: ioremap: add ioremap_cache macro Catalin Marinas <catalin.marinas@arm.com> - 2015-10-13 16:20 +0200
      Re: [RFC] arm64: ioremap: add ioremap_cache macro Arnd Bergmann <arnd@arndb.de> - 2015-10-13 16:30 +0200
      Re: [RFC] arm64: ioremap: add ioremap_cache macro Will Deacon <will.deacon@arm.com> - 2015-10-13 16:30 +0200
        Re: [RFC] arm64: ioremap: add ioremap_cache macro Catalin Marinas <catalin.marinas@arm.com> - 2015-10-13 17:30 +0200
          Re: [RFC] arm64: ioremap: add ioremap_cache macro yalin wang <yalin.wang2010@gmail.com> - 2015-10-14 04:50 +0200
            Re: [RFC] arm64: ioremap: add ioremap_cache macro Arnd Bergmann <arnd@arndb.de> - 2015-10-14 10:30 +0200
              Re: [RFC] arm64: ioremap: add ioremap_cache macro yalin wang <yalin.wang2010@gmail.com> - 2015-10-14 14:10 +0200

#1244340 — [RFC] arm64: ioremap: add ioremap_cache macro

Fromyalin wang <yalin.wang2010@gmail.com>
Date2015-10-12 04:30 +0200
Subject[RFC] arm64: ioremap: add ioremap_cache macro
Message-ID<qiB29-25v-1@gated-at.bofh.it>
Add ioremap_cache macro, because some code will test if this macro
is defined or not, and will generate a generric version if not defined,
for example, memremap.c do like this.

Signed-off-by: yalin wang <yalin.wang2010@gmail.com>
---
 arch/arm64/include/asm/io.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/include/asm/io.h b/arch/arm64/include/asm/io.h
index 44be1e0..d6b620c 100644
--- a/arch/arm64/include/asm/io.h
+++ b/arch/arm64/include/asm/io.h
@@ -172,6 +172,7 @@ extern void __iomem *ioremap_cache(phys_addr_t phys_addr, size_t size);
 #define ioremap_wc(addr, size)		__ioremap((addr), (size), __pgprot(PROT_NORMAL_NC))
 #define ioremap_wt(addr, size)		__ioremap((addr), (size), __pgprot(PROT_DEVICE_nGnRE))
 #define iounmap				__iounmap
+#define ioremap_cache                  ioremap_cache
 
 /*
  * io{read,write}{16,32}be() macros
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1245769

FromCatalin Marinas <catalin.marinas@arm.com>
Date2015-10-13 16:20 +0200
Message-ID<qj8AO-zI-19@gated-at.bofh.it>
In reply to#1244340
On Mon, Oct 12, 2015 at 10:28:18AM +0800, yalin wang wrote:
> Add ioremap_cache macro, because some code will test if this macro
> is defined or not, and will generate a generric version if not defined,
> for example, memremap.c do like this.
> 
> Signed-off-by: yalin wang <yalin.wang2010@gmail.com>
> ---
>  arch/arm64/include/asm/io.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm64/include/asm/io.h b/arch/arm64/include/asm/io.h
> index 44be1e0..d6b620c 100644
> --- a/arch/arm64/include/asm/io.h
> +++ b/arch/arm64/include/asm/io.h
> @@ -172,6 +172,7 @@ extern void __iomem *ioremap_cache(phys_addr_t phys_addr, size_t size);
>  #define ioremap_wc(addr, size)		__ioremap((addr), (size), __pgprot(PROT_NORMAL_NC))
>  #define ioremap_wt(addr, size)		__ioremap((addr), (size), __pgprot(PROT_DEVICE_nGnRE))
>  #define iounmap				__iounmap
> +#define ioremap_cache                  ioremap_cache

Applied. Thanks.

-- 
Catalin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1245776

FromArnd Bergmann <arnd@arndb.de>
Date2015-10-13 16:30 +0200
Message-ID<qj8Ku-KS-1@gated-at.bofh.it>
In reply to#1245769
On Tuesday 13 October 2015 15:10:55 Catalin Marinas wrote:
> On Mon, Oct 12, 2015 at 10:28:18AM +0800, yalin wang wrote:
> > Add ioremap_cache macro, because some code will test if this macro
> > is defined or not, and will generate a generric version if not defined,
> > for example, memremap.c do like this.
> > 
> > Signed-off-by: yalin wang <yalin.wang2010@gmail.com>
> > ---
> >  arch/arm64/include/asm/io.h | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/arch/arm64/include/asm/io.h b/arch/arm64/include/asm/io.h
> > index 44be1e0..d6b620c 100644
> > --- a/arch/arm64/include/asm/io.h
> > +++ b/arch/arm64/include/asm/io.h
> > @@ -172,6 +172,7 @@ extern void __iomem *ioremap_cache(phys_addr_t phys_addr, size_t size);
> >  #define ioremap_wc(addr, size)               __ioremap((addr), (size), __pgprot(PROT_NORMAL_NC))
> >  #define ioremap_wt(addr, size)               __ioremap((addr), (size), __pgprot(PROT_DEVICE_nGnRE))
> >  #define iounmap                              __iounmap
> > +#define ioremap_cache                  ioremap_cache
> 
> Applied. Thanks.
> 

I think this will conflict with Dan Williams' series that removes
ioremap_cache from the kernel and replaces it with memremap.c

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1245783

FromWill Deacon <will.deacon@arm.com>
Date2015-10-13 16:30 +0200
Message-ID<qj8Kv-KS-29@gated-at.bofh.it>
In reply to#1245769
On Tue, Oct 13, 2015 at 03:10:55PM +0100, Catalin Marinas wrote:
> On Mon, Oct 12, 2015 at 10:28:18AM +0800, yalin wang wrote:
> > Add ioremap_cache macro, because some code will test if this macro
> > is defined or not, and will generate a generric version if not defined,
> > for example, memremap.c do like this.
> > 
> > Signed-off-by: yalin wang <yalin.wang2010@gmail.com>
> > ---
> >  arch/arm64/include/asm/io.h | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/arch/arm64/include/asm/io.h b/arch/arm64/include/asm/io.h
> > index 44be1e0..d6b620c 100644
> > --- a/arch/arm64/include/asm/io.h
> > +++ b/arch/arm64/include/asm/io.h
> > @@ -172,6 +172,7 @@ extern void __iomem *ioremap_cache(phys_addr_t phys_addr, size_t size);
> >  #define ioremap_wc(addr, size)		__ioremap((addr), (size), __pgprot(PROT_NORMAL_NC))
> >  #define ioremap_wt(addr, size)		__ioremap((addr), (size), __pgprot(PROT_DEVICE_nGnRE))
> >  #define iounmap				__iounmap
> > +#define ioremap_cache                  ioremap_cache
> 
> Applied. Thanks.

I'm not sure we want this. See:

  https://lkml.org/lkml/2015/10/9/699

Will
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1245840

FromCatalin Marinas <catalin.marinas@arm.com>
Date2015-10-13 17:30 +0200
Message-ID<qj9Gz-28L-31@gated-at.bofh.it>
In reply to#1245783
On Tue, Oct 13, 2015 at 03:23:27PM +0100, Will Deacon wrote:
> On Tue, Oct 13, 2015 at 03:10:55PM +0100, Catalin Marinas wrote:
> > On Mon, Oct 12, 2015 at 10:28:18AM +0800, yalin wang wrote:
> > > Add ioremap_cache macro, because some code will test if this macro
> > > is defined or not, and will generate a generric version if not defined,
> > > for example, memremap.c do like this.
> > > 
> > > Signed-off-by: yalin wang <yalin.wang2010@gmail.com>
> > > ---
> > >  arch/arm64/include/asm/io.h | 1 +
> > >  1 file changed, 1 insertion(+)
> > > 
> > > diff --git a/arch/arm64/include/asm/io.h b/arch/arm64/include/asm/io.h
> > > index 44be1e0..d6b620c 100644
> > > --- a/arch/arm64/include/asm/io.h
> > > +++ b/arch/arm64/include/asm/io.h
> > > @@ -172,6 +172,7 @@ extern void __iomem *ioremap_cache(phys_addr_t phys_addr, size_t size);
> > >  #define ioremap_wc(addr, size)		__ioremap((addr), (size), __pgprot(PROT_NORMAL_NC))
> > >  #define ioremap_wt(addr, size)		__ioremap((addr), (size), __pgprot(PROT_DEVICE_nGnRE))
> > >  #define iounmap				__iounmap
> > > +#define ioremap_cache                  ioremap_cache
> > 
> > Applied. Thanks.
> 
> I'm not sure we want this. See:
> 
>   https://lkml.org/lkml/2015/10/9/699

Thanks Will and Arnd, I missed this. Patch reverted.

-- 
Catalin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1246267

Fromyalin wang <yalin.wang2010@gmail.com>
Date2015-10-14 04:50 +0200
Message-ID<qjkiC-1GN-5@gated-at.bofh.it>
In reply to#1245840
> On Oct 13, 2015, at 23:20, Catalin Marinas <catalin.marinas@arm.com> wrote:
> 
> On Tue, Oct 13, 2015 at 03:23:27PM +0100, Will Deacon wrote:
>> On Tue, Oct 13, 2015 at 03:10:55PM +0100, Catalin Marinas wrote:
>>> On Mon, Oct 12, 2015 at 10:28:18AM +0800, yalin wang wrote:
>>>> Add ioremap_cache macro, because some code will test if this macro
>>>> is defined or not, and will generate a generric version if not defined,
>>>> for example, memremap.c do like this.
>>>> 
>>>> Signed-off-by: yalin wang <yalin.wang2010@gmail.com>
>>>> ---
>>>> arch/arm64/include/asm/io.h | 1 +
>>>> 1 file changed, 1 insertion(+)
>>>> 
>>>> diff --git a/arch/arm64/include/asm/io.h b/arch/arm64/include/asm/io.h
>>>> index 44be1e0..d6b620c 100644
>>>> --- a/arch/arm64/include/asm/io.h
>>>> +++ b/arch/arm64/include/asm/io.h
>>>> @@ -172,6 +172,7 @@ extern void __iomem *ioremap_cache(phys_addr_t phys_addr, size_t size);
>>>> #define ioremap_wc(addr, size)		__ioremap((addr), (size), __pgprot(PROT_NORMAL_NC))
>>>> #define ioremap_wt(addr, size)		__ioremap((addr), (size), __pgprot(PROT_DEVICE_nGnRE))
>>>> #define iounmap				__iounmap
>>>> +#define ioremap_cache                  ioremap_cache
>>> 
>>> Applied. Thanks.
>> 
>> I'm not sure we want this. See:
>> 
>>  https://lkml.org/lkml/2015/10/9/699
> 
> Thanks Will and Arnd, I missed this. Patch reverted.
> 
i don’t understand why conflict with Dan Williams’ patch.
Dan Williams ’s patch also define ioremap_cache  for arch ia64  & arch sh & arch xtensa ,
i see this :
# git show   92281dee825f
am i miss something?

Thanks






--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1246395

FromArnd Bergmann <arnd@arndb.de>
Date2015-10-14 10:30 +0200
Message-ID<qjpBD-1hT-1@gated-at.bofh.it>
In reply to#1246267
On Wednesday 14 October 2015 10:41:26 yalin wang wrote:

> > On Oct 13, 2015, at 23:20, Catalin Marinas <catalin.marinas@arm.com> wrote:
> >> I'm not sure we want this. See:
> >> 
> >>  https://lkml.org/lkml/2015/10/9/699
> > 
> > Thanks Will and Arnd, I missed this. Patch reverted.
> > 
> i don’t understand why conflict with Dan Williams’ patch.
> Dan Williams ’s patch also define ioremap_cache  for arch ia64  & arch sh & arch xtensa ,
> i see this :
> # git show   92281dee825f
> am i miss something?

I meant the new series, see https://lkml.org/lkml/2015/10/9/716 for the
patch that removes it again.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1246608

Fromyalin wang <yalin.wang2010@gmail.com>
Date2015-10-14 14:10 +0200
Message-ID<qjt2y-6rP-19@gated-at.bofh.it>
In reply to#1246395
> On Oct 14, 2015, at 16:23, Arnd Bergmann <arnd@arndb.de> wrote:
> 
> On Wednesday 14 October 2015 10:41:26 yalin wang wrote:
> 
>>> On Oct 13, 2015, at 23:20, Catalin Marinas <catalin.marinas@arm.com> wrote:
>>>> I'm not sure we want this. See:
>>>> 
>>>> https://lkml.org/lkml/2015/10/9/699
>>> 
>>> Thanks Will and Arnd, I missed this. Patch reverted.
>>> 
>> i don’t understand why conflict with Dan Williams’ patch.
>> Dan Williams ’s patch also define ioremap_cache  for arch ia64  & arch sh & arch xtensa ,
>> i see this :
>> # git show   92281dee825f
>> am i miss something?
> 
> I meant the new series, see https://lkml.org/lkml/2015/10/9/716 for the
> patch that removes it again.
> 
> 	Arnd
Got it ,
Thanks :)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web