Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1244325 > unrolled thread
| Started by | Wenyou Yang <wenyou.yang@atmel.com> |
|---|---|
| First post | 2015-10-12 03:30 +0200 |
| Last post | 2015-10-12 10:00 +0200 |
| Articles | 5 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] rtc: at91rm9200: clear RTC alarm status flag prior to suspending Wenyou Yang <wenyou.yang@atmel.com> - 2015-10-12 03:30 +0200
Re: [PATCH] rtc: at91rm9200: clear RTC alarm status flag prior to suspending Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2015-10-12 09:00 +0200
RE: [PATCH] rtc: at91rm9200: clear RTC alarm status flag prior to suspending "Yang, Wenyou" <Wenyou.Yang@atmel.com> - 2015-10-12 09:50 +0200
Re: [PATCH] rtc: at91rm9200: clear RTC alarm status flag prior to suspending Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2015-10-12 10:00 +0200
RE: [PATCH] rtc: at91rm9200: clear RTC alarm status flag prior to suspending "Yang, Wenyou" <Wenyou.Yang@atmel.com> - 2015-10-12 10:00 +0200
| From | Wenyou Yang <wenyou.yang@atmel.com> |
|---|---|
| Date | 2015-10-12 03:30 +0200 |
| Subject | [PATCH] rtc: at91rm9200: clear RTC alarm status flag prior to suspending |
| Message-ID | <qiA65-Dv-7@gated-at.bofh.it> |
This patch is to clear the RTC alarm status flag prior to suspending
to avoid the erroneous wake-up activity.
Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>
---
drivers/rtc/rtc-at91rm9200.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/rtc/rtc-at91rm9200.c b/drivers/rtc/rtc-at91rm9200.c
index cb62e21..b60fd47 100644
--- a/drivers/rtc/rtc-at91rm9200.c
+++ b/drivers/rtc/rtc-at91rm9200.c
@@ -495,6 +495,8 @@ static int at91_rtc_suspend(struct device *dev)
/* this IRQ is shared with DBGU and other hardware which isn't
* necessarily doing PM like we are...
*/
+ at91_rtc_write(AT91_RTC_SCCR, AT91_RTC_ALARM);
+
at91_rtc_imr = at91_rtc_read_imr()
& (AT91_RTC_ALARM|AT91_RTC_SECEV);
if (at91_rtc_imr) {
--
1.7.9.5
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Alexandre Belloni <alexandre.belloni@free-electrons.com> |
|---|---|
| Date | 2015-10-12 09:00 +0200 |
| Subject | Re: [PATCH] rtc: at91rm9200: clear RTC alarm status flag prior to suspending |
| Message-ID | <qiFfs-83W-19@gated-at.bofh.it> |
| In reply to | #1244325 |
Hi Wenyou,
On 12/10/2015 at 09:17:57 +0800, Wenyou Yang wrote :
> This patch is to clear the RTC alarm status flag prior to suspending
> to avoid the erroneous wake-up activity.
>
Is this a new issue appearing with the sama5d2 or was it present from
the beginning?
> Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>
> ---
>
> drivers/rtc/rtc-at91rm9200.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/rtc/rtc-at91rm9200.c b/drivers/rtc/rtc-at91rm9200.c
> index cb62e21..b60fd47 100644
> --- a/drivers/rtc/rtc-at91rm9200.c
> +++ b/drivers/rtc/rtc-at91rm9200.c
> @@ -495,6 +495,8 @@ static int at91_rtc_suspend(struct device *dev)
> /* this IRQ is shared with DBGU and other hardware which isn't
> * necessarily doing PM like we are...
> */
> + at91_rtc_write(AT91_RTC_SCCR, AT91_RTC_ALARM);
> +
> at91_rtc_imr = at91_rtc_read_imr()
> & (AT91_RTC_ALARM|AT91_RTC_SECEV);
> if (at91_rtc_imr) {
> --
> 1.7.9.5
>
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | "Yang, Wenyou" <Wenyou.Yang@atmel.com> |
|---|---|
| Date | 2015-10-12 09:50 +0200 |
| Subject | RE: [PATCH] rtc: at91rm9200: clear RTC alarm status flag prior to suspending |
| Message-ID | <qiG1P-MT-1@gated-at.bofh.it> |
| In reply to | #1244419 |
SGkgQWxleGFuZHJlLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEFs ZXhhbmRyZSBCZWxsb25pIFttYWlsdG86YWxleGFuZHJlLmJlbGxvbmlAZnJlZS1lbGVjdHJvbnMu Y29tXQ0KPiBTZW50OiAyMDE1xOoxMNTCMTLI1SAxNDo1Mw0KPiBUbzogWWFuZywgV2VueW91DQo+ IENjOiBBbGVzc2FuZHJvIFp1bW1vOyBGZXJyZSwgTmljb2xhczsgRGVzcm9jaGVzLCBMdWRvdmlj OyBydGMtDQo+IGxpbnV4QGdvb2dsZWdyb3Vwcy5jb207IGxpbnV4LWtlcm5lbEB2Z2VyLmtlcm5l bC5vcmc7IGxpbnV4LWFybS0NCj4ga2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcNCj4gU3ViamVj dDogUmU6IFtQQVRDSF0gcnRjOiBhdDkxcm05MjAwOiBjbGVhciBSVEMgYWxhcm0gc3RhdHVzIGZs YWcgcHJpb3IgdG8NCj4gc3VzcGVuZGluZw0KPiANCj4gSGkgV2VueW91LA0KPiANCj4gT24gMTIv MTAvMjAxNSBhdCAwOToxNzo1NyArMDgwMCwgV2VueW91IFlhbmcgd3JvdGUgOg0KPiA+IFRoaXMg cGF0Y2ggaXMgdG8gY2xlYXIgdGhlIFJUQyBhbGFybSBzdGF0dXMgZmxhZyBwcmlvciB0byBzdXNw ZW5kaW5nDQo+ID4gdG8gYXZvaWQgdGhlIGVycm9uZW91cyB3YWtlLXVwIGFjdGl2aXR5Lg0KPiA+ DQo+IA0KPiBJcyB0aGlzIGEgbmV3IGlzc3VlIGFwcGVhcmluZyB3aXRoIHRoZSBzYW1hNWQyIG9y IHdhcyBpdCBwcmVzZW50IGZyb20gdGhlDQo+IGJlZ2lubmluZz8NCldpdGggdGhlIHNhbWE1ZDIg VUxQMSBtb2RlLCBub3QgZnJvbSB0aGUgYmVnaW5uaW5nLg0KDQo+IA0KPiA+IFNpZ25lZC1vZmYt Ynk6IFdlbnlvdSBZYW5nIDx3ZW55b3UueWFuZ0BhdG1lbC5jb20+DQo+ID4gLS0tDQo+ID4NCj4g PiAgZHJpdmVycy9ydGMvcnRjLWF0OTFybTkyMDAuYyB8ICAgIDIgKysNCj4gPiAgMSBmaWxlIGNo YW5nZWQsIDIgaW5zZXJ0aW9ucygrKQ0KPiA+DQo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvcnRj L3J0Yy1hdDkxcm05MjAwLmMNCj4gPiBiL2RyaXZlcnMvcnRjL3J0Yy1hdDkxcm05MjAwLmMgaW5k ZXggY2I2MmUyMS4uYjYwZmQ0NyAxMDA2NDQNCj4gPiAtLS0gYS9kcml2ZXJzL3J0Yy9ydGMtYXQ5 MXJtOTIwMC5jDQo+ID4gKysrIGIvZHJpdmVycy9ydGMvcnRjLWF0OTFybTkyMDAuYw0KPiA+IEBA IC00OTUsNiArNDk1LDggQEAgc3RhdGljIGludCBhdDkxX3J0Y19zdXNwZW5kKHN0cnVjdCBkZXZp Y2UgKmRldikNCj4gPiAgCS8qIHRoaXMgSVJRIGlzIHNoYXJlZCB3aXRoIERCR1UgYW5kIG90aGVy IGhhcmR3YXJlIHdoaWNoIGlzbid0DQo+ID4gIAkgKiBuZWNlc3NhcmlseSBkb2luZyBQTSBsaWtl IHdlIGFyZS4uLg0KPiA+ICAJICovDQo+ID4gKwlhdDkxX3J0Y193cml0ZShBVDkxX1JUQ19TQ0NS LCBBVDkxX1JUQ19BTEFSTSk7DQo+ID4gKw0KPiA+ICAJYXQ5MV9ydGNfaW1yID0gYXQ5MV9ydGNf cmVhZF9pbXIoKQ0KPiA+ICAJCQkmIChBVDkxX1JUQ19BTEFSTXxBVDkxX1JUQ19TRUNFVik7DQo+ ID4gIAlpZiAoYXQ5MV9ydGNfaW1yKSB7DQo+ID4gLS0NCj4gPiAxLjcuOS41DQo+ID4NCj4gDQo+ IC0tDQo+IEFsZXhhbmRyZSBCZWxsb25pLCBGcmVlIEVsZWN0cm9ucw0KPiBFbWJlZGRlZCBMaW51 eCwgS2VybmVsIGFuZCBBbmRyb2lkIGVuZ2luZWVyaW5nDQo+IGh0dHA6Ly9mcmVlLWVsZWN0cm9u cy5jb20NCg0KQmVzdCBSZWdhcmRzLA0KV2VueW91IFlhbmcNCg== -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Alexandre Belloni <alexandre.belloni@free-electrons.com> |
|---|---|
| Date | 2015-10-12 10:00 +0200 |
| Subject | Re: [PATCH] rtc: at91rm9200: clear RTC alarm status flag prior to suspending |
| Message-ID | <qiGbx-Yi-7@gated-at.bofh.it> |
| In reply to | #1244447 |
On 12/10/2015 at 07:48:18 +0000, Yang, Wenyou wrote : > > On 12/10/2015 at 09:17:57 +0800, Wenyou Yang wrote : > > > This patch is to clear the RTC alarm status flag prior to suspending > > > to avoid the erroneous wake-up activity. > > > > > > > Is this a new issue appearing with the sama5d2 or was it present from the > > beginning? > With the sama5d2 ULP1 mode, not from the beginning. > I think this information should appear in the commit log. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | "Yang, Wenyou" <Wenyou.Yang@atmel.com> |
|---|---|
| Date | 2015-10-12 10:00 +0200 |
| Subject | RE: [PATCH] rtc: at91rm9200: clear RTC alarm status flag prior to suspending |
| Message-ID | <qiGbx-Yi-21@gated-at.bofh.it> |
| In reply to | #1244456 |
DQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogQWxleGFuZHJlIEJlbGxv bmkgW21haWx0bzphbGV4YW5kcmUuYmVsbG9uaUBmcmVlLWVsZWN0cm9ucy5jb21dDQo+IFNlbnQ6 IDIwMTXE6jEw1MIxMsjVIDE1OjUxDQo+IFRvOiBZYW5nLCBXZW55b3UNCj4gQ2M6IEFsZXNzYW5k cm8gWnVtbW87IEZlcnJlLCBOaWNvbGFzOyBEZXNyb2NoZXMsIEx1ZG92aWM7IHJ0Yy0NCj4gbGlu dXhAZ29vZ2xlZ3JvdXBzLmNvbTsgbGludXgta2VybmVsQHZnZXIua2VybmVsLm9yZzsgbGludXgt YXJtLQ0KPiBrZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZw0KPiBTdWJqZWN0OiBSZTogW1BBVENI XSBydGM6IGF0OTFybTkyMDA6IGNsZWFyIFJUQyBhbGFybSBzdGF0dXMgZmxhZyBwcmlvciB0bw0K PiBzdXNwZW5kaW5nDQo+IA0KPiBPbiAxMi8xMC8yMDE1IGF0IDA3OjQ4OjE4ICswMDAwLCBZYW5n LCBXZW55b3Ugd3JvdGUgOg0KPiA+ID4gT24gMTIvMTAvMjAxNSBhdCAwOToxNzo1NyArMDgwMCwg V2VueW91IFlhbmcgd3JvdGUgOg0KPiA+ID4gPiBUaGlzIHBhdGNoIGlzIHRvIGNsZWFyIHRoZSBS VEMgYWxhcm0gc3RhdHVzIGZsYWcgcHJpb3IgdG8NCj4gPiA+ID4gc3VzcGVuZGluZyB0byBhdm9p ZCB0aGUgZXJyb25lb3VzIHdha2UtdXAgYWN0aXZpdHkuDQo+ID4gPiA+DQo+ID4gPg0KPiA+ID4g SXMgdGhpcyBhIG5ldyBpc3N1ZSBhcHBlYXJpbmcgd2l0aCB0aGUgc2FtYTVkMiBvciB3YXMgaXQg cHJlc2VudA0KPiA+ID4gZnJvbSB0aGUgYmVnaW5uaW5nPw0KPiA+IFdpdGggdGhlIHNhbWE1ZDIg VUxQMSBtb2RlLCBub3QgZnJvbSB0aGUgYmVnaW5uaW5nLg0KPiA+DQo+IA0KPiBJIHRoaW5rIHRo aXMgaW5mb3JtYXRpb24gc2hvdWxkIGFwcGVhciBpbiB0aGUgY29tbWl0IGxvZy4NCkkgd2lsbCBh ZGQgaXQgaW4gdGhlIG5leHQgdmVyc2lvbiwgdGhhbmtzLg0KDQo+IA0KPiAtLQ0KPiBBbGV4YW5k cmUgQmVsbG9uaSwgRnJlZSBFbGVjdHJvbnMNCj4gRW1iZWRkZWQgTGludXgsIEtlcm5lbCBhbmQg QW5kcm9pZCBlbmdpbmVlcmluZyBodHRwOi8vZnJlZS1lbGVjdHJvbnMuY29tDQoNCkJlc3QgUmVn YXJkcywNCldlbnlvdSBZYW5nDQo= -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web