Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1243937 > unrolled thread
| Started by | Luis de Bethencourt <luisbg@osg.samsung.com> |
|---|---|
| First post | 2015-10-10 18:10 +0200 |
| Last post | 2015-10-16 10:30 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] mmc: android-goldfish: Allow compiling the driver with COMPILE_TEST Luis de Bethencourt <luisbg@osg.samsung.com> - 2015-10-10 18:10 +0200
Re: [PATCH] mmc: android-goldfish: Allow compiling the driver with COMPILE_TEST Jean Delvare <jdelvare@suse.de> - 2015-10-13 09:20 +0200
Re: [PATCH] mmc: android-goldfish: Allow compiling the driver with COMPILE_TEST Ulf Hansson <ulf.hansson@linaro.org> - 2015-10-16 10:30 +0200
| From | Luis de Bethencourt <luisbg@osg.samsung.com> |
|---|---|
| Date | 2015-10-10 18:10 +0200 |
| Subject | [PATCH] mmc: android-goldfish: Allow compiling the driver with COMPILE_TEST |
| Message-ID | <qi4SC-5Rh-13@gated-at.bofh.it> |
The driver depends on GOLDFISH but there isn't a build dependency so it's a good idea to allow the driver to always be built when the COMPILE_TEST option is enabled. That way, the driver can be built with a config generated by make allyesconfig and check if a patch would break the build. Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com> --- drivers/mmc/host/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig index 12b274a..56f5b14 100644 --- a/drivers/mmc/host/Kconfig +++ b/drivers/mmc/host/Kconfig @@ -473,7 +473,7 @@ config MMC_DAVINCI config MMC_GOLDFISH tristate "goldfish qemu Multimedia Card Interface support" - depends on GOLDFISH + depends on GOLDFISH || COMPILE_TEST help This selects the Goldfish Multimedia card Interface emulation found on the Goldfish Android virtual device emulation. -- 2.5.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Jean Delvare <jdelvare@suse.de> |
|---|---|
| Date | 2015-10-13 09:20 +0200 |
| Subject | Re: [PATCH] mmc: android-goldfish: Allow compiling the driver with COMPILE_TEST |
| Message-ID | <qj22l-7Ov-1@gated-at.bofh.it> |
| In reply to | #1243937 |
On Sat, 10 Oct 2015 17:08:32 +0100, Luis de Bethencourt wrote: > The driver depends on GOLDFISH but there isn't a build dependency > so it's a good idea to allow the driver to always be built when the > COMPILE_TEST option is enabled. > > That way, the driver can be built with a config generated by make > allyesconfig and check if a patch would break the build. > > Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com> > --- > drivers/mmc/host/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig > index 12b274a..56f5b14 100644 > --- a/drivers/mmc/host/Kconfig > +++ b/drivers/mmc/host/Kconfig > @@ -473,7 +473,7 @@ config MMC_DAVINCI > > config MMC_GOLDFISH > tristate "goldfish qemu Multimedia Card Interface support" > - depends on GOLDFISH > + depends on GOLDFISH || COMPILE_TEST > help > This selects the Goldfish Multimedia card Interface emulation > found on the Goldfish Android virtual device emulation. Looks good. Reviewed-by: Jean Delvare <jdelvare@suse.de> -- Jean Delvare SUSE L3 Support -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Ulf Hansson <ulf.hansson@linaro.org> |
|---|---|
| Date | 2015-10-16 10:30 +0200 |
| Message-ID | <qk8yK-FP-9@gated-at.bofh.it> |
| In reply to | #1243937 |
On 10 October 2015 at 18:08, Luis de Bethencourt <luisbg@osg.samsung.com> wrote: > The driver depends on GOLDFISH but there isn't a build dependency > so it's a good idea to allow the driver to always be built when the > COMPILE_TEST option is enabled. > > That way, the driver can be built with a config generated by make > allyesconfig and check if a patch would break the build. > > Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com> Thanks, applied for next! Kind regards Uffe > --- > drivers/mmc/host/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig > index 12b274a..56f5b14 100644 > --- a/drivers/mmc/host/Kconfig > +++ b/drivers/mmc/host/Kconfig > @@ -473,7 +473,7 @@ config MMC_DAVINCI > > config MMC_GOLDFISH > tristate "goldfish qemu Multimedia Card Interface support" > - depends on GOLDFISH > + depends on GOLDFISH || COMPILE_TEST > help > This selects the Goldfish Multimedia card Interface emulation > found on the Goldfish Android virtual device emulation. > -- > 2.5.1 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web