Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1242569 > unrolled thread
| Started by | Pavel Machek <pavel@ucw.cz> |
|---|---|
| First post | 2015-10-08 18:00 +0200 |
| Last post | 2015-10-09 13:20 +0200 |
| Articles | 5 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH 1/5] leds: core: Drivers shouldn't enforce SYNC/ASYNC brightness setting Pavel Machek <pavel@ucw.cz> - 2015-10-08 18:00 +0200
Re: [PATCH 1/5] leds: core: Drivers shouldn't enforce SYNC/ASYNC brightness setting Jacek Anaszewski <j.anaszewski@samsung.com> - 2015-10-09 08:30 +0200
Re: [PATCH 1/5] leds: core: Drivers shouldn't enforce SYNC/ASYNC brightness setting Pavel Machek <pavel@ucw.cz> - 2015-10-09 09:10 +0200
Re: [PATCH 1/5] leds: core: Drivers shouldn't enforce SYNC/ASYNC brightness setting Jacek Anaszewski <j.anaszewski@samsung.com> - 2015-10-09 10:10 +0200
Re: [PATCH 1/5] leds: core: Drivers shouldn't enforce SYNC/ASYNC brightness setting Pavel Machek <pavel@ucw.cz> - 2015-10-09 13:20 +0200
| From | Pavel Machek <pavel@ucw.cz> |
|---|---|
| Date | 2015-10-08 18:00 +0200 |
| Subject | Re: [PATCH 1/5] leds: core: Drivers shouldn't enforce SYNC/ASYNC brightness setting |
| Message-ID | <qhlLQ-81t-27@gated-at.bofh.it> |
On Mon 2015-09-21 16:29:26, Jacek Anaszewski wrote: > This patch removes SET_BRIGHTNESS_ASYNC and SET_BRIGHTNESS flags. > led_set_brightness now calls led_set_brightness_nosleep instead of > choosing between sync and async op basing on the flags defined by the > driver. Are those flags unused in the version of kernel you are patching? If so, tell us so in the changelog. Thanks, Pavel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Jacek Anaszewski <j.anaszewski@samsung.com> |
|---|---|
| Date | 2015-10-09 08:30 +0200 |
| Message-ID | <qhzlM-2nJ-19@gated-at.bofh.it> |
| In reply to | #1242569 |
On 10/08/2015 05:50 PM, Pavel Machek wrote: > On Mon 2015-09-21 16:29:26, Jacek Anaszewski wrote: >> This patch removes SET_BRIGHTNESS_ASYNC and SET_BRIGHTNESS flags. s/SET_BRIGHTNESS/SET_BRIGHTNESS_SYNC/ >> led_set_brightness now calls led_set_brightness_nosleep instead of >> choosing between sync and async op basing on the flags defined by the >> driver. > > Are those flags unused in the version of kernel you are patching? The flags are used until this patch. > If so, tell us so in the changelog. Thanks, -- Best Regards, Jacek Anaszewski -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Pavel Machek <pavel@ucw.cz> |
|---|---|
| Date | 2015-10-09 09:10 +0200 |
| Message-ID | <qhzYv-3mM-19@gated-at.bofh.it> |
| In reply to | #1243052 |
On Fri 2015-10-09 08:28:44, Jacek Anaszewski wrote: > On 10/08/2015 05:50 PM, Pavel Machek wrote: > >On Mon 2015-09-21 16:29:26, Jacek Anaszewski wrote: > >>This patch removes SET_BRIGHTNESS_ASYNC and SET_BRIGHTNESS flags. > > s/SET_BRIGHTNESS/SET_BRIGHTNESS_SYNC/ > > >>led_set_brightness now calls led_set_brightness_nosleep instead of > >>choosing between sync and async op basing on the flags defined by the > >>driver. > > > >Are those flags unused in the version of kernel you are patching? > > The flags are used until this patch. Hmm. I seen you removing the definitions, but not removing any users. I guess I missed something. Best regards, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Jacek Anaszewski <j.anaszewski@samsung.com> |
|---|---|
| Date | 2015-10-09 10:10 +0200 |
| Message-ID | <qhAUy-4Iv-21@gated-at.bofh.it> |
| In reply to | #1243076 |
On 10/09/2015 09:02 AM, Pavel Machek wrote: > On Fri 2015-10-09 08:28:44, Jacek Anaszewski wrote: >> On 10/08/2015 05:50 PM, Pavel Machek wrote: >>> On Mon 2015-09-21 16:29:26, Jacek Anaszewski wrote: >>>> This patch removes SET_BRIGHTNESS_ASYNC and SET_BRIGHTNESS flags. >> >> s/SET_BRIGHTNESS/SET_BRIGHTNESS_SYNC/ >> >>>> led_set_brightness now calls led_set_brightness_nosleep instead of >>>> choosing between sync and async op basing on the flags defined by the >>>> driver. >>> >>> Are those flags unused in the version of kernel you are patching? >> >> The flags are used until this patch. > > Hmm. I seen you removing the definitions, but not removing any > users. I guess I missed something. Only LED core is the user. It sets SET_BRIGHTNESS_SYNC flag for LED flash class drivers. -- Best Regards, Jacek Anaszewski -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Pavel Machek <pavel@ucw.cz> |
|---|---|
| Date | 2015-10-09 13:20 +0200 |
| Message-ID | <qhDSq-tO-13@gated-at.bofh.it> |
| In reply to | #1243104 |
On Fri 2015-10-09 10:08:12, Jacek Anaszewski wrote: > On 10/09/2015 09:02 AM, Pavel Machek wrote: > >On Fri 2015-10-09 08:28:44, Jacek Anaszewski wrote: > >>On 10/08/2015 05:50 PM, Pavel Machek wrote: > >>>On Mon 2015-09-21 16:29:26, Jacek Anaszewski wrote: > >>>>This patch removes SET_BRIGHTNESS_ASYNC and SET_BRIGHTNESS flags. > >> > >>s/SET_BRIGHTNESS/SET_BRIGHTNESS_SYNC/ > >> > >>>>led_set_brightness now calls led_set_brightness_nosleep instead of > >>>>choosing between sync and async op basing on the flags defined by the > >>>>driver. > >>> > >>>Are those flags unused in the version of kernel you are patching? > >> > >>The flags are used until this patch. > > > >Hmm. I seen you removing the definitions, but not removing any > >users. I guess I missed something. > > Only LED core is the user. It sets SET_BRIGHTNESS_SYNC flag > for LED flash class drivers. Aha. All is right, then. -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web