Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1242563 > unrolled thread

Re: [PATCH v2 01/12] leds: core: Use EXPORT_SYMBOL_GPL consistently

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v2 01/12] leds: core: Use EXPORT_SYMBOL_GPL consistently Pavel Machek <pavel@ucw.cz> - 2015-10-08 18:00 +0200
    Re: [PATCH v2 01/12] leds: core: Use EXPORT_SYMBOL_GPL consistently Jacek Anaszewski <j.anaszewski@samsung.com> - 2015-10-09 10:30 +0200
      Re: [PATCH v2 01/12] leds: core: Use EXPORT_SYMBOL_GPL consistently Pavel Machek <pavel@ucw.cz> - 2015-10-09 13:20 +0200

#1242563 — Re: [PATCH v2 01/12] leds: core: Use EXPORT_SYMBOL_GPL consistently

On Mon 2015-09-28 17:13:39, Jacek Anaszewski wrote:
> This patch isn't going to be applied since it can cause
> legal implications for existing users.
>

Are there any? Best do this ASAP :-).
							Pavel
 
> On 09/28/2015 03:07 PM, Jacek Anaszewski wrote:
> >LED core has a mixture of EXPORT_SYMBOL and EXPORT_SYMBOL_GPL macros.
> >This patch fixes this discrepancy and switches to using EXPORT_SYMBOL_GPL
> >for each exported function.
> >
> >Signed-off-by: Jacek Anaszewski <j.anaszewski@samsung.com>
> >---
> >  drivers/leds/led-core.c |    8 ++++----
> >  1 file changed, 4 insertions(+), 4 deletions(-)
> >
> >diff --git a/drivers/leds/led-core.c b/drivers/leds/led-core.c
> >index 549de7e..c1dd545 100644
> >--- a/drivers/leds/led-core.c
> >+++ b/drivers/leds/led-core.c
> >@@ -83,7 +83,7 @@ void led_blink_set(struct led_classdev *led_cdev,
> >
> >  	led_blink_setup(led_cdev, delay_on, delay_off);
> >  }
> >-EXPORT_SYMBOL(led_blink_set);
> >+EXPORT_SYMBOL_GPL(led_blink_set);
> >
> >  void led_blink_set_oneshot(struct led_classdev *led_cdev,
> >  			   unsigned long *delay_on,
> >@@ -104,7 +104,7 @@ void led_blink_set_oneshot(struct led_classdev *led_cdev,
> >
> >  	led_blink_setup(led_cdev, delay_on, delay_off);
> >  }
> >-EXPORT_SYMBOL(led_blink_set_oneshot);
> >+EXPORT_SYMBOL_GPL(led_blink_set_oneshot);
> >
> >  void led_stop_software_blink(struct led_classdev *led_cdev)
> >  {
> >@@ -139,7 +139,7 @@ void led_set_brightness(struct led_classdev *led_cdev,
> >  		dev_dbg(led_cdev->dev, "Setting LED brightness failed (%d)\n",
> >  			ret);
> >  }
> >-EXPORT_SYMBOL(led_set_brightness);
> >+EXPORT_SYMBOL_GPL(led_set_brightness);
> >
> >  int led_update_brightness(struct led_classdev *led_cdev)
> >  {
> >@@ -155,7 +155,7 @@ int led_update_brightness(struct led_classdev *led_cdev)
> >
> >  	return ret;
> >  }
> >-EXPORT_SYMBOL(led_update_brightness);
> >+EXPORT_SYMBOL_GPL(led_update_brightness);
> >
> >  /* Caller must ensure led_cdev->led_access held */
> >  void led_sysfs_disable(struct led_classdev *led_cdev)
> >
> 
> 
> -- 
> Best Regards,
> Jacek Anaszewski
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1243117

On 10/08/2015 05:51 PM, Pavel Machek wrote:
> On Mon 2015-09-28 17:13:39, Jacek Anaszewski wrote:
>> This patch isn't going to be applied since it can cause
>> legal implications for existing users.
>>
>
> Are there any? Best do this ASAP :-).

Current non-GPL users of led_set_brightness would be affected if we
changed this. I am not however certain if there are any, having in mind
that led_classdev_register is exported with EXPORT_SYMBOL_GPL.
Theoretically it is possible to use led_set_brightness without
registering LED class device, but it would be partially broken then
due to not initialized set_brightness_work.
I think that it would be safe to apply this patch.
I need acks, though :)

-- 
Best Regards,
Jacek Anaszewski
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1243255

On Fri 2015-10-09 10:19:48, Jacek Anaszewski wrote:
> On 10/08/2015 05:51 PM, Pavel Machek wrote:
> >On Mon 2015-09-28 17:13:39, Jacek Anaszewski wrote:
> >>This patch isn't going to be applied since it can cause
> >>legal implications for existing users.
> >>
> >
> >Are there any? Best do this ASAP :-).
> 
> Current non-GPL users of led_set_brightness would be affected if we
> changed this. I am not however certain if there are any, having in
> mind

Actually, _GPL or not is just an annotation, it has little legal
power.

> that led_classdev_register is exported with EXPORT_SYMBOL_GPL.
> Theoretically it is possible to use led_set_brightness without
> registering LED class device, but it would be partially broken then
> due to not initialized set_brightness_work.
> I think that it would be safe to apply this patch.
> I need acks, though :)

Acked-by: Pavel Machek <pavel@ucw.cz>
								Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web