Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1241153 > unrolled thread

linux-next: build warning after merge of the driver-core tree

Started byStephen Rothwell <sfr@canb.auug.org.au>
First post2015-10-07 07:00 +0200
Last post2015-10-09 08:40 +0200
Articles 11 — 3 participants

Back to article view | Back to linux.kernel


Contents

  linux-next: build warning after merge of the driver-core tree Stephen Rothwell <sfr@canb.auug.org.au> - 2015-10-07 07:00 +0200
    Re: linux-next: build warning after merge of the driver-core tree Viresh Kumar <viresh.kumar@linaro.org> - 2015-10-07 08:50 +0200
      Re: linux-next: build warning after merge of the driver-core tree "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2015-10-07 23:30 +0200
        Re: linux-next: build warning after merge of the driver-core tree Stephen Rothwell <sfr@canb.auug.org.au> - 2015-10-08 00:10 +0200
          Re: linux-next: build warning after merge of the driver-core tree "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2015-10-08 00:20 +0200
            Re: linux-next: build warning after merge of the driver-core tree Viresh Kumar <viresh.kumar@linaro.org> - 2015-10-08 09:20 +0200
              Re: linux-next: build warning after merge of the driver-core tree "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2015-10-08 22:10 +0200
                Re: linux-next: build warning after merge of the driver-core tree Stephen Rothwell <sfr@canb.auug.org.au> - 2015-10-09 07:40 +0200
                  Re: linux-next: build warning after merge of the driver-core tree Viresh Kumar <viresh.kumar@linaro.org> - 2015-10-09 08:40 +0200
                    Re: linux-next: build warning after merge of the driver-core tree "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2015-10-09 22:30 +0200
                Re: linux-next: build warning after merge of the driver-core tree Viresh Kumar <viresh.kumar@linaro.org> - 2015-10-09 08:40 +0200

#1241153 — linux-next: build warning after merge of the driver-core tree

FromStephen Rothwell <sfr@canb.auug.org.au>
Date2015-10-07 07:00 +0200
Subjectlinux-next: build warning after merge of the driver-core tree
Message-ID<qgOZz-2Wm-1@gated-at.bofh.it>
Hi Greg,

After merging the driver-core tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

drivers/base/power/opp/debugfs.c: In function 'opp_debug_create_one':
drivers/base/power/opp/debugfs.c:48:7: warning: passing argument 4 of 'debugfs_create_bool' from incompatible pointer type
  if (!debugfs_create_bool("available", S_IRUGO, d,
       ^
In file included from drivers/base/power/opp/debugfs.c:13:0:
include/linux/debugfs.h:94:16: note: expected 'bool *' but argument is of type 'u32 *'
 struct dentry *debugfs_create_bool(const char *name, umode_t mode,
                ^
drivers/base/power/opp/debugfs.c:52:7: warning: passing argument 4 of 'debugfs_create_bool' from incompatible pointer type
  if (!debugfs_create_bool("dynamic", S_IRUGO, d, (u32 *)&opp->dynamic))
       ^
In file included from drivers/base/power/opp/debugfs.c:13:0:
include/linux/debugfs.h:94:16: note: expected 'bool *' but argument is of type 'u32 *'
 struct dentry *debugfs_create_bool(const char *name, umode_t mode,
                ^
drivers/base/power/opp/debugfs.c:55:7: warning: passing argument 4 of 'debugfs_create_bool' from incompatible pointer type
  if (!debugfs_create_bool("turbo", S_IRUGO, d, (u32 *)&opp->turbo))
       ^
In file included from drivers/base/power/opp/debugfs.c:13:0:
include/linux/debugfs.h:94:16: note: expected 'bool *' but argument is of type 'u32 *'
 struct dentry *debugfs_create_bool(const char *name, umode_t mode,
                ^

Introduced by commit

  621a5f7ad9cd ("debugfs: Pass bool pointer to debugfs_create_bool()")

interacting with commit

  5cb5fdbf3877 ("PM / OPP: Add debugfs support")

from the pm tree.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]


#1241168

FromViresh Kumar <viresh.kumar@linaro.org>
Date2015-10-07 08:50 +0200
Message-ID<qgQI2-5qS-3@gated-at.bofh.it>
In reply to#1241153
Hi Stephen,

On 7 October 2015 at 06:51, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi Greg,
>
> After merging the driver-core tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
>
> drivers/base/power/opp/debugfs.c: In function 'opp_debug_create_one':
> drivers/base/power/opp/debugfs.c:48:7: warning: passing argument 4 of 'debugfs_create_bool' from incompatible pointer type
>   if (!debugfs_create_bool("available", S_IRUGO, d,
>        ^
> In file included from drivers/base/power/opp/debugfs.c:13:0:
> include/linux/debugfs.h:94:16: note: expected 'bool *' but argument is of type 'u32 *'
>  struct dentry *debugfs_create_bool(const char *name, umode_t mode,
>                 ^
> drivers/base/power/opp/debugfs.c:52:7: warning: passing argument 4 of 'debugfs_create_bool' from incompatible pointer type
>   if (!debugfs_create_bool("dynamic", S_IRUGO, d, (u32 *)&opp->dynamic))
>        ^
> In file included from drivers/base/power/opp/debugfs.c:13:0:
> include/linux/debugfs.h:94:16: note: expected 'bool *' but argument is of type 'u32 *'
>  struct dentry *debugfs_create_bool(const char *name, umode_t mode,
>                 ^
> drivers/base/power/opp/debugfs.c:55:7: warning: passing argument 4 of 'debugfs_create_bool' from incompatible pointer type
>   if (!debugfs_create_bool("turbo", S_IRUGO, d, (u32 *)&opp->turbo))
>        ^
> In file included from drivers/base/power/opp/debugfs.c:13:0:
> include/linux/debugfs.h:94:16: note: expected 'bool *' but argument is of type 'u32 *'
>  struct dentry *debugfs_create_bool(const char *name, umode_t mode,
>                 ^
>
> Introduced by commit
>
>   621a5f7ad9cd ("debugfs: Pass bool pointer to debugfs_create_bool()")
>
> interacting with commit
>
>   5cb5fdbf3877 ("PM / OPP: Add debugfs support")
>
> from the pm tree.

That was expected and the PM tree needs to get updated to get it fixed.
And I will be doing that soon.

--
viresh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]


#1241808

From"Rafael J. Wysocki" <rjw@rjwysocki.net>
Date2015-10-07 23:30 +0200
Message-ID<qh4rD-8v1-5@gated-at.bofh.it>
In reply to#1241168
On Wednesday, October 07, 2015 08:40:59 AM Viresh Kumar wrote:
> Hi Stephen,
> 
> On 7 October 2015 at 06:51, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > Hi Greg,
> >
> > After merging the driver-core tree, today's linux-next build (arm
> > multi_v7_defconfig) produced this warning:
> >
> > drivers/base/power/opp/debugfs.c: In function 'opp_debug_create_one':
> > drivers/base/power/opp/debugfs.c:48:7: warning: passing argument 4 of 'debugfs_create_bool' from incompatible pointer type
> >   if (!debugfs_create_bool("available", S_IRUGO, d,
> >        ^
> > In file included from drivers/base/power/opp/debugfs.c:13:0:
> > include/linux/debugfs.h:94:16: note: expected 'bool *' but argument is of type 'u32 *'
> >  struct dentry *debugfs_create_bool(const char *name, umode_t mode,
> >                 ^
> > drivers/base/power/opp/debugfs.c:52:7: warning: passing argument 4 of 'debugfs_create_bool' from incompatible pointer type
> >   if (!debugfs_create_bool("dynamic", S_IRUGO, d, (u32 *)&opp->dynamic))
> >        ^
> > In file included from drivers/base/power/opp/debugfs.c:13:0:
> > include/linux/debugfs.h:94:16: note: expected 'bool *' but argument is of type 'u32 *'
> >  struct dentry *debugfs_create_bool(const char *name, umode_t mode,
> >                 ^
> > drivers/base/power/opp/debugfs.c:55:7: warning: passing argument 4 of 'debugfs_create_bool' from incompatible pointer type
> >   if (!debugfs_create_bool("turbo", S_IRUGO, d, (u32 *)&opp->turbo))
> >        ^
> > In file included from drivers/base/power/opp/debugfs.c:13:0:
> > include/linux/debugfs.h:94:16: note: expected 'bool *' but argument is of type 'u32 *'
> >  struct dentry *debugfs_create_bool(const char *name, umode_t mode,
> >                 ^
> >
> > Introduced by commit
> >
> >   621a5f7ad9cd ("debugfs: Pass bool pointer to debugfs_create_bool()")
> >
> > interacting with commit
> >
> >   5cb5fdbf3877 ("PM / OPP: Add debugfs support")
> >
> > from the pm tree.
> 
> That was expected and the PM tree needs to get updated to get it fixed.
> And I will be doing that soon.

For the record, I'm tired of your breaking things on a regular basis like this.

I'm dropping 5cb5fdbf3877 from the PM tree.

Thanks,
Rafael

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]


#1241820

FromStephen Rothwell <sfr@canb.auug.org.au>
Date2015-10-08 00:10 +0200
Message-ID<qh54l-11T-1@gated-at.bofh.it>
In reply to#1241808
Hi Rafael,

On Wed, 07 Oct 2015 23:48:11 +0200 "Rafael J. Wysocki" <rjw@rjwysocki.net> wrote:
>
> On Wednesday, October 07, 2015 08:40:59 AM Viresh Kumar wrote:
> > 
> > On 7 October 2015 at 06:51, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > >
> > > After merging the driver-core tree, today's linux-next build (arm
> > > multi_v7_defconfig) produced this warning:
> > >
> > > drivers/base/power/opp/debugfs.c: In function 'opp_debug_create_one':
> > > drivers/base/power/opp/debugfs.c:48:7: warning: passing argument 4 of 'debugfs_create_bool' from incompatible pointer type
> > >   if (!debugfs_create_bool("available", S_IRUGO, d,
> > >        ^
> > > In file included from drivers/base/power/opp/debugfs.c:13:0:
> > > include/linux/debugfs.h:94:16: note: expected 'bool *' but argument is of type 'u32 *'
> > >  struct dentry *debugfs_create_bool(const char *name, umode_t mode,
> > >                 ^
> > > drivers/base/power/opp/debugfs.c:52:7: warning: passing argument 4 of 'debugfs_create_bool' from incompatible pointer type
> > >   if (!debugfs_create_bool("dynamic", S_IRUGO, d, (u32 *)&opp->dynamic))
> > >        ^
> > > In file included from drivers/base/power/opp/debugfs.c:13:0:
> > > include/linux/debugfs.h:94:16: note: expected 'bool *' but argument is of type 'u32 *'
> > >  struct dentry *debugfs_create_bool(const char *name, umode_t mode,
> > >                 ^
> > > drivers/base/power/opp/debugfs.c:55:7: warning: passing argument 4 of 'debugfs_create_bool' from incompatible pointer type
> > >   if (!debugfs_create_bool("turbo", S_IRUGO, d, (u32 *)&opp->turbo))
> > >        ^
> > > In file included from drivers/base/power/opp/debugfs.c:13:0:
> > > include/linux/debugfs.h:94:16: note: expected 'bool *' but argument is of type 'u32 *'
> > >  struct dentry *debugfs_create_bool(const char *name, umode_t mode,
> > >                 ^
> > >
> > > Introduced by commit
> > >
> > >   621a5f7ad9cd ("debugfs: Pass bool pointer to debugfs_create_bool()")
> > >
> > > interacting with commit
> > >
> > >   5cb5fdbf3877 ("PM / OPP: Add debugfs support")
> > >
> > > from the pm tree.
> > 
> > That was expected and the PM tree needs to get updated to get it fixed.
> > And I will be doing that soon.
> 
> For the record, I'm tired of your breaking things on a regular basis like this.
> 
> I'm dropping 5cb5fdbf3877 from the PM tree.

To be fair, this is caused by in interaction between your tree and
Greg's ... i.e. the API for debugfs_create_bool() was updated in Greg's
tree while a new use of it was added to your tree.  It can only be
fixed by one of you merging the other's tree (or part of it) or by
someone giving me a merge resolution patch (or just a hint) and me
carrying that (and someone remembering to tell Linus about it.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]


#1241824

From"Rafael J. Wysocki" <rjw@rjwysocki.net>
Date2015-10-08 00:20 +0200
Message-ID<qh5e1-1dh-3@gated-at.bofh.it>
In reply to#1241820
On Thursday, October 08, 2015 09:04:27 AM Stephen Rothwell wrote:
> Hi Rafael,
> 
> On Wed, 07 Oct 2015 23:48:11 +0200 "Rafael J. Wysocki" <rjw@rjwysocki.net> wrote:
> >
> > On Wednesday, October 07, 2015 08:40:59 AM Viresh Kumar wrote:
> > > 
> > > On 7 October 2015 at 06:51, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > > >
> > > > After merging the driver-core tree, today's linux-next build (arm
> > > > multi_v7_defconfig) produced this warning:
> > > >
> > > > drivers/base/power/opp/debugfs.c: In function 'opp_debug_create_one':
> > > > drivers/base/power/opp/debugfs.c:48:7: warning: passing argument 4 of 'debugfs_create_bool' from incompatible pointer type
> > > >   if (!debugfs_create_bool("available", S_IRUGO, d,
> > > >        ^
> > > > In file included from drivers/base/power/opp/debugfs.c:13:0:
> > > > include/linux/debugfs.h:94:16: note: expected 'bool *' but argument is of type 'u32 *'
> > > >  struct dentry *debugfs_create_bool(const char *name, umode_t mode,
> > > >                 ^
> > > > drivers/base/power/opp/debugfs.c:52:7: warning: passing argument 4 of 'debugfs_create_bool' from incompatible pointer type
> > > >   if (!debugfs_create_bool("dynamic", S_IRUGO, d, (u32 *)&opp->dynamic))
> > > >        ^
> > > > In file included from drivers/base/power/opp/debugfs.c:13:0:
> > > > include/linux/debugfs.h:94:16: note: expected 'bool *' but argument is of type 'u32 *'
> > > >  struct dentry *debugfs_create_bool(const char *name, umode_t mode,
> > > >                 ^
> > > > drivers/base/power/opp/debugfs.c:55:7: warning: passing argument 4 of 'debugfs_create_bool' from incompatible pointer type
> > > >   if (!debugfs_create_bool("turbo", S_IRUGO, d, (u32 *)&opp->turbo))
> > > >        ^
> > > > In file included from drivers/base/power/opp/debugfs.c:13:0:
> > > > include/linux/debugfs.h:94:16: note: expected 'bool *' but argument is of type 'u32 *'
> > > >  struct dentry *debugfs_create_bool(const char *name, umode_t mode,
> > > >                 ^
> > > >
> > > > Introduced by commit
> > > >
> > > >   621a5f7ad9cd ("debugfs: Pass bool pointer to debugfs_create_bool()")
> > > >
> > > > interacting with commit
> > > >
> > > >   5cb5fdbf3877 ("PM / OPP: Add debugfs support")
> > > >
> > > > from the pm tree.
> > > 
> > > That was expected and the PM tree needs to get updated to get it fixed.
> > > And I will be doing that soon.
> > 
> > For the record, I'm tired of your breaking things on a regular basis like this.
> > 
> > I'm dropping 5cb5fdbf3877 from the PM tree.
> 
> To be fair, this is caused by in interaction between your tree and
> Greg's ... i.e. the API for debugfs_create_bool() was updated in Greg's
> tree while a new use of it was added to your tree.  It can only be
> fixed by one of you merging the other's tree (or part of it) or by
> someone giving me a merge resolution patch (or just a hint) and me
> carrying that (and someone remembering to tell Linus about it.

Well, the conflicting commits here were from the same developer which is kind
of annoying.

The new use in my tree can wait until the API update in the Greg's tree is
merged IMO.  That's why I've now dropped the commit that added it. :-)

Thanks,
Rafael

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]


#1242014

FromViresh Kumar <viresh.kumar@linaro.org>
Date2015-10-08 09:20 +0200
Message-ID<qhdED-4U3-23@gated-at.bofh.it>
In reply to#1241824
On 08-10-15, 00:47, Rafael J. Wysocki wrote:
> Well, the conflicting commits here were from the same developer which is kind
> of annoying.

I do understand why its annoying, but I wasn't doing them in parallel.
The patches in Greg's tree were written long after the other series
got applied to your tree.

So, I was kind of helpless here :(

> The new use in my tree can wait until the API update in the Greg's tree is
> merged IMO.  That's why I've now dropped the commit that added it. :-)

Looking at the current state of your tree, looks like you have dropped
way too many patches. Was it intentional?

Missing commits:

1840995c52d4 PM / OPP: reuse of_parse_phandle()
f0489a5ef4d0 PM / OPP: Rename opp init/free table routines
8f8d37b2537a PM / OPP: Prefix exported opp routines with dev_pm_opp_
33692dc381f9 PM / OPP: Move opp core to its own directory
f59d3ee8480d PM / OPP: Move cpu specific code to opp/cpu.c
5cb5fdbf3877 PM / OPP: Add debugfs support

I though you just dropped the last commit, but no.

-- 
viresh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]


#1242711

From"Rafael J. Wysocki" <rjw@rjwysocki.net>
Date2015-10-08 22:10 +0200
Message-ID<qhpFM-5mR-9@gated-at.bofh.it>
In reply to#1242014
On Thursday, October 08, 2015 12:39:54 PM Viresh Kumar wrote:
> On 08-10-15, 00:47, Rafael J. Wysocki wrote:
> > Well, the conflicting commits here were from the same developer which is kind
> > of annoying.
> 
> I do understand why its annoying, but I wasn't doing them in parallel.
> The patches in Greg's tree were written long after the other series
> got applied to your tree.
> 
> So, I was kind of helpless here :(

You could have asked me to drop that commit when you decided to rework the API.

That would have been much less painful to everybody (and especially to the
people who saw the breakage and have tried to fix it).

> > The new use in my tree can wait until the API update in the Greg's tree is
> > merged IMO.  That's why I've now dropped the commit that added it. :-)
> 
> Looking at the current state of your tree, looks like you have dropped
> way too many patches. Was it intentional?
> 
> Missing commits:
> 
> 1840995c52d4 PM / OPP: reuse of_parse_phandle()
> f0489a5ef4d0 PM / OPP: Rename opp init/free table routines
> 8f8d37b2537a PM / OPP: Prefix exported opp routines with dev_pm_opp_
> 33692dc381f9 PM / OPP: Move opp core to its own directory
> f59d3ee8480d PM / OPP: Move cpu specific code to opp/cpu.c
> 5cb5fdbf3877 PM / OPP: Add debugfs support
> 
> I though you just dropped the last commit, but no.

My bad, I rebased the pm-opp branch, but then have forgotten to merge it.

Sorry about that, should be fixed now.

Thanks,
Rafael

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]


#1243042

FromStephen Rothwell <sfr@canb.auug.org.au>
Date2015-10-09 07:40 +0200
Message-ID<qhyzo-1e0-9@gated-at.bofh.it>
In reply to#1242711
Hi Rafael,

On Thu, 08 Oct 2015 22:30:45 +0200 "Rafael J. Wysocki" <rjw@rjwysocki.net> wrote:
>
> On Thursday, October 08, 2015 12:39:54 PM Viresh Kumar wrote:
> > 1840995c52d4 PM / OPP: reuse of_parse_phandle()
> > f0489a5ef4d0 PM / OPP: Rename opp init/free table routines
> > 8f8d37b2537a PM / OPP: Prefix exported opp routines with dev_pm_opp_
> > 33692dc381f9 PM / OPP: Move opp core to its own directory
> > f59d3ee8480d PM / OPP: Move cpu specific code to opp/cpu.c
> > 5cb5fdbf3877 PM / OPP: Add debugfs support
> > 
> > I though you just dropped the last commit, but no.
> 
> My bad, I rebased the pm-opp branch, but then have forgotten to merge it.
> 
> Sorry about that, should be fixed now.

And the warnings are back :-)

Can someone (Viresh) just send me a patch on top of today's linux-next
(when I release it) and I will us it as a merge fix patch from Monday
and then hopefully it will be passed on to Linus at the right time.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]


#1243053

FromViresh Kumar <viresh.kumar@linaro.org>
Date2015-10-09 08:40 +0200
Message-ID<qhzvr-2yW-5@gated-at.bofh.it>
In reply to#1243042
On 09-10-15, 16:36, Stephen Rothwell wrote:
> Hi Rafael,
> 
> On Thu, 08 Oct 2015 22:30:45 +0200 "Rafael J. Wysocki" <rjw@rjwysocki.net> wrote:
> >
> > On Thursday, October 08, 2015 12:39:54 PM Viresh Kumar wrote:
> > > 1840995c52d4 PM / OPP: reuse of_parse_phandle()
> > > f0489a5ef4d0 PM / OPP: Rename opp init/free table routines
> > > 8f8d37b2537a PM / OPP: Prefix exported opp routines with dev_pm_opp_
> > > 33692dc381f9 PM / OPP: Move opp core to its own directory
> > > f59d3ee8480d PM / OPP: Move cpu specific code to opp/cpu.c
> > > 5cb5fdbf3877 PM / OPP: Add debugfs support
> > > 
> > > I though you just dropped the last commit, but no.
> > 
> > My bad, I rebased the pm-opp branch, but then have forgotten to merge it.
> > 
> > Sorry about that, should be fixed now.
> 
> And the warnings are back :-)

Rafael did it incorrectly once again :)

He picked the faulty patch once again, which he should have dropped.

> Can someone (Viresh) just send me a patch on top of today's linux-next
> (when I release it) and I will us it as a merge fix patch from Monday
> and then hopefully it will be passed on to Linus at the right time.

Because that's what Rafael is going to do once he is back, can can
just revert

5cb5fdbf3877 PM / OPP: Add debugfs support

for the time being. Will that be fine?

-- 
viresh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]


#1243634

From"Rafael J. Wysocki" <rjw@rjwysocki.net>
Date2015-10-09 22:30 +0200
Message-ID<qhMsF-4ne-3@gated-at.bofh.it>
In reply to#1243053
On Friday, October 09, 2015 12:01:55 PM Viresh Kumar wrote:
> On 09-10-15, 16:36, Stephen Rothwell wrote:
> > Hi Rafael,
> > 
> > On Thu, 08 Oct 2015 22:30:45 +0200 "Rafael J. Wysocki" <rjw@rjwysocki.net> wrote:
> > >
> > > On Thursday, October 08, 2015 12:39:54 PM Viresh Kumar wrote:
> > > > 1840995c52d4 PM / OPP: reuse of_parse_phandle()
> > > > f0489a5ef4d0 PM / OPP: Rename opp init/free table routines
> > > > 8f8d37b2537a PM / OPP: Prefix exported opp routines with dev_pm_opp_
> > > > 33692dc381f9 PM / OPP: Move opp core to its own directory
> > > > f59d3ee8480d PM / OPP: Move cpu specific code to opp/cpu.c
> > > > 5cb5fdbf3877 PM / OPP: Add debugfs support
> > > > 
> > > > I though you just dropped the last commit, but no.
> > > 
> > > My bad, I rebased the pm-opp branch, but then have forgotten to merge it.
> > > 
> > > Sorry about that, should be fixed now.
> > 
> > And the warnings are back :-)
> 
> Rafael did it incorrectly once again :)
> 
> He picked the faulty patch once again, which he should have dropped.

Right, sorry about that.

It should be gone now for real.

Thanks,
Rafael

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]


#1243054

FromViresh Kumar <viresh.kumar@linaro.org>
Date2015-10-09 08:40 +0200
Message-ID<qhzvr-2yW-7@gated-at.bofh.it>
In reply to#1242711
On 08-10-15, 22:30, Rafael J. Wysocki wrote:
> You could have asked me to drop that commit when you decided to rework the API.
> 
> That would have been much less painful to everybody (and especially to the
> people who saw the breakage and have tried to fix it).

My apologies, I could have done more. And then the timing wasn't
great, as I went on a 10 day holiday right after Linaro conference.

-- 
viresh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web