Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1240576 > unrolled thread
| Started by | Marc Gonzalez <marc_gonzalez@sigmadesigns.com> |
|---|---|
| First post | 2015-10-06 17:40 +0200 |
| Last post | 2015-10-09 18:40 +0200 |
| Articles | 4 on this page of 24 — 5 participants |
Back to article view | Back to linux.kernel
[PATCH v1] clocksource: Sigma Designs Tango 27 MHz xtal Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2015-10-06 17:40 +0200
Re: [PATCH v1] clocksource: Sigma Designs Tango 27 MHz xtal Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-10-07 01:10 +0200
Re: [PATCH v1] clocksource: Sigma Designs Tango 27 MHz xtal Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2015-10-07 10:30 +0200
Re: [PATCH v1] clocksource: Sigma Designs Tango 27 MHz xtal Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-10-07 11:50 +0200
Re: [PATCH v1] clocksource: Sigma Designs Tango 27 MHz xtal Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2015-10-07 13:20 +0200
Re: [PATCH v1] clocksource: Sigma Designs Tango 27 MHz xtal Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-10-07 13:40 +0200
[PATCH v2] clocksource/drivers/tango_xtal: Add new timer for Tango SoCs Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2015-10-07 13:40 +0200
Re: [PATCH v2] clocksource/drivers/tango_xtal: Add new timer for Tango SoCs Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-10-07 14:40 +0200
Re: [PATCH v2] clocksource/drivers/tango_xtal: Add new timer for Tango SoCs Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2015-10-07 15:20 +0200
Re: [PATCH v2] clocksource/drivers/tango_xtal: Add new timer for Tango SoCs Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-10-07 18:10 +0200
Re: [PATCH v2] clocksource/drivers/tango_xtal: Add new timer for Tango SoCs Mason <slash.tmp@free.fr> - 2015-10-08 15:20 +0200
[PATCH v3] clocksource/drivers/tango_xtal: Add new timer for Tango SoCs Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2015-10-09 14:30 +0200
Re: [PATCH v3] clocksource/drivers/tango_xtal: Add new timer for Tango SoCs Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-10-09 15:30 +0200
Re: [PATCH v3] clocksource/drivers/tango_xtal: Add new timer for Tango SoCs Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2015-10-09 15:50 +0200
Re: [PATCH v3] clocksource/drivers/tango_xtal: Add new timer for Tango SoCs Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-10-09 16:30 +0200
Re: [PATCH v3] clocksource/drivers/tango_xtal: Add new timer for Tango SoCs Nicolas Pitre <nicolas.pitre@linaro.org> - 2015-10-09 18:40 +0200
[PATCH v4] clocksource/drivers/tango_xtal: Add new timer for Tango SoCs Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2015-10-09 16:40 +0200
Re: [PATCH v4] clocksource/drivers/tango_xtal: Add new timer for Tango SoCs Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-10-09 16:50 +0200
[PATCH v5] clocksource/drivers/tango_xtal: Add new timer for Tango SoCs Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2015-10-09 17:00 +0200
Re: [PATCH v5] clocksource/drivers/tango_xtal: Add new timer for Tango SoCs Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-10-16 14:10 +0200
Re: [PATCH v4] clocksource/drivers/tango_xtal: Add new timer for Tango SoCs Måns Rullgård <mans@mansr.com> - 2015-10-09 17:00 +0200
Re: [PATCH v4] clocksource/drivers/tango_xtal: Add new timer for Tango SoCs Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2015-10-09 17:50 +0200
Re: [PATCH v4] clocksource/drivers/tango_xtal: Add new timer for Tango SoCs Måns Rullgård <mans@mansr.com> - 2015-10-09 18:10 +0200
Re: [PATCH v4] clocksource/drivers/tango_xtal: Add new timer for Tango SoCs Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2015-10-09 18:40 +0200
Page 2 of 2 — ← Prev page 1 [2]
| From | Måns Rullgård <mans@mansr.com> |
|---|---|
| Date | 2015-10-09 17:00 +0200 |
| Subject | Re: [PATCH v4] clocksource/drivers/tango_xtal: Add new timer for Tango SoCs |
| Message-ID | <qhHjk-5g5-9@gated-at.bofh.it> |
| In reply to | #1243429 |
Marc Gonzalez <marc_gonzalez@sigmadesigns.com> writes: > Sigma Designs Tango platforms provide a 27 MHz crystal oscillator. > Use it for clocksource, sched_clock, and delay_timer. Given the nature of this hardware, I think it would make much more sense to support it in a generic fashion. Otherwise the next chip that comes along with a similar counter will result in near duplicate of this "driver", and so on. I've suggested this before, and I even sent patches for it (currently under discussion), but you keep refusing to listen. Are you that desperate to see your name on a commit? The fact that you keep rewriting, poorly, code you know I've already made available suggests this might be the case. You even admit in private that you couldn't have done this without looking at my tango3 tree. Frankly, I find your behaviour shameful. -- Måns Rullgård mans@mansr.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Marc Gonzalez <marc_gonzalez@sigmadesigns.com> |
|---|---|
| Date | 2015-10-09 17:50 +0200 |
| Subject | Re: [PATCH v4] clocksource/drivers/tango_xtal: Add new timer for Tango SoCs |
| Message-ID | <qhI5J-6qA-51@gated-at.bofh.it> |
| In reply to | #1243450 |
Måns Rullgård wrote: > Marc Gonzalez wrote: > >> Sigma Designs Tango platforms provide a 27 MHz crystal oscillator. >> Use it for clocksource, sched_clock, and delay_timer. > > Given the nature of this hardware, I think it would make much more sense > to support it in a generic fashion. Otherwise the next chip that comes > along with a similar counter will result in near duplicate of this > "driver", and so on. I didn't /want/ to write this driver, or rather this "driver" as you put it (implying that it is so trivial that I am lame even to submit it). It was living happily in arch/arm/clock-tango.c, but Arnd pointed out that such code must migrate to drivers/clocksource. I find your claim that this minimal device (a single register really) should be supported in a generic fashion questionable. No one seems to have ever needed this, yet it has suddenly become urgent to have it right now? I would probably have used your driver had it been mainlined; but it is not, and Rob and Mark didn't seem convinced AFAICT... (Also note that your driver doesn't set up the delay timer, which I want.) I'm sorry if my mainlining effort is not compatible with your schedule, but I've been working on this port for 6 months, and I can't wait a few more weeks just because you're not quite ready. (Have you mainstreamed the eth and intc driver? I would actually need those.) > I've suggested this before, and I even sent > patches for it (currently under discussion), Yes, and you carefully omitted to CC me, despite my request that you do so. Thanks for that. > but you keep refusing to listen. Are you that desperate to see your > name on a commit? The fact > that you keep rewriting, poorly, code you know I've already made > available suggests this might be the case. You even admit in private > that you couldn't have done this without looking at my tango3 tree. > Frankly, I find your behaviour shameful. Don't twist my words. I said I couldn't have written the eth and intc driver (and relevant DT setup). Are you now simultaneously claiming that 1) my driver is trivial 2) I couldn't have written it without your help implying that I cannot code even trivial drivers? EOT -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Måns Rullgård <mans@mansr.com> |
|---|---|
| Date | 2015-10-09 18:10 +0200 |
| Subject | Re: [PATCH v4] clocksource/drivers/tango_xtal: Add new timer for Tango SoCs |
| Message-ID | <qhIp4-72M-25@gated-at.bofh.it> |
| In reply to | #1243491 |
Marc Gonzalez <marc_gonzalez@sigmadesigns.com> writes:
> Måns Rullgård wrote:
>
>> Marc Gonzalez wrote:
>>
>>> Sigma Designs Tango platforms provide a 27 MHz crystal oscillator.
>>> Use it for clocksource, sched_clock, and delay_timer.
>>
>> Given the nature of this hardware, I think it would make much more sense
>> to support it in a generic fashion. Otherwise the next chip that comes
>> along with a similar counter will result in near duplicate of this
>> "driver", and so on.
>
> I didn't /want/ to write this driver, or rather this "driver" as you put it
> (implying that it is so trivial that I am lame even to submit it). It was
> living happily in arch/arm/clock-tango.c, but Arnd pointed out that such
> code must migrate to drivers/clocksource.
>
> I find your claim that this minimal device (a single register really) should
> be supported in a generic fashion questionable. No one seems to have ever
> needed this, yet it has suddenly become urgent to have it right now?
Apparently, nobody has needed it before (I can't say for sure that no
existing drivers could be simplified). That doesn't mean that nobody
will need it again. When something can be supported in a generic way,
it is usually a good idea to do that. It saves work in the long term.
> I'm sorry if my mainlining effort is not compatible with your schedule, but
> I've been working on this port for 6 months, and I can't wait a few more
> weeks just because you're not quite ready. (Have you mainstreamed the eth
> and intc driver? I would actually need those.)
You (Sigma) had the chance to contract me to help out with this work and
strongly indicated ("we will send you a contract for review by the end
of the week") that you would. Then you backtracked in a rather ugly
manner. Forgive me if I'm less than motivated to suddenly spend hours
of unpaid time helping you get things in shape. If you don't want to
pay me, you also don't get to set my schedule. Besides, you've never
shown any interest whatsoever in upstreaming before, so I really don't
see why it is so urgent for you now.
--
Måns Rullgård
mans@mansr.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Marc Gonzalez <marc_gonzalez@sigmadesigns.com> |
|---|---|
| Date | 2015-10-09 18:40 +0200 |
| Subject | Re: [PATCH v4] clocksource/drivers/tango_xtal: Add new timer for Tango SoCs |
| Message-ID | <qhIS6-7BS-23@gated-at.bofh.it> |
| In reply to | #1243507 |
On 09/10/2015 18:01, Måns Rullgård wrote:
> Marc Gonzalez wrote:
>
>> Måns Rullgård wrote:
>>
>>> Marc Gonzalez wrote:
>>>
>>>> Sigma Designs Tango platforms provide a 27 MHz crystal oscillator.
>>>> Use it for clocksource, sched_clock, and delay_timer.
>>>
>>> Given the nature of this hardware, I think it would make much more sense
>>> to support it in a generic fashion. Otherwise the next chip that comes
>>> along with a similar counter will result in near duplicate of this
>>> "driver", and so on.
>>
>> I didn't /want/ to write this driver, or rather this "driver" as you put it
>> (implying that it is so trivial that I am lame even to submit it). It was
>> living happily in arch/arm/clock-tango.c, but Arnd pointed out that such
>> code must migrate to drivers/clocksource.
>>
>> I find your claim that this minimal device (a single register really) should
>> be supported in a generic fashion questionable. No one seems to have ever
>> needed this, yet it has suddenly become urgent to have it right now?
>
> Apparently, nobody has needed it before (I can't say for sure that no
> existing drivers could be simplified). That doesn't mean that nobody
> will need it again. When something can be supported in a generic way,
> it is usually a good idea to do that. It saves work in the long term.
You snipped this:
I would probably have used your driver had it been mainlined.
(Also note that your driver doesn't set up the delay timer, which I want.)
>> I'm sorry if my mainlining effort is not compatible with your schedule, but
>> I've been working on this port for 6 months, and I can't wait a few more
>> weeks just because you're not quite ready. (Have you mainstreamed the eth
>> and intc driver? I would actually need those.)
>
> You (Sigma)
I am not Sigma, I am Marc. I am a software dev grunt, and I have
no influence on recruitment process, business decisions, etc.
> had the chance to contract me to help out with this work and
> strongly indicated ("we will send you a contract for review by the end
> of the week") that you would. Then you backtracked in a rather ugly
> manner.
I am sorry that you were treated like that :-(
> Forgive me if I'm less than motivated to suddenly spend hours
> of unpaid time helping you get things in shape.
<confused> I am just asking that you stop popping up on MLs NAKing
each one of my patches.
> If you don't want to pay me, you also don't get to set my schedule.
<confused> Are you referring to the DT changes I've asked you to make?
> Besides, you've never
> shown any interest whatsoever in upstreaming before, so I really don't
> see why it is so urgent for you now.
Trying to turn the tables, nice :-)
It is urgent because I have been working full-time on this for two months,
and I'd like to have results to show for it. (Management is not convinced
that upstreaming is a good idea.)
If you take a step back, you'll see that I have accepted your input and
criticism every time I thought it was warranted, e.g. everything UART
related. (And why would I not? It's nice to benefit from great work.)
But your claims regarding the clock tree are inaccurate. (I'll address
them in a separate message.)
Regards.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Page 2 of 2 — ← Prev page 1 [2]
Back to top | Article view | linux.kernel
csiph-web