Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1243199 > unrolled thread
| Started by | Wolfram Sang <wsa@the-dreams.de> |
|---|---|
| First post | 2015-10-09 11:50 +0200 |
| Last post | 2015-10-15 13:50 +0200 |
| Articles | 2 — 1 participant |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH v2 2/4] i2c: rcar: enable RuntimePM before registering to the core Wolfram Sang <wsa@the-dreams.de> - 2015-10-09 11:50 +0200
Re: [PATCH v2 2/4] i2c: rcar: enable RuntimePM before registering to the core Wolfram Sang <wsa@the-dreams.de> - 2015-10-15 13:50 +0200
| From | Wolfram Sang <wsa@the-dreams.de> |
|---|---|
| Date | 2015-10-09 11:50 +0200 |
| Subject | [PATCH v2 2/4] i2c: rcar: enable RuntimePM before registering to the core |
| Message-ID | <qhCtk-6Ne-27@gated-at.bofh.it> |
From: Wolfram Sang <wsa+renesas@sang-engineering.com>
The core may register clients attached to this master which may use
funtionality from the master. So, RuntimePM must be enabled before, otherwise
this will fail. While here, move drvdata, too.
Reported-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
drivers/i2c/busses/i2c-rcar.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/i2c/busses/i2c-rcar.c b/drivers/i2c/busses/i2c-rcar.c
index d8361dada58455..d8b5a8fee1e6c8 100644
--- a/drivers/i2c/busses/i2c-rcar.c
+++ b/drivers/i2c/busses/i2c-rcar.c
@@ -690,15 +690,16 @@ static int rcar_i2c_probe(struct platform_device *pdev)
return ret;
}
+ pm_runtime_enable(dev);
+ platform_set_drvdata(pdev, priv);
+
ret = i2c_add_numbered_adapter(adap);
if (ret < 0) {
dev_err(dev, "reg adap failed: %d\n", ret);
+ pm_runtime_disable(dev);
return ret;
}
- pm_runtime_enable(dev);
- platform_set_drvdata(pdev, priv);
-
dev_info(dev, "probed\n");
return 0;
--
2.1.4
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Wolfram Sang <wsa@the-dreams.de> |
|---|---|
| Date | 2015-10-15 13:50 +0200 |
| Subject | Re: [PATCH v2 2/4] i2c: rcar: enable RuntimePM before registering to the core |
| Message-ID | <qjPcK-5ko-19@gated-at.bofh.it> |
| In reply to | #1243199 |
[Multipart message — attachments visible in raw view] — view raw
On Fri, Oct 09, 2015 at 10:39:25AM +0100, Wolfram Sang wrote: > From: Wolfram Sang <wsa+renesas@sang-engineering.com> > > The core may register clients attached to this master which may use > funtionality from the master. So, RuntimePM must be enabled before, otherwise > this will fail. While here, move drvdata, too. > > Reported-by: Geert Uytterhoeven <geert+renesas@glider.be> > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Applied to for-current, thanks!
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web