Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1243089 > unrolled thread

Re: [PATCH 02/10] clk: nsp: add clock support for Broadcom Northstar Plus SoC

Started byStephen Boyd <sboyd@codeaurora.org>
First post2015-10-09 09:40 +0200
Last post2015-10-09 20:00 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH 02/10] clk: nsp: add clock support for Broadcom Northstar  Plus SoC Stephen Boyd <sboyd@codeaurora.org> - 2015-10-09 09:40 +0200
    Re: [PATCH 02/10] clk: nsp: add clock support for Broadcom Northstar  Plus SoC Jon Mason <jonmason@broadcom.com> - 2015-10-09 20:00 +0200

#1243089 — Re: [PATCH 02/10] clk: nsp: add clock support for Broadcom Northstar Plus SoC

FromStephen Boyd <sboyd@codeaurora.org>
Date2015-10-09 09:40 +0200
SubjectRe: [PATCH 02/10] clk: nsp: add clock support for Broadcom Northstar Plus SoC
Message-ID<qhArv-3UI-1@gated-at.bofh.it>
On 10/02, Jon Mason wrote:
> diff --git a/drivers/clk/bcm/clk-nsp.c b/drivers/clk/bcm/clk-nsp.c
> new file mode 100644
> index 0000000..708961a
> --- /dev/null
> +++ b/drivers/clk/bcm/clk-nsp.c
> @@ -0,0 +1,139 @@
> +/*
> + * Copyright (C) 2015 Broadcom Corporation
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License as
> + * published by the Free Software Foundation version 2.
> + *
> + * This program is distributed "as is" WITHOUT ANY WARRANTY of any
> + * kind, whether express or implied; without even the implied warranty
> + * of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + */
> +
> +#include <linux/kernel.h>
> +#include <linux/err.h>
> +#include <linux/clk-provider.h>
> +#include <linux/io.h>
> +#include <linux/of.h>
> +#include <linux/clkdev.h>

Is this used?

> +#include <linux/of_address.h>
> +#include <linux/delay.h>

Is this used?

> +
> +#include <dt-bindings/clock/bcm-nsp.h>
> +#include "clk-iproc.h"

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]


#1243569

FromJon Mason <jonmason@broadcom.com>
Date2015-10-09 20:00 +0200
Message-ID<qhK7w-Tp-25@gated-at.bofh.it>
In reply to#1243089
On Fri, Oct 09, 2015 at 12:37:46AM -0700, Stephen Boyd wrote:
> On 10/02, Jon Mason wrote:
> > diff --git a/drivers/clk/bcm/clk-nsp.c b/drivers/clk/bcm/clk-nsp.c
> > new file mode 100644
> > index 0000000..708961a
> > --- /dev/null
> > +++ b/drivers/clk/bcm/clk-nsp.c
> > @@ -0,0 +1,139 @@
> > +/*
> > + * Copyright (C) 2015 Broadcom Corporation
> > + *
> > + * This program is free software; you can redistribute it and/or
> > + * modify it under the terms of the GNU General Public License as
> > + * published by the Free Software Foundation version 2.
> > + *
> > + * This program is distributed "as is" WITHOUT ANY WARRANTY of any
> > + * kind, whether express or implied; without even the implied warranty
> > + * of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> > + * GNU General Public License for more details.
> > + */
> > +
> > +#include <linux/kernel.h>
> > +#include <linux/err.h>
> > +#include <linux/clk-provider.h>
> > +#include <linux/io.h>
> > +#include <linux/of.h>
> > +#include <linux/clkdev.h>
> 
> Is this used?
> 
> > +#include <linux/of_address.h>
> > +#include <linux/delay.h>
> 
> Is this used?

I removed the clkdev and delay headers, and it appears to be working
fine without them.  I'll rework this commit and resubmit.

Thanks,
Jon

> 
> > +
> > +#include <dt-bindings/clock/bcm-nsp.h>
> > +#include "clk-iproc.h"
> 
> -- 
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
> a Linux Foundation Collaborative Project
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web