Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1235664 > unrolled thread
| Started by | Ashutosh Dixit <ashutosh.dixit@intel.com> |
|---|---|
| First post | 2015-09-30 02:50 +0200 |
| Last post | 2015-10-06 07:30 +0200 |
| Articles | 10 — 4 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH char-misc-next v2 04/22] iommu: Allow iova to be used without requiring IOMMU_SUPPORT Ashutosh Dixit <ashutosh.dixit@intel.com> - 2015-09-30 02:50 +0200
Re: [PATCH char-misc-next v2 04/22] iommu: Allow iova to be used without requiring IOMMU_SUPPORT "Woodhouse, David" <david.woodhouse@intel.com> - 2015-10-05 13:00 +0200
Re: [PATCH char-misc-next v2 04/22] iommu: Allow iova to be used without requiring IOMMU_SUPPORT Sudeep Dutt <sudeep.dutt@intel.com> - 2015-10-05 19:50 +0200
Re: [PATCH char-misc-next v2 04/22] iommu: Allow iova to be used without requiring IOMMU_SUPPORT "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org> - 2015-10-06 07:20 +0200
Re: [PATCH char-misc-next v2 04/22] iommu: Allow iova to be used without requiring IOMMU_SUPPORT Sudeep Dutt <sudeep.dutt@intel.com> - 2015-10-06 07:30 +0200
Re: [PATCH char-misc-next v2 04/22] iommu: Allow iova to be used without requiring IOMMU_SUPPORT "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org> - 2015-10-06 10:00 +0200
Re: [PATCH char-misc-next v2 04/22] iommu: Allow iova to be used without requiring IOMMU_SUPPORT Sudeep Dutt <sudeep.dutt@intel.com> - 2015-10-06 10:10 +0200
Re: [PATCH char-misc-next v2 04/22] iommu: Allow iova to be used without requiring IOMMU_SUPPORT "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org> - 2015-10-06 10:50 +0200
Re: [PATCH char-misc-next v2 04/22] iommu: Allow iova to be used without requiring IOMMU_SUPPORT Sudeep Dutt <sudeep.dutt@intel.com> - 2015-10-06 14:10 +0200
Re: [PATCH char-misc-next v2 04/22] iommu: Allow iova to be used without requiring IOMMU_SUPPORT "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org> - 2015-10-06 07:30 +0200
| From | Ashutosh Dixit <ashutosh.dixit@intel.com> |
|---|---|
| Date | 2015-09-30 02:50 +0200 |
| Subject | [PATCH char-misc-next v2 04/22] iommu: Allow iova to be used without requiring IOMMU_SUPPORT |
| Message-ID | <qedKN-5VS-9@gated-at.bofh.it> |
From: Sudeep Dutt <sudeep.dutt@intel.com>
iova is a library which can be built without IOMMU_SUPPORT
Signed-off-by: Sudeep Dutt <sudeep.dutt@intel.com>
---
drivers/iommu/Kconfig | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/iommu/Kconfig b/drivers/iommu/Kconfig
index d9da766..71d1c46 100644
--- a/drivers/iommu/Kconfig
+++ b/drivers/iommu/Kconfig
@@ -12,6 +12,9 @@ menuconfig IOMMU_SUPPORT
remap DMA requests and/or remap interrupts from other devices on the
system.
+config IOMMU_IOVA
+ tristate
+
if IOMMU_SUPPORT
menu "Generic IOMMU Pagetable Support"
@@ -42,9 +45,6 @@ config IOMMU_IO_PGTABLE_LPAE_SELFTEST
endmenu
-config IOMMU_IOVA
- tristate
-
config OF_IOMMU
def_bool y
depends on OF && IOMMU_API
--
2.0.0.rc3.2.g998f840
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | "Woodhouse, David" <david.woodhouse@intel.com> |
|---|---|
| Date | 2015-10-05 13:00 +0200 |
| Subject | Re: [PATCH char-misc-next v2 04/22] iommu: Allow iova to be used without requiring IOMMU_SUPPORT |
| Message-ID | <qgbES-56q-25@gated-at.bofh.it> |
| In reply to | #1235664 |
[Multipart message — attachments visible in raw view] — view raw
On Tue, 2015-09-29 at 18:09 -0700, Ashutosh Dixit wrote: > From: Sudeep Dutt <sudeep.dutt@intel.com> > > iova is a library which can be built without IOMMU_SUPPORT > > Signed-off-by: Sudeep Dutt <sudeep.dutt@intel.com> The first three of these patches are in 4.3-rc4 already. Apologies for the delay in pushing them out. This one looks sane enough too, but perhaps in that case we should move the code *out* of drivers/iommu/ and into lib/iova/ ? -- David Woodhouse Open Source Technology Centre David.Woodhouse@intel.com Intel Corporation
[toc] | [prev] | [next] | [standalone]
| From | Sudeep Dutt <sudeep.dutt@intel.com> |
|---|---|
| Date | 2015-10-05 19:50 +0200 |
| Subject | Re: [PATCH char-misc-next v2 04/22] iommu: Allow iova to be used without requiring IOMMU_SUPPORT |
| Message-ID | <qgi3E-5Td-9@gated-at.bofh.it> |
| In reply to | #1239454 |
On Mon, 2015-10-05 at 03:50 -0700, Woodhouse, David wrote: > On Tue, 2015-09-29 at 18:09 -0700, Ashutosh Dixit wrote: > > From: Sudeep Dutt <sudeep.dutt@intel.com> > > > > iova is a library which can be built without IOMMU_SUPPORT > > > > Signed-off-by: Sudeep Dutt <sudeep.dutt@intel.com> > > The first three of these patches are in 4.3-rc4 already. Apologies for > the delay in pushing them out. > > This one looks sane enough too, but perhaps in that case we should move > the code *out* of drivers/iommu/ and into lib/iova/ ? > Yes, moving the code into lib/iova is the correct long term solution. I have sent Greg a patch which reverts this commit since it is no longer required and will create a merge conflict for him unnecessarily as well with 4.3-rc4. Thanks, Sudeep Dutt -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2015-10-06 07:20 +0200 |
| Subject | Re: [PATCH char-misc-next v2 04/22] iommu: Allow iova to be used without requiring IOMMU_SUPPORT |
| Message-ID | <qgsPo-4Pf-11@gated-at.bofh.it> |
| In reply to | #1239792 |
On Mon, Oct 05, 2015 at 10:38:43AM -0700, Sudeep Dutt wrote: > On Mon, 2015-10-05 at 03:50 -0700, Woodhouse, David wrote: > > On Tue, 2015-09-29 at 18:09 -0700, Ashutosh Dixit wrote: > > > From: Sudeep Dutt <sudeep.dutt@intel.com> > > > > > > iova is a library which can be built without IOMMU_SUPPORT > > > > > > Signed-off-by: Sudeep Dutt <sudeep.dutt@intel.com> > > > > The first three of these patches are in 4.3-rc4 already. Apologies for > > the delay in pushing them out. > > > > This one looks sane enough too, but perhaps in that case we should move > > the code *out* of drivers/iommu/ and into lib/iova/ ? > > > > Yes, moving the code into lib/iova is the correct long term solution. I > have sent Greg a patch which reverts this commit since it is no longer > required and will create a merge conflict for him unnecessarily as well > with 4.3-rc4. I can handle merge issues, that's trivial. Reverting the patch shoulnd't really be needed, right? Let me see what happens when I merge to see if your patch is necessary... -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Sudeep Dutt <sudeep.dutt@intel.com> |
|---|---|
| Date | 2015-10-06 07:30 +0200 |
| Subject | Re: [PATCH char-misc-next v2 04/22] iommu: Allow iova to be used without requiring IOMMU_SUPPORT |
| Message-ID | <qgsZ4-50l-1@gated-at.bofh.it> |
| In reply to | #1240148 |
On Tue, 2015-10-06 at 06:20 +0100, gregkh@linuxfoundation.org wrote: > On Tue, Oct 06, 2015 at 06:12:40AM +0100, gregkh@linuxfoundation.org wrote: > > On Mon, Oct 05, 2015 at 10:38:43AM -0700, Sudeep Dutt wrote: > > > On Mon, 2015-10-05 at 03:50 -0700, Woodhouse, David wrote: > > > > On Tue, 2015-09-29 at 18:09 -0700, Ashutosh Dixit wrote: > > > > > From: Sudeep Dutt <sudeep.dutt@intel.com> > > > > > > > > > > iova is a library which can be built without IOMMU_SUPPORT > > > > > > > > > > Signed-off-by: Sudeep Dutt <sudeep.dutt@intel.com> > > > > > > > > The first three of these patches are in 4.3-rc4 already. Apologies for > > > > the delay in pushing them out. > > > > > > > > This one looks sane enough too, but perhaps in that case we should move > > > > the code *out* of drivers/iommu/ and into lib/iova/ ? > > > > > > > > > > Yes, moving the code into lib/iova is the correct long term solution. I > > > have sent Greg a patch which reverts this commit since it is no longer > > > required and will create a merge conflict for him unnecessarily as well > > > with 4.3-rc4. > > > > I can handle merge issues, that's trivial. Reverting the patch > > shoulnd't really be needed, right? Let me see what happens when I merge > > to see if your patch is necessary... > > Ok, I don't think it is needed, the merge was pretty trivial. > > Can you test out my char-misc-testing branch right now to see if it's > all ok with the merge? If so, I'll move it all over to the "real" place > for it to start showing up in linux-next, i.e. my char-misc-next branch. > Hi Greg, I think it is best to revert this patch as it is incorrect. The iommu folder gets compiled only if IOMMU_SUPPORT is enabled so IOMMU_IOVA should indeed be included only when IOMMU_SUPPORT is enabled. Sincere apologies for the mess here but I believe it will all get fixed up if you accept the revert of 353649e5da I sent across earlier today. Thanks, Sudeep Dutt -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2015-10-06 10:00 +0200 |
| Subject | Re: [PATCH char-misc-next v2 04/22] iommu: Allow iova to be used without requiring IOMMU_SUPPORT |
| Message-ID | <qgvke-8jp-25@gated-at.bofh.it> |
| In reply to | #1240150 |
On Mon, Oct 05, 2015 at 10:23:38PM -0700, Sudeep Dutt wrote: > On Tue, 2015-10-06 at 06:20 +0100, gregkh@linuxfoundation.org wrote: > > On Tue, Oct 06, 2015 at 06:12:40AM +0100, gregkh@linuxfoundation.org wrote: > > > On Mon, Oct 05, 2015 at 10:38:43AM -0700, Sudeep Dutt wrote: > > > > On Mon, 2015-10-05 at 03:50 -0700, Woodhouse, David wrote: > > > > > On Tue, 2015-09-29 at 18:09 -0700, Ashutosh Dixit wrote: > > > > > > From: Sudeep Dutt <sudeep.dutt@intel.com> > > > > > > > > > > > > iova is a library which can be built without IOMMU_SUPPORT > > > > > > > > > > > > Signed-off-by: Sudeep Dutt <sudeep.dutt@intel.com> > > > > > > > > > > The first three of these patches are in 4.3-rc4 already. Apologies for > > > > > the delay in pushing them out. > > > > > > > > > > This one looks sane enough too, but perhaps in that case we should move > > > > > the code *out* of drivers/iommu/ and into lib/iova/ ? > > > > > > > > > > > > > Yes, moving the code into lib/iova is the correct long term solution. I > > > > have sent Greg a patch which reverts this commit since it is no longer > > > > required and will create a merge conflict for him unnecessarily as well > > > > with 4.3-rc4. > > > > > > I can handle merge issues, that's trivial. Reverting the patch > > > shoulnd't really be needed, right? Let me see what happens when I merge > > > to see if your patch is necessary... > > > > Ok, I don't think it is needed, the merge was pretty trivial. > > > > Can you test out my char-misc-testing branch right now to see if it's > > all ok with the merge? If so, I'll move it all over to the "real" place > > for it to start showing up in linux-next, i.e. my char-misc-next branch. > > > > Hi Greg, > > I think it is best to revert this patch as it is incorrect. The iommu > folder gets compiled only if IOMMU_SUPPORT is enabled so IOMMU_IOVA > should indeed be included only when IOMMU_SUPPORT is enabled. > > Sincere apologies for the mess here but I believe it will all get fixed > up if you accept the revert of 353649e5da I sent across earlier today. Again, look at the merge, I think I already handled this in that manner. If not, let me know. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Sudeep Dutt <sudeep.dutt@intel.com> |
|---|---|
| Date | 2015-10-06 10:10 +0200 |
| Subject | Re: [PATCH char-misc-next v2 04/22] iommu: Allow iova to be used without requiring IOMMU_SUPPORT |
| Message-ID | <qgvtU-iV-1@gated-at.bofh.it> |
| In reply to | #1240224 |
On Tue, 2015-10-06 at 08:56 +0100, gregkh@linuxfoundation.org wrote: > On Mon, Oct 05, 2015 at 10:23:38PM -0700, Sudeep Dutt wrote: > > On Tue, 2015-10-06 at 06:20 +0100, gregkh@linuxfoundation.org wrote: > > > On Tue, Oct 06, 2015 at 06:12:40AM +0100, gregkh@linuxfoundation.org wrote: > > > > On Mon, Oct 05, 2015 at 10:38:43AM -0700, Sudeep Dutt wrote: > > > > > On Mon, 2015-10-05 at 03:50 -0700, Woodhouse, David wrote: > > > > > > On Tue, 2015-09-29 at 18:09 -0700, Ashutosh Dixit wrote: > > > > > > > From: Sudeep Dutt <sudeep.dutt@intel.com> > > > > > > > > > > > > > > iova is a library which can be built without IOMMU_SUPPORT > > > > > > > > > > > > > > Signed-off-by: Sudeep Dutt <sudeep.dutt@intel.com> > > > > > > > > > > > > The first three of these patches are in 4.3-rc4 already. Apologies for > > > > > > the delay in pushing them out. > > > > > > > > > > > > This one looks sane enough too, but perhaps in that case we should move > > > > > > the code *out* of drivers/iommu/ and into lib/iova/ ? > > > > > > > > > > > > > > > > Yes, moving the code into lib/iova is the correct long term solution. I > > > > > have sent Greg a patch which reverts this commit since it is no longer > > > > > required and will create a merge conflict for him unnecessarily as well > > > > > with 4.3-rc4. > > > > > > > > I can handle merge issues, that's trivial. Reverting the patch > > > > shoulnd't really be needed, right? Let me see what happens when I merge > > > > to see if your patch is necessary... > > > > > > Ok, I don't think it is needed, the merge was pretty trivial. > > > > > > Can you test out my char-misc-testing branch right now to see if it's > > > all ok with the merge? If so, I'll move it all over to the "real" place > > > for it to start showing up in linux-next, i.e. my char-misc-next branch. > > > > > > > Hi Greg, > > > > I think it is best to revert this patch as it is incorrect. The iommu > > folder gets compiled only if IOMMU_SUPPORT is enabled so IOMMU_IOVA > > should indeed be included only when IOMMU_SUPPORT is enabled. > > > > Sincere apologies for the mess here but I believe it will all get fixed > > up if you accept the revert of 353649e5da I sent across earlier today. > > Again, look at the merge, I think I already handled this in that manner. > If not, let me know. > Hi Greg, I took a look at your latest char-misc-testing tree and it needs to be fixed up. IOMMU_IOVA should be inside the "if IOMMU_SUPPORT" block instead of above it. git revert 353649e5da in the char-misc-testing tree will fix everything up or you could also apply the patch I sent earlier today which has the same revert. Thanks, Sudeep Dutt -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2015-10-06 10:50 +0200 |
| Subject | Re: [PATCH char-misc-next v2 04/22] iommu: Allow iova to be used without requiring IOMMU_SUPPORT |
| Message-ID | <qgw6B-13i-1@gated-at.bofh.it> |
| In reply to | #1240229 |
On Tue, Oct 06, 2015 at 01:05:27AM -0700, Sudeep Dutt wrote: > On Tue, 2015-10-06 at 08:56 +0100, gregkh@linuxfoundation.org wrote: > > On Mon, Oct 05, 2015 at 10:23:38PM -0700, Sudeep Dutt wrote: > > > On Tue, 2015-10-06 at 06:20 +0100, gregkh@linuxfoundation.org wrote: > > > > On Tue, Oct 06, 2015 at 06:12:40AM +0100, gregkh@linuxfoundation.org wrote: > > > > > On Mon, Oct 05, 2015 at 10:38:43AM -0700, Sudeep Dutt wrote: > > > > > > On Mon, 2015-10-05 at 03:50 -0700, Woodhouse, David wrote: > > > > > > > On Tue, 2015-09-29 at 18:09 -0700, Ashutosh Dixit wrote: > > > > > > > > From: Sudeep Dutt <sudeep.dutt@intel.com> > > > > > > > > > > > > > > > > iova is a library which can be built without IOMMU_SUPPORT > > > > > > > > > > > > > > > > Signed-off-by: Sudeep Dutt <sudeep.dutt@intel.com> > > > > > > > > > > > > > > The first three of these patches are in 4.3-rc4 already. Apologies for > > > > > > > the delay in pushing them out. > > > > > > > > > > > > > > This one looks sane enough too, but perhaps in that case we should move > > > > > > > the code *out* of drivers/iommu/ and into lib/iova/ ? > > > > > > > > > > > > > > > > > > > Yes, moving the code into lib/iova is the correct long term solution. I > > > > > > have sent Greg a patch which reverts this commit since it is no longer > > > > > > required and will create a merge conflict for him unnecessarily as well > > > > > > with 4.3-rc4. > > > > > > > > > > I can handle merge issues, that's trivial. Reverting the patch > > > > > shoulnd't really be needed, right? Let me see what happens when I merge > > > > > to see if your patch is necessary... > > > > > > > > Ok, I don't think it is needed, the merge was pretty trivial. > > > > > > > > Can you test out my char-misc-testing branch right now to see if it's > > > > all ok with the merge? If so, I'll move it all over to the "real" place > > > > for it to start showing up in linux-next, i.e. my char-misc-next branch. > > > > > > > > > > Hi Greg, > > > > > > I think it is best to revert this patch as it is incorrect. The iommu > > > folder gets compiled only if IOMMU_SUPPORT is enabled so IOMMU_IOVA > > > should indeed be included only when IOMMU_SUPPORT is enabled. > > > > > > Sincere apologies for the mess here but I believe it will all get fixed > > > up if you accept the revert of 353649e5da I sent across earlier today. > > > > Again, look at the merge, I think I already handled this in that manner. > > If not, let me know. > > > > Hi Greg, > > I took a look at your latest char-misc-testing tree and it needs to be > fixed up. IOMMU_IOVA should be inside the "if IOMMU_SUPPORT" block > instead of above it. > > git revert 353649e5da in the char-misc-testing tree will fix everything > up or you could also apply the patch I sent earlier today which has the > same revert. Ok, I've applied your patch, rolled back the merge, and that should be good, right? If so, I'll push this branch out to char-misc-next and then merge in 4.3-rc4 just to keep everything up to date. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Sudeep Dutt <sudeep.dutt@intel.com> |
|---|---|
| Date | 2015-10-06 14:10 +0200 |
| Subject | Re: [PATCH char-misc-next v2 04/22] iommu: Allow iova to be used without requiring IOMMU_SUPPORT |
| Message-ID | <qgzea-5GN-19@gated-at.bofh.it> |
| In reply to | #1240260 |
On Tue, 2015-10-06 at 09:33 +0100, gregkh@linuxfoundation.org wrote: > On Tue, Oct 06, 2015 at 01:05:27AM -0700, Sudeep Dutt wrote: > > On Tue, 2015-10-06 at 08:56 +0100, gregkh@linuxfoundation.org wrote: > > > On Mon, Oct 05, 2015 at 10:23:38PM -0700, Sudeep Dutt wrote: > > > > On Tue, 2015-10-06 at 06:20 +0100, gregkh@linuxfoundation.org wrote: > > > > > On Tue, Oct 06, 2015 at 06:12:40AM +0100, gregkh@linuxfoundation.org wrote: > > > > > > On Mon, Oct 05, 2015 at 10:38:43AM -0700, Sudeep Dutt wrote: > > > > > > > On Mon, 2015-10-05 at 03:50 -0700, Woodhouse, David wrote: > > > > > > > > On Tue, 2015-09-29 at 18:09 -0700, Ashutosh Dixit wrote: > > > > > > > > > From: Sudeep Dutt <sudeep.dutt@intel.com> > > > > > > > > > > > > > > > > > > iova is a library which can be built without IOMMU_SUPPORT > > > > > > > > > > > > > > > > > > Signed-off-by: Sudeep Dutt <sudeep.dutt@intel.com> > > > > > > > > > > > > > > > > The first three of these patches are in 4.3-rc4 already. Apologies for > > > > > > > > the delay in pushing them out. > > > > > > > > > > > > > > > > This one looks sane enough too, but perhaps in that case we should move > > > > > > > > the code *out* of drivers/iommu/ and into lib/iova/ ? > > > > > > > > > > > > > > > > > > > > > > Yes, moving the code into lib/iova is the correct long term solution. I > > > > > > > have sent Greg a patch which reverts this commit since it is no longer > > > > > > > required and will create a merge conflict for him unnecessarily as well > > > > > > > 0000d3bd-0010 > > > > > > > > > > > > I can handle merge issues, that's trivial. Reverting the patch > > > > > > shoulnd't really be needed, right? Let me see what happens when I merge > > > > > > to see if your patch is necessary... > > > > > > > > > > Ok, I don't think it is needed, the merge was pretty trivial. > > > > > > > > > > Can you test out my char-misc-testing branch right now to see if it's > > > > > all ok with the merge? If so, I'll move it all over to the "real" place > > > > > for it to start showing up in linux-next, i.e. my char-misc-next branch. > > > > > > > > > > > > > Hi Greg, > > > > > > > > I think it is best to revert this patch as it is incorrect. The iommu > > > > folder gets compiled only if IOMMU_SUPPORT is enabled so IOMMU_IOVA > > > > should indeed be included only when IOMMU_SUPPORT is enabled. > > > > > > > > Sincere apologies for the mess here but I believe it will all get fixed > > > > up if you accept the revert of 353649e5da I sent across earlier today. > > > > > > Again, look at the merge, I think I already handled this in that manner. > > > If not, let me know. > > > > > > > Hi Greg, > > > > I took a look at your latest char-misc-testing tree and it needs to be > > fixed up. IOMMU_IOVA should be inside the "if IOMMU_SUPPORT" block > > instead of above it. > > > > git revert 353649e5da in the char-misc-testing tree will fix everything > > up or you could also apply the patch I sent earlier today which has the > > same revert. > > Ok, I've applied your patch, rolled back the merge, and that should be > good, right? If so, I'll push this branch out to char-misc-next and > then merge in 4.3-rc4 just to keep everything up to date. Yes, it looks good now. Thanks, Sudeep Dutt -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2015-10-06 07:30 +0200 |
| Subject | Re: [PATCH char-misc-next v2 04/22] iommu: Allow iova to be used without requiring IOMMU_SUPPORT |
| Message-ID | <qgsZ4-50l-3@gated-at.bofh.it> |
| In reply to | #1240148 |
On Tue, Oct 06, 2015 at 06:12:40AM +0100, gregkh@linuxfoundation.org wrote: > On Mon, Oct 05, 2015 at 10:38:43AM -0700, Sudeep Dutt wrote: > > On Mon, 2015-10-05 at 03:50 -0700, Woodhouse, David wrote: > > > On Tue, 2015-09-29 at 18:09 -0700, Ashutosh Dixit wrote: > > > > From: Sudeep Dutt <sudeep.dutt@intel.com> > > > > > > > > iova is a library which can be built without IOMMU_SUPPORT > > > > > > > > Signed-off-by: Sudeep Dutt <sudeep.dutt@intel.com> > > > > > > The first three of these patches are in 4.3-rc4 already. Apologies for > > > the delay in pushing them out. > > > > > > This one looks sane enough too, but perhaps in that case we should move > > > the code *out* of drivers/iommu/ and into lib/iova/ ? > > > > > > > Yes, moving the code into lib/iova is the correct long term solution. I > > have sent Greg a patch which reverts this commit since it is no longer > > required and will create a merge conflict for him unnecessarily as well > > with 4.3-rc4. > > I can handle merge issues, that's trivial. Reverting the patch > shoulnd't really be needed, right? Let me see what happens when I merge > to see if your patch is necessary... Ok, I don't think it is needed, the merge was pretty trivial. Can you test out my char-misc-testing branch right now to see if it's all ok with the merge? If so, I'll move it all over to the "real" place for it to start showing up in linux-next, i.e. my char-misc-next branch. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web