Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1240031 > unrolled thread

[PATCH] wdt: intel-mid: add Magic Closure flag

Started byDavid Cohen <david.a.cohen@linux.intel.com>
First post2015-10-06 01:50 +0200
Last post2015-10-06 02:30 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] wdt: intel-mid: add Magic Closure flag David Cohen <david.a.cohen@linux.intel.com> - 2015-10-06 01:50 +0200
    Re: [PATCH] wdt: intel-mid: add Magic Closure flag Guenter Roeck <linux@roeck-us.net> - 2015-10-06 02:30 +0200

#1240031 — [PATCH] wdt: intel-mid: add Magic Closure flag

FromDavid Cohen <david.a.cohen@linux.intel.com>
Date2015-10-06 01:50 +0200
Subject[PATCH] wdt: intel-mid: add Magic Closure flag
Message-ID<qgnG1-5Gc-1@gated-at.bofh.it>
Adding WDIOF_MAGICCLOSE to Intel MID watchdog driver. Once the watchdog
is opened, it makes sense to disable watchdog only if it was gracefully
released.

Signed-off-by: David Cohen <david.a.cohen@linux.intel.com>
---
 drivers/watchdog/intel-mid_wdt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/watchdog/intel-mid_wdt.c b/drivers/watchdog/intel-mid_wdt.c
index 0a436b5d1e84..db36d12e2b52 100644
--- a/drivers/watchdog/intel-mid_wdt.c
+++ b/drivers/watchdog/intel-mid_wdt.c
@@ -101,7 +101,7 @@ static irqreturn_t mid_wdt_irq(int irq, void *dev_id)
 
 static const struct watchdog_info mid_wdt_info = {
 	.identity = "Intel MID SCU watchdog",
-	.options = WDIOF_KEEPALIVEPING | WDIOF_SETTIMEOUT,
+	.options = WDIOF_KEEPALIVEPING | WDIOF_SETTIMEOUT | WDIOF_MAGICCLOSE,
 };
 
 static const struct watchdog_ops mid_wdt_ops = {
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]


#1240045

FromGuenter Roeck <linux@roeck-us.net>
Date2015-10-06 02:30 +0200
Message-ID<qgoiK-6Ej-7@gated-at.bofh.it>
In reply to#1240031
On 10/05/2015 04:49 PM, David Cohen wrote:
> Adding WDIOF_MAGICCLOSE to Intel MID watchdog driver. Once the watchdog
> is opened, it makes sense to disable watchdog only if it was gracefully
> released.
>
> Signed-off-by: David Cohen <david.a.cohen@linux.intel.com>

Makes sense.

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
>   drivers/watchdog/intel-mid_wdt.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/watchdog/intel-mid_wdt.c b/drivers/watchdog/intel-mid_wdt.c
> index 0a436b5d1e84..db36d12e2b52 100644
> --- a/drivers/watchdog/intel-mid_wdt.c
> +++ b/drivers/watchdog/intel-mid_wdt.c
> @@ -101,7 +101,7 @@ static irqreturn_t mid_wdt_irq(int irq, void *dev_id)
>
>   static const struct watchdog_info mid_wdt_info = {
>   	.identity = "Intel MID SCU watchdog",
> -	.options = WDIOF_KEEPALIVEPING | WDIOF_SETTIMEOUT,
> +	.options = WDIOF_KEEPALIVEPING | WDIOF_SETTIMEOUT | WDIOF_MAGICCLOSE,
>   };
>
>   static const struct watchdog_ops mid_wdt_ops = {
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web