Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1239121 > unrolled thread

Re: [PATCH] perf tools: Fix build errors with mipsel-linux-uclibc compiler

Started byAlexey Brodkin <Alexey.Brodkin@synopsys.com>
First post2015-10-04 16:00 +0200
Last post2015-10-15 00:00 +0200
Articles 4 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] perf tools: Fix build errors with mipsel-linux-uclibc  compiler Alexey Brodkin <Alexey.Brodkin@synopsys.com> - 2015-10-04 16:00 +0200
    Re: [PATCH] perf tools: Fix build errors with mipsel-linux-uclibc compiler Petri Gynther <pgynther@google.com> - 2015-10-06 00:00 +0200
      RE: [PATCH] perf tools: Fix build errors with mipsel-linux-uclibc  compiler Alexey Brodkin <Alexey.Brodkin@synopsys.com> - 2015-10-07 21:10 +0200
        Re: [PATCH] perf tools: Fix build errors with mipsel-linux-uclibc compiler Petri Gynther <pgynther@google.com> - 2015-10-15 00:00 +0200

#1239121 — Re: [PATCH] perf tools: Fix build errors with mipsel-linux-uclibc compiler

FromAlexey Brodkin <Alexey.Brodkin@synopsys.com>
Date2015-10-04 16:00 +0200
SubjectRe: [PATCH] perf tools: Fix build errors with mipsel-linux-uclibc compiler
Message-ID<qfRZw-27w-11@gated-at.bofh.it>
SGVsbG8gU3RlcGhhbmUsIEFybWFsZG8sDQoNCk9uIFR1ZSwgMjAxNS0wOS0yMiBhdCAwMDowNiAr
MDMwMCwgQWFybyBLb3NraW5lbiB3cm90ZToNCj4gSGksDQo+IA0KPiBPbiBNb24sIFNlcCAyMSwg
MjAxNSBhdCAwNDoyOTozOVBNICswMDAwLCBBbGV4ZXkgQnJvZGtpbiB3cm90ZToNCj4gPiA+IEVt
IEZyaSwgU2VwIDA0LCAyMDE1IGF0IDA0OjAxOjU0UE0gLTA3MDAsIFBldHJpIEd5bnRoZXIgZXNj
cmV2ZXU6DQo+ID4gPiA+IE9uIEZyaSwgU2VwIDQsIDIwMTUgYXQgMzo0OCBQTSwgQXJuYWxkbyBD
YXJ2YWxobyBkZSBNZWxvDQo+ID4gPiA+IDxhYy4uLkBrZXJuZWwub3JnPiB3cm90ZToNCj4gPiA+
ID4gPiBFbSBGcmksIFNlcCAwNCwgMjAxNSBhdCAwMzo0NTowM1BNIC0wNzAwLCBQZXRyaSBHeW50
aGVyIGVzY3JldmV1Og0KPiA+ID4gPiA+ID4gVGhpcyBjb21taXQgYnJlYWtzIHRoZSBwZXJmIHRv
b2wgTUlQUyBidWlsZCBiZWNhdXNlIE1JUFMgZG9lc24ndCBoYXZlDQo+ID4gPiA+ID4gPiBDT05G
SUdfUEVSRl9SRUdTPXkgaW4gLmNvbmZpZy1kZXRlY3RlZDoNCj4gPiA+ID4gPiA+IA0KPiA+ID4g
PiA+ID4gY29tbWl0IGJjYzg0ZWM2NWFkMWJkOWY3NzdhMWZhZGU2ZjhlNWUwYzU4MDhmYTUNCj4g
PiA+ID4gPiA+IEF1dGhvcjogU3RlcGhhbmUgRXJhbmlhbiA8ZXJhLi4uQGdvb2dsZS5jb20+DQo+
ID4gPiA+ID4gPiBEYXRlOiAgIE1vbiBBdWcgMzEgMTg6NDE6MTIgMjAxNSArMDIwMA0KPiA+ID4g
PiA+ID4gDQo+ID4gPiA+ID4gPiAgICAgcGVyZiByZWNvcmQ6IEFkZCBhYmlsaXR5IHRvIG5hbWUg
cmVnaXN0ZXJzIHRvIHJlY29yZA0KPiA+ID4gPiA+IA0KPiA+ID4gPiA+IFRoZXJlIHdhcyBhIGZp
eCBmb3IgYW5vdGhlciBhcmNoIHRoYXQgY2FtZSBhZnRlciB0aGlzIG9uZS4uIGhlcmUgaXQgaXMs
IGFscmVhZHkNCj4gPiA+ID4gPiB1cHN0cmVhbSwgY2FuIHlvdSB0YWtlIGEgbG9vaz8NCj4gPiA+
ID4gPiANCj4gPiA+ID4gPiBjb21taXQgYWY0YWVhZGQ4YzA0MzAzYzBhYTJkMTEyMTQ1YzM2Mjdl
MmViZDAyNg0KPiA+ID4gPiA+IEF1dGhvcjogU3RlcGhhbmUgRXJhbmlhbiA8ZXJhLi4uQGdvb2ds
ZS5jb20+DQo+ID4gPiA+ID4gRGF0ZTogICBUdWUgU2VwIDEgMTE6MzA6MTQgMjAxNSArMDIwMA0K
PiA+ID4gPiA+IA0KPiA+ID4gPiA+ICAgICBwZXJmIHRvb2xzOiBGaXggbGluayB0aW1lIGVycm9y
IHdpdGggc2FtcGxlX3JlZ19tYXNrcyBvbiBub24geDg2DQo+ID4gPiA+ID4gDQo+ID4gPiA+ID4g
ICAgIFRoaXMgcGF0Y2ggbWFrZXMgcGVyZiBjb21waWxlIG9uIG5vbiB4ODYgcGxhdGZvcm1zIGJ5
IGRlZmluaW5nIGEgd2Vhaw0KPiA+ID4gPiA+ICAgICBzeW1ib2wgZm9yIHNhbXBsZV9yZWdfbWFz
a3NbXSBpbiB1dGlsL3BlcmZfcmVncy5jLg0KPiA+ID4gPiA+IA0KPiA+ID4gPiA+ICAgICBUaGUg
cGF0Y2ggYWxzbyBtb3ZlcyB0aGUgUkVHKCkgYW5kIFJFR19FTkQoKSBtYWNyb3MgaW50byB0aGUN
Cj4gPiA+ID4gPiAgICAgdXRpbC9wZXJfcmVncy5oIGhlYWRlciBmaWxlLiBUaGUgbWFjcm9zIGFy
ZSByZW5hbWVkIHRvDQo+ID4gPiA+ID4gICAgIFNNUExfUkVHL1NNUExfUkVHX0VORCB0byBhdm9p
ZCBjbGFzaGVzIHdpdGggb3RoZXIgaGVhZGVyIGZpbGVzLg0KPiA+ID4gPiA+IA0KPiA+ID4gPiA+
IA0KPiA+ID4gPiANCj4gPiA+ID4gSSBoYXZlIHRoZSBhYm92ZSBjb21taXQgaW4gbXkgdHJlZSAo
YXMgSSBoYXZlIHRoZSBsYXRlc3QgTGludXMnIHRyZWUNCj4gPiA+ID4gYXMgb2YgcmlnaHQgbm93
KS4NCj4gPiA+ID4gVGhlIE1JUFMgYnVpbGQgaXMgc3RpbGwgYnJva2VuIGFzIEkgcmVwb3J0ZWQu
DQo+ID4gPiANCj4gPiA+IFN0ZXBoYW5lLCBjYW4geW91IHBsZWFzZSB0YWtlIGEgbG9vaz8NCj4g
PiANCj4gPiBUaGUgc2FtZSBwcm9ibGVtIGhhcHBlbnMgd2hlbiBidWlsZGluZyBwZXJmIG9uIEFS
Qy4NCj4gPiBJJ20gb24gNC4zLXJjMiBhbmQgdGhhdCdzIHdoYXQgSSBzZWU6DQo+ID4gLS0tLS0t
LS0tLS0tLS0tLS0tLT44LS0tLS0tLS0tLS0tLS0tLS0NCj4gPiAgIExJTksgICAgIC4uLi9saW51
eC00LjMtcmMyL3Rvb2xzL3BlcmYvcGVyZg0KPiA+IC4uLi9saW51eC00LjMtcmMyL3Rvb2xzL3Bl
cmYvbGlicGVyZi5hKGxpYnBlcmYtaW4ubyk6IEluIGZ1bmN0aW9uIGBwYXJzZV9yZWdzJzoNCj4g
PiAuLi4vbGludXgtNC4zLXJjMi90b29scy9wZXJmL3V0aWwvcGFyc2UtcmVncy1vcHRpb25zLmM6
Mjg6IHVuZGVmaW5lZCByZWZlcmVuY2UgdG8gYHNhbXBsZV9yZWdfbWFza3MnDQo+ID4gLi4uL2xp
bnV4LTQuMy1yYzIvdG9vbHMvcGVyZi91dGlsL3BhcnNlLXJlZ3Mtb3B0aW9ucy5jOjQ1OiB1bmRl
ZmluZWQgcmVmZXJlbmNlIHRvIGBzYW1wbGVfcmVnX21hc2tzJw0KPiA+IC4uLi9saW51eC00LjMt
cmMyL3Rvb2xzL3BlcmYvdXRpbC9wYXJzZS1yZWdzLW9wdGlvbnMuYzozODogdW5kZWZpbmVkIHJl
ZmVyZW5jZSB0byBgc2FtcGxlX3JlZ19tYXNrcycNCj4gPiBjb2xsZWN0MjogZXJyb3I6IGxkIHJl
dHVybmVkIDEgZXhpdCBzdGF0dXMNCj4gPiAtLS0tLS0tLS0tLS0tLS0tLS0tPjgtLS0tLS0tLS0t
LS0tLS0tLQ0KPiA+IA0KPiA+IEFueSBjaGFuY2UgZm9yIHRoaXMgdG8gYmUgZGlzY3Vzc2VkIGFu
eSBmdXJ0aGVyPw0KPiANCj4gQWxzbyAod2l0aCA0LjMtcmMyKSBvbiBQQS1SSVNDLCBQb3dlclBD
IGFuZCBTUEFSQyB0aGUgc2FtZSBlcnJvcnMgYXJlDQo+IHNlZW4uIDQuMiBidWlsZHMgZmluZS4N
Cg0KQW55IGNoYW5jZSB0byB0YWtlIGEgbG9vayBhdCB0aGlzIGlzc3VlPw0KDQpJdCdzIGFscmVh
ZHkgNC4zLXJjMyBzbyBpdCB3b3VsZCBiZSBuaWNlIHRvIGdldCBzb21lIGZpeCB0byB0cnkgc28g
dGhlcmUgd2lsbCBiZSB0aW1lDQp0byBtYWtlIHN1cmUgdGhhdCBuZXcgZml4IGRvZXNuJ3QgYnJl
YWsgc3R1ZmYgZm9yIG90aGVyIGFyY2hlcy4NCg0KUmVnYXJkcywNCkFsZXhleQ==
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1239984 — Re: [PATCH] perf tools: Fix build errors with mipsel-linux-uclibc compiler

FromPetri Gynther <pgynther@google.com>
Date2015-10-06 00:00 +0200
SubjectRe: [PATCH] perf tools: Fix build errors with mipsel-linux-uclibc compiler
Message-ID<qglXA-37e-7@gated-at.bofh.it>
In reply to#1239121
On Sun, Oct 4, 2015 at 6:53 AM, Alexey Brodkin
<Alexey.Brodkin@synopsys.com> wrote:
> Hello Stephane, Armaldo,
>
> On Tue, 2015-09-22 at 00:06 +0300, Aaro Koskinen wrote:
>> Hi,
>>
>> On Mon, Sep 21, 2015 at 04:29:39PM +0000, Alexey Brodkin wrote:
>> > > Em Fri, Sep 04, 2015 at 04:01:54PM -0700, Petri Gynther escreveu:
>> > > > On Fri, Sep 4, 2015 at 3:48 PM, Arnaldo Carvalho de Melo
>> > > > <ac...@kernel.org> wrote:
>> > > > > Em Fri, Sep 04, 2015 at 03:45:03PM -0700, Petri Gynther escreveu:
>> > > > > > This commit breaks the perf tool MIPS build because MIPS doesn't have
>> > > > > > CONFIG_PERF_REGS=y in .config-detected:
>> > > > > >
>> > > > > > commit bcc84ec65ad1bd9f777a1fade6f8e5e0c5808fa5
>> > > > > > Author: Stephane Eranian <era...@google.com>
>> > > > > > Date:   Mon Aug 31 18:41:12 2015 +0200
>> > > > > >
>> > > > > >     perf record: Add ability to name registers to record
>> > > > >
>> > > > > There was a fix for another arch that came after this one.. here it is, already
>> > > > > upstream, can you take a look?
>> > > > >
>> > > > > commit af4aeadd8c04303c0aa2d112145c3627e2ebd026
>> > > > > Author: Stephane Eranian <era...@google.com>
>> > > > > Date:   Tue Sep 1 11:30:14 2015 +0200
>> > > > >
>> > > > >     perf tools: Fix link time error with sample_reg_masks on non x86
>> > > > >
>> > > > >     This patch makes perf compile on non x86 platforms by defining a weak
>> > > > >     symbol for sample_reg_masks[] in util/perf_regs.c.
>> > > > >
>> > > > >     The patch also moves the REG() and REG_END() macros into the
>> > > > >     util/per_regs.h header file. The macros are renamed to
>> > > > >     SMPL_REG/SMPL_REG_END to avoid clashes with other header files.
>> > > > >
>> > > > >
>> > > >
>> > > > I have the above commit in my tree (as I have the latest Linus' tree
>> > > > as of right now).
>> > > > The MIPS build is still broken as I reported.
>> > >
>> > > Stephane, can you please take a look?
>> >
>> > The same problem happens when building perf on ARC.
>> > I'm on 4.3-rc2 and that's what I see:
>> > ------------------->8-----------------
>> >   LINK     .../linux-4.3-rc2/tools/perf/perf
>> > .../linux-4.3-rc2/tools/perf/libperf.a(libperf-in.o): In function `parse_regs':
>> > .../linux-4.3-rc2/tools/perf/util/parse-regs-options.c:28: undefined reference to `sample_reg_masks'
>> > .../linux-4.3-rc2/tools/perf/util/parse-regs-options.c:45: undefined reference to `sample_reg_masks'
>> > .../linux-4.3-rc2/tools/perf/util/parse-regs-options.c:38: undefined reference to `sample_reg_masks'
>> > collect2: error: ld returned 1 exit status
>> > ------------------->8-----------------
>> >
>> > Any chance for this to be discussed any further?
>>
>> Also (with 4.3-rc2) on PA-RISC, PowerPC and SPARC the same errors are
>> seen. 4.2 builds fine.
>
> Any chance to take a look at this issue?
>
> It's already 4.3-rc3 so it would be nice to get some fix to try so there will be time
> to make sure that new fix doesn't break stuff for other arches.
>
> Regards,
> Alexey

I'd suggest to revert these two commits in Linus' tree:

commit af4aeadd8c04303c0aa2d112145c3627e2ebd026
Author: Stephane Eranian <eranian@google.com>
Date:   Tue Sep 1 11:30:14 2015 +0200

    perf tools: Fix link time error with sample_reg_masks on non x86

commit bcc84ec65ad1bd9f777a1fade6f8e5e0c5808fa5
Author: Stephane Eranian <eranian@google.com>
Date:   Mon Aug 31 18:41:12 2015 +0200

    perf record: Add ability to name registers to record

until this is figured out and tested for multiple architectures.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1241738

FromAlexey Brodkin <Alexey.Brodkin@synopsys.com>
Date2015-10-07 21:10 +0200
Message-ID<qh2ga-5nJ-13@gated-at.bofh.it>
In reply to#1239984
Hi Petri,

> I'd suggest to revert these two commits in Linus' tree:
> 
> commit af4aeadd8c04303c0aa2d112145c3627e2ebd026
> Author: Stephane Eranian <eranian@google.com>
> Date:   Tue Sep 1 11:30:14 2015 +0200
> 
>     perf tools: Fix link time error with sample_reg_masks on non x86
> 
> commit bcc84ec65ad1bd9f777a1fade6f8e5e0c5808fa5
> Author: Stephane Eranian <eranian@google.com>
> Date:   Mon Aug 31 18:41:12 2015 +0200
> 
>     perf record: Add ability to name registers to record
> 
> until this is figured out and tested for multiple architectures.

Looks like that problem is already solved in linux-next.
See this commit - http://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/tools/perf?id=eb56db54326f910348defbee2803ec0675a664b2

At least for me on ARC latest Linus' tree + this patch cherry-picked allows to build
perf perfectly fine.

-Alexey--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1247215 — Re: [PATCH] perf tools: Fix build errors with mipsel-linux-uclibc compiler

FromPetri Gynther <pgynther@google.com>
Date2015-10-15 00:00 +0200
SubjectRe: [PATCH] perf tools: Fix build errors with mipsel-linux-uclibc compiler
Message-ID<qjCfw-2ZW-7@gated-at.bofh.it>
In reply to#1241738
On Wed, Oct 7, 2015 at 11:58 AM, Alexey Brodkin
<Alexey.Brodkin@synopsys.com> wrote:
> Hi Petri,
>
>> I'd suggest to revert these two commits in Linus' tree:
>>
>> commit af4aeadd8c04303c0aa2d112145c3627e2ebd026
>> Author: Stephane Eranian <eranian@google.com>
>> Date:   Tue Sep 1 11:30:14 2015 +0200
>>
>>     perf tools: Fix link time error with sample_reg_masks on non x86
>>
>> commit bcc84ec65ad1bd9f777a1fade6f8e5e0c5808fa5
>> Author: Stephane Eranian <eranian@google.com>
>> Date:   Mon Aug 31 18:41:12 2015 +0200
>>
>>     perf record: Add ability to name registers to record
>>
>> until this is figured out and tested for multiple architectures.
>
> Looks like that problem is already solved in linux-next.
> See this commit - http://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/tools/perf?id=eb56db54326f910348defbee2803ec0675a664b2
>
> At least for me on ARC latest Linus' tree + this patch cherry-picked allows to build
> perf perfectly fine.
>

This patch is now in v4.3-rc5, and perf build for MIPS works fine. Thanks.

> -Alexey
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web