Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1239853 > unrolled thread

[PATCH] usb: remove unnecessary CONFIG_PM dependency from USB_OTG

Back to article view | Back to linux.kernel

Contents

  [PATCH] usb: remove unnecessary CONFIG_PM dependency from USB_OTG Nathan Sullivan <nathan.sullivan@ni.com> - 2015-10-05 21:20 +0200
    Re: [PATCH] usb: remove unnecessary CONFIG_PM dependency from USB_OTG Felipe Balbi <balbi@ti.com> - 2015-10-05 21:40 +0200
      Re: [PATCH] usb: remove unnecessary CONFIG_PM dependency from USB_OTG Nathan Sullivan <nathan.sullivan@ni.com> - 2015-10-05 23:20 +0200

#1239853 — [PATCH] usb: remove unnecessary CONFIG_PM dependency from USB_OTG

From: Ben Shelton <ben.shelton@ni.com>

The USB gadget support currently depends on power management
(CONFIG_PM) being enabled, but does not actually need it enabled.
Remove this dependency.

Tested on Bay Trail hardware with dwc3 USB.

Signed-off-by: Nathan Sullivan <nathan.sullivan@ni.com>
---
 drivers/usb/core/Kconfig |    1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/usb/core/Kconfig b/drivers/usb/core/Kconfig
index a99c89e..9c5cdf3 100644
--- a/drivers/usb/core/Kconfig
+++ b/drivers/usb/core/Kconfig
@@ -43,7 +43,6 @@ config USB_DYNAMIC_MINORS
 
 config USB_OTG
 	bool "OTG support"
-	depends on PM
 	default n
 	help
 	  The most notable feature of USB OTG is support for a
-- 
1.7.10.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1239865

[Multipart message — attachments visible in raw view] — view raw

Nathan Sullivan <nathan.sullivan@ni.com> writes:

> From: Ben Shelton <ben.shelton@ni.com>
>
> The USB gadget support currently depends on power management
> (CONFIG_PM) being enabled, but does not actually need it enabled.
> Remove this dependency.
>
> Tested on Bay Trail hardware with dwc3 USB.
>
> Signed-off-by: Nathan Sullivan <nathan.sullivan@ni.com>
> ---
>  drivers/usb/core/Kconfig |    1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/usb/core/Kconfig b/drivers/usb/core/Kconfig
> index a99c89e..9c5cdf3 100644
> --- a/drivers/usb/core/Kconfig
> +++ b/drivers/usb/core/Kconfig
> @@ -43,7 +43,6 @@ config USB_DYNAMIC_MINORS
>  
>  config USB_OTG
>  	bool "OTG support"
> -	depends on PM

IIRC we had this dependency because OTG needs support USB bus suspend
and afaict, that's only available on PM builds

-- 
balbi

[toc] | [prev] | [next] | [standalone]

#1239977

On Mon, Oct 05, 2015 at 02:33:56PM -0500, Felipe Balbi wrote:
> 
> IIRC we had this dependency because OTG needs support USB bus suspend
> and afaict, that's only available on PM builds
> 
> -- 
> balbi

Hmm, our use case is separate device and host controllers on a Bay Trail
system.  We don't ever need to suspend the bus, since the roles are fixed.
Also, the system is running RT tasks and we don't want PM on.

Maybe the device-side USB option should be separate from the OTG option?  We
really don't want HNP or any of the dual-role features, just support for
gadget drivers and USB device controllers.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web