Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1239495 > unrolled thread

[PATCH v7 1/2] efi: export efi_capsule_supported() function symbol

Started by"Kweh, Hock Leong" <hock.leong.kweh@intel.com>
First post2015-10-05 14:20 +0200
Last post2015-10-11 21:10 +0200
Articles 11 — 4 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH v7 1/2] efi: export efi_capsule_supported() function symbol "Kweh, Hock Leong" <hock.leong.kweh@intel.com> - 2015-10-05 14:20 +0200
    Re: [PATCH v7 1/2] efi: export efi_capsule_supported() function  symbol Borislav Petkov <bp@alien8.de> - 2015-10-05 15:20 +0200
      RE: [PATCH v7 1/2] efi: export efi_capsule_supported() function  symbol "Kweh, Hock Leong" <hock.leong.kweh@intel.com> - 2015-10-05 17:20 +0200
        Re: [PATCH v7 1/2] efi: export efi_capsule_supported() function symbol Bryan O'Donoghue <pure.logic@nexus-software.ie> - 2015-10-05 23:30 +0200
          RE: [PATCH v7 1/2] efi: export efi_capsule_supported() function  symbol "Kweh, Hock Leong" <hock.leong.kweh@intel.com> - 2015-10-06 13:00 +0200
            Re: [PATCH v7 1/2] efi: export efi_capsule_supported() function symbol Bryan O'Donoghue <pure.logic@nexus-software.ie> - 2015-10-06 17:00 +0200
              RE: [PATCH v7 1/2] efi: export efi_capsule_supported() function  symbol "Kweh, Hock Leong" <hock.leong.kweh@intel.com> - 2015-10-07 04:10 +0200
                Re: [PATCH v7 1/2] efi: export efi_capsule_supported() function symbol Bryan O'Donoghue <pure.logic@nexus-software.ie> - 2015-10-07 10:30 +0200
      Re: [PATCH v7 1/2] efi: export efi_capsule_supported() function  symbol Matt Fleming <matt@console-pimps.org> - 2015-10-11 00:10 +0200
        RE: [PATCH v7 1/2] efi: export efi_capsule_supported() function  symbol "Kweh, Hock Leong" <hock.leong.kweh@intel.com> - 2015-10-11 16:30 +0200
          Re: [PATCH v7 1/2] efi: export efi_capsule_supported() function  symbol Matt Fleming <matt@console-pimps.org> - 2015-10-11 21:10 +0200

#1239495 — [PATCH v7 1/2] efi: export efi_capsule_supported() function symbol

From"Kweh, Hock Leong" <hock.leong.kweh@intel.com>
Date2015-10-05 14:20 +0200
Subject[PATCH v7 1/2] efi: export efi_capsule_supported() function symbol
Message-ID<qgcUh-73G-17@gated-at.bofh.it>
From: "Kweh, Hock Leong" <hock.leong.kweh@intel.com>

This patch export efi_capsule_supported() function symbol for capsule
kernel module to use.

Cc: Matt Fleming <matt.fleming@intel.com>
Signed-off-by: Kweh, Hock Leong <hock.leong.kweh@intel.com>
---
 drivers/firmware/efi/capsule.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/firmware/efi/capsule.c b/drivers/firmware/efi/capsule.c
index d8cd75c0..738d437 100644
--- a/drivers/firmware/efi/capsule.c
+++ b/drivers/firmware/efi/capsule.c
@@ -101,6 +101,7 @@ out:
 	kfree(capsule);
 	return rv;
 }
+EXPORT_SYMBOL_GPL(efi_capsule_supported);
 
 /**
  * efi_capsule_update - send a capsule to the firmware
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1239544 — Re: [PATCH v7 1/2] efi: export efi_capsule_supported() function symbol

FromBorislav Petkov <bp@alien8.de>
Date2015-10-05 15:20 +0200
SubjectRe: [PATCH v7 1/2] efi: export efi_capsule_supported() function symbol
Message-ID<qgdQm-8oB-13@gated-at.bofh.it>
In reply to#1239495
On Tue, Oct 06, 2015 at 04:15:54AM +0800, Kweh, Hock Leong wrote:
> From: "Kweh, Hock Leong" <hock.leong.kweh@intel.com>
> 
> This patch export efi_capsule_supported() function symbol for capsule
> kernel module to use.
> 
> Cc: Matt Fleming <matt.fleming@intel.com>
> Signed-off-by: Kweh, Hock Leong <hock.leong.kweh@intel.com>
> ---
>  drivers/firmware/efi/capsule.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/firmware/efi/capsule.c b/drivers/firmware/efi/capsule.c
> index d8cd75c0..738d437 100644
> --- a/drivers/firmware/efi/capsule.c
> +++ b/drivers/firmware/efi/capsule.c
> @@ -101,6 +101,7 @@ out:
>  	kfree(capsule);
>  	return rv;
>  }
> +EXPORT_SYMBOL_GPL(efi_capsule_supported);

So this one is still a separate patch.

If you're going to ignore review comments, maybe I should stop wasting
my time reviewing your stuff...

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1239658 — RE: [PATCH v7 1/2] efi: export efi_capsule_supported() function symbol

From"Kweh, Hock Leong" <hock.leong.kweh@intel.com>
Date2015-10-05 17:20 +0200
SubjectRE: [PATCH v7 1/2] efi: export efi_capsule_supported() function symbol
Message-ID<qgfIv-2DV-39@gated-at.bofh.it>
In reply to#1239544
PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBCb3Jpc2xhdiBQZXRrb3YgW21h
aWx0bzpicEBhbGllbjguZGVdDQo+IFNlbnQ6IE1vbmRheSwgT2N0b2JlciAwNSwgMjAxNSA5OjE0
IFBNDQo+IA0KPiBTbyB0aGlzIG9uZSBpcyBzdGlsbCBhIHNlcGFyYXRlIHBhdGNoLg0KPiANCj4g
SWYgeW91J3JlIGdvaW5nIHRvIGlnbm9yZSByZXZpZXcgY29tbWVudHMsIG1heWJlIEkgc2hvdWxk
IHN0b3Agd2FzdGluZyBteQ0KPiB0aW1lIHJldmlld2luZyB5b3VyIHN0dWZmLi4uDQo+IA0KPiAt
LQ0KPiBSZWdhcmRzL0dydXNzLA0KPiAgICAgQm9yaXMuDQoNCkFscmVhZHkgZm9sbG93IHdoYXQg
eW91IGhhdmUgc3VnZ2VzdGVkLCBwdXQgYSBub3RlIHVuZGVyIC0tLSBsaW5lOg0KaHR0cHM6Ly9s
a21sLm9yZy9sa21sLzIwMTUvMTAvNS8yMzAgKGF0IGxpbmUgMjUgLSAyNykNCg0KVGhhbmtzIGZv
ciB0aGUgcmV2aWV3IGNvbW1lbnRzLg0KDQoNClJlZ2FyZHMsDQpXaWxzb24NCg==
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1239978

FromBryan O'Donoghue <pure.logic@nexus-software.ie>
Date2015-10-05 23:30 +0200
Message-ID<qgluy-2zc-11@gated-at.bofh.it>
In reply to#1239658
On 05/10/15 16:19, Kweh, Hock Leong wrote:
>> -----Original Message-----
>> From: Borislav Petkov [mailto:bp@alien8.de]
>> Sent: Monday, October 05, 2015 9:14 PM
>>
>> So this one is still a separate patch.
>>
>> If you're going to ignore review comments, maybe I should stop wasting my
>> time reviewing your stuff...
>>
>> --
>> Regards/Gruss,
>>      Boris.
>
> Already follow what you have suggested, put a note under --- line:
> https://lkml.org/lkml/2015/10/5/230 (at line 25 - 27)
>
> Thanks for the review comments.

Wilson - trying to test this out on a Galileo Gen2 - which branch are 
you doing this against ?

I can apply the first patch you're proposing to squash your commit into

https://lkml.org/lkml/diff/2014/10/7/390/1

but then trying to apply the first in your series on top of that patch I get

deckard@aineko:~/Development/linux$ git apply 
../patches/capsule_wilson/1_2.eml
../patches/capsule_wilson/1_2.eml:72: trailing whitespace.
EXPORT_SYMBOL_GPL(efi_capsule_supported);
error: drivers/firmware/efi/capsule.c: No such file or directory

https://kernel.googlesource.com/pub/scm/linux/kernel/git/mfleming/efi/+/capsule/drivers/firmware/efi/capsule.c 


??

If so - then why not use the interface here ?
https://kernel.googlesource.com/pub/scm/linux/kernel/git/mfleming/efi/+/capsule

(Sorry I know I'm coming to this thread late)

Aside from that, I'm curious which types of capsules you've used here 
too - does it include the MFH header ? Keep in mind the initial firmware 
that shipped with Galileo will depend on that MFH being present.

http://download.intel.com/support/processors/quark/sb/quark_securebootprm_330234_001.pdf 
- Section A1 - table 7 ?

So if we boot a 4.x kernel with that initial firmware version 0.75 if 
memory serves - it's important that the capsule.c code handles the MFH.

--
BOD


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1240365 — RE: [PATCH v7 1/2] efi: export efi_capsule_supported() function symbol

From"Kweh, Hock Leong" <hock.leong.kweh@intel.com>
Date2015-10-06 13:00 +0200
SubjectRE: [PATCH v7 1/2] efi: export efi_capsule_supported() function symbol
Message-ID<qgy8q-3Vv-13@gated-at.bofh.it>
In reply to#1239978
PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBCcnlhbiBPJ0Rvbm9naHVlIFtt
YWlsdG86cHVyZS5sb2dpY0BuZXh1cy1zb2Z0d2FyZS5pZV0NCj4gU2VudDogVHVlc2RheSwgT2N0
b2JlciAwNiwgMjAxNSA1OjI3IEFNDQo+IA0KPiBXaWxzb24gLSB0cnlpbmcgdG8gdGVzdCB0aGlz
IG91dCBvbiBhIEdhbGlsZW8gR2VuMiAtIHdoaWNoIGJyYW5jaCBhcmUgeW91IGRvaW5nDQo+IHRo
aXMgYWdhaW5zdCA/DQo+IA0KPiBJIGNhbiBhcHBseSB0aGUgZmlyc3QgcGF0Y2ggeW91J3JlIHBy
b3Bvc2luZyB0byBzcXVhc2ggeW91ciBjb21taXQgaW50bw0KPiANCj4gaHR0cHM6Ly9sa21sLm9y
Zy9sa21sL2RpZmYvMjAxNC8xMC83LzM5MC8xDQo+IA0KPiBidXQgdGhlbiB0cnlpbmcgdG8gYXBw
bHkgdGhlIGZpcnN0IGluIHlvdXIgc2VyaWVzIG9uIHRvcCBvZiB0aGF0IHBhdGNoIEkgZ2V0DQo+
IA0KPiBkZWNrYXJkQGFpbmVrbzp+L0RldmVsb3BtZW50L2xpbnV4JCBnaXQNCj4gYXBwbHkgLi4v
cGF0Y2hlcy9jYXBzdWxlX3dpbHNvbi8xXzIuZW1sDQo+IC4uL3BhdGNoZXMvY2Fwc3VsZV93aWxz
b24vMV8yLmVtbDo3MjogdHJhaWxpbmcgd2hpdGVzcGFjZS4NCj4gRVhQT1JUX1NZTUJPTF9HUEwo
ZWZpX2NhcHN1bGVfc3VwcG9ydGVkKTsNCj4gZXJyb3I6IGRyaXZlcnMvZmlybXdhcmUvZWZpL2Nh
cHN1bGUuYzogTm8gc3VjaCBmaWxlIG9yIGRpcmVjdG9yeQ0KPiANCj4gaHR0cHM6Ly9rZXJuZWwu
Z29vZ2xlc291cmNlLmNvbS9wdWIvc2NtL2xpbnV4L2tlcm5lbC9naXQvbWZsZW1pbmcvZWZpLysv
DQo+IGNhcHN1bGUvZHJpdmVycy9maXJtd2FyZS9lZmkvY2Fwc3VsZS5jDQo+IA0KPiANCj4gPz8N
Cg0KSWYgeW91IGFyZSBhcHBseWluZyBNYXR0J3MgcGF0Y2ggaHR0cHM6Ly9sa21sLm9yZy9sa21s
L2RpZmYvMjAxNC8xMC83LzM5MC8xIHdoaWNoDQpoYWQgYmVlbiBjcmVhdGVkIDEgeWVhciBhZ28g
dG8gbWFpbmxpbmUgdmFuaWxsYSBrZXJuZWwgKExpbnV4IDQuMy1yYzQpLCB5b3UgYXJlIG5vdA0K
YWJsZSB0byBkaXJlY3QgcGF0Y2ggaW4gZHVlIHRvIHRoZSBNYWtlZmlsZSBlcnJvciBiZWxvdzoN
Cg0Kfi9NeVdvcmtzL2xpbnV4X21haW5saW5lJCBnaXQgYXBwbHkgLmdpdC9yZWJhc2UtYXBwbHkv
MDAwMSAtLXJlamVjdCANCkNoZWNraW5nIHBhdGNoIGFyY2gveDg2L2tlcm5lbC9yZWJvb3QuYy4u
Lg0KSHVuayAjMSBzdWNjZWVkZWQgYXQgNTI3IChvZmZzZXQgMTEgbGluZXMpLg0KQ2hlY2tpbmcg
cGF0Y2ggZHJpdmVycy9maXJtd2FyZS9lZmkvTWFrZWZpbGUuLi4NCmVycm9yOiB3aGlsZSBzZWFy
Y2hpbmcgZm9yOg0KIw0KIyBNYWtlZmlsZSBmb3IgbGludXgga2VybmVsDQojDQpvYmotJChDT05G
SUdfRUZJKSAgICAgICAgICAgICAgICAgICAgICAgKz0gZWZpLm8gdmFycy5vIHJlYm9vdC5vDQpv
YmotJChDT05GSUdfRUZJX1ZBUlMpICAgICAgICAgICAgICAgICAgKz0gZWZpdmFycy5vDQpvYmot
JChDT05GSUdfRUZJX1ZBUlNfUFNUT1JFKSAgICAgICAgICAgKz0gZWZpLXBzdG9yZS5vDQpvYmot
JChDT05GSUdfVUVGSV9DUEVSKSAgICAgICAgICAgICAgICAgKz0gY3Blci5vDQogDQplcnJvcjog
cGF0Y2ggZmFpbGVkOiBkcml2ZXJzL2Zpcm13YXJlL2VmaS9NYWtlZmlsZToxDQpDaGVja2luZyBw
YXRjaCBkcml2ZXJzL2Zpcm13YXJlL2VmaS9jYXBzdWxlLmMuLi4NCkNoZWNraW5nIHBhdGNoIGRy
aXZlcnMvZmlybXdhcmUvZWZpL3JlYm9vdC5jLi4uDQpDaGVja2luZyBwYXRjaCBpbmNsdWRlL2xp
bnV4L2VmaS5oLi4uDQpIdW5rICMxIHN1Y2NlZWRlZCBhdCAxMjIgKG9mZnNldCAzIGxpbmVzKS4N
Ckh1bmsgIzIgc3VjY2VlZGVkIGF0IDk4MyAob2Zmc2V0IDIzIGxpbmVzKS4NCkh1bmsgIzMgc3Vj
Y2VlZGVkIGF0IDEyMzUgKG9mZnNldCAyMyBsaW5lcykuDQpIdW5rICM0IHN1Y2NlZWRlZCBhdCAx
MzE3IChvZmZzZXQgMjMgbGluZXMpLg0KQXBwbGllZCBwYXRjaCBhcmNoL3g4Ni9rZXJuZWwvcmVi
b290LmMgY2xlYW5seS4NCkFwcGx5aW5nIHBhdGNoIGRyaXZlcnMvZmlybXdhcmUvZWZpL01ha2Vm
aWxlIHdpdGggMSByZWplY3RzLi4uDQpSZWplY3RlZCBodW5rICMxLg0KQXBwbGllZCBwYXRjaCBk
cml2ZXJzL2Zpcm13YXJlL2VmaS9jYXBzdWxlLmMgY2xlYW5seS4NCkFwcGxpZWQgcGF0Y2ggZHJp
dmVycy9maXJtd2FyZS9lZmkvcmVib290LmMgY2xlYW5seS4NCkFwcGxpZWQgcGF0Y2ggaW5jbHVk
ZS9saW51eC9lZmkuaCBjbGVhbmx5Lg0KDQpZb3Ugc2hvdWxkIHJlc29sdmUgdGhlIE1ha2VmaWxl
IGVycm9yIGFuZCB0aGVuIGdpdCBhZGQgNSBmaWxlcyBiZWxvdzoNCi0gYXJjaC94ODYva2VybmVs
L3JlYm9vdC5jDQotIGRyaXZlcnMvZmlybXdhcmUvZWZpL01ha2VmaWxlDQotIGRyaXZlcnMvZmly
bXdhcmUvZWZpL3JlYm9vdC5jDQotIGluY2x1ZGUvbGludXgvZWZpLmgNCi0gZHJpdmVycy9maXJt
d2FyZS9lZmkvY2Fwc3VsZS5jDQoNCnRoZW4geW91IGFyZSBhYmxlIHRvIHBhdGNoIGluIG15IHBh
dGNoc2V0Lg0KDQo+IA0KPiBJZiBzbyAtIHRoZW4gd2h5IG5vdCB1c2UgdGhlIGludGVyZmFjZSBo
ZXJlID8NCj4gaHR0cHM6Ly9rZXJuZWwuZ29vZ2xlc291cmNlLmNvbS9wdWIvc2NtL2xpbnV4L2tl
cm5lbC9naXQvbWZsZW1pbmcvZWZpLysvDQo+IGNhcHN1bGUNCj4gDQo+IChTb3JyeSBJIGtub3cg
SSdtIGNvbWluZyB0byB0aGlzIHRocmVhZCBsYXRlKQ0KPiANCj4gQXNpZGUgZnJvbSB0aGF0LCBJ
J20gY3VyaW91cyB3aGljaCB0eXBlcyBvZiBjYXBzdWxlcyB5b3UndmUgdXNlZCBoZXJlIHRvbyAt
DQo+IGRvZXMgaXQgaW5jbHVkZSB0aGUgTUZIIGhlYWRlciA/IEtlZXAgaW4gbWluZCB0aGUgaW5p
dGlhbCBmaXJtd2FyZSB0aGF0DQo+IHNoaXBwZWQgd2l0aCBHYWxpbGVvIHdpbGwgZGVwZW5kIG9u
IHRoYXQgTUZIIGJlaW5nIHByZXNlbnQuDQo+IA0KPiBodHRwOi8vZG93bmxvYWQuaW50ZWwuY29t
L3N1cHBvcnQvcHJvY2Vzc29ycy9xdWFyay9zYi9xdWFya19zZWN1cmVib290DQo+IHBybV8zMzAy
MzRfMDAxLnBkZg0KPiAtIFNlY3Rpb24gQTEgLSB0YWJsZSA3ID8NCj4gDQo+IFNvIGlmIHdlIGJv
b3QgYSA0Lngga2VybmVsIHdpdGggdGhhdCBpbml0aWFsIGZpcm13YXJlIHZlcnNpb24gMC43NSBp
ZiBtZW1vcnkNCj4gc2VydmVzIC0gaXQncyBpbXBvcnRhbnQgdGhhdCB0aGUgY2Fwc3VsZS5jIGNv
ZGUgaGFuZGxlcyB0aGUgTUZILg0KPiANCg0KQWxyZWFkeSBnb3QgYWdyZWVtZW50IHdpdGggTWF0
dCB0aGF0IFF1YXJrIFNlY3VyaXR5IEhlYWRlciBwYXRjaCB3aWxsIG5vdA0KYmUgdXBzdHJlYW0g
dG8gbWFpbmxpbmUgYXMgaXQgaXMgbm90IGEgc3RhbmRhcmQgaGVhZGVyLiBTbyBJbnRlbCB3aWxs
IGNhcnJ5IHRoaXMNCnBhdGNoIG91cnNlbHZlcy4NCg0KDQpUaGFua3MgJiBSZWdhcmRzLA0KV2ls
c29uDQo=
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1240524

FromBryan O'Donoghue <pure.logic@nexus-software.ie>
Date2015-10-06 17:00 +0200
Message-ID<qgBSG-PD-17@gated-at.bofh.it>
In reply to#1240365
On 06/10/15 11:53, Kweh, Hock Leong wrote:
>> -----Original Message-----
>> From: Bryan O'Donoghue [mailto:pure.logic@nexus-software.ie]
>> Sent: Tuesday, October 06, 2015 5:27 AM
>>
>> Wilson - trying to test this out on a Galileo Gen2 - which branch are you doing
>> this against ?
>>
>> I can apply the first patch you're proposing to squash your commit into
>>
>> https://lkml.org/lkml/diff/2014/10/7/390/1
>>
>> but then trying to apply the first in your series on top of that patch I get
>>
>> deckard@aineko:~/Development/linux$ git
>> apply ../patches/capsule_wilson/1_2.eml
>> ../patches/capsule_wilson/1_2.eml:72: trailing whitespace.
>> EXPORT_SYMBOL_GPL(efi_capsule_supported);
>> error: drivers/firmware/efi/capsule.c: No such file or directory
>>
>> https://kernel.googlesource.com/pub/scm/linux/kernel/git/mfleming/efi/+/
>> capsule/drivers/firmware/efi/capsule.c
>>
>>
>> ??
>
> If you are applying Matt's patch https://lkml.org/lkml/diff/2014/10/7/390/1 which
> had been created 1 year ago to mainline vanilla kernel (Linux 4.3-rc4), you are not
> able to direct patch in due to the Makefile error below:
>
> ~/MyWorks/linux_mainline$ git apply .git/rebase-apply/0001 --reject
> Checking patch arch/x86/kernel/reboot.c...
> Hunk #1 succeeded at 527 (offset 11 lines).
> Checking patch drivers/firmware/efi/Makefile...
> error: while searching for:
> #
> # Makefile for linux kernel
> #
> obj-$(CONFIG_EFI)                       += efi.o vars.o reboot.o
> obj-$(CONFIG_EFI_VARS)                  += efivars.o
> obj-$(CONFIG_EFI_VARS_PSTORE)           += efi-pstore.o
> obj-$(CONFIG_UEFI_CPER)                 += cper.o
>
> error: patch failed: drivers/firmware/efi/Makefile:1
> Checking patch drivers/firmware/efi/capsule.c...
> Checking patch drivers/firmware/efi/reboot.c...
> Checking patch include/linux/efi.h...
> Hunk #1 succeeded at 122 (offset 3 lines).
> Hunk #2 succeeded at 983 (offset 23 lines).
> Hunk #3 succeeded at 1235 (offset 23 lines).
> Hunk #4 succeeded at 1317 (offset 23 lines).
> Applied patch arch/x86/kernel/reboot.c cleanly.
> Applying patch drivers/firmware/efi/Makefile with 1 rejects...
> Rejected hunk #1.
> Applied patch drivers/firmware/efi/capsule.c cleanly.
> Applied patch drivers/firmware/efi/reboot.c cleanly.
> Applied patch include/linux/efi.h cleanly.
>
> You should resolve the Makefile error and then git add 5 files below:
> - arch/x86/kernel/reboot.c
> - drivers/firmware/efi/Makefile
> - drivers/firmware/efi/reboot.c
> - include/linux/efi.h
> - drivers/firmware/efi/capsule.c
>
> then you are able to patch in my patchset.
>
>>
>> If so - then why not use the interface here ?
>> https://kernel.googlesource.com/pub/scm/linux/kernel/git/mfleming/efi/+/
>> capsule
>>
>> (Sorry I know I'm coming to this thread late)
>>
>> Aside from that, I'm curious which types of capsules you've used here too -
>> does it include the MFH header ? Keep in mind the initial firmware that
>> shipped with Galileo will depend on that MFH being present.
>>
>> http://download.intel.com/support/processors/quark/sb/quark_secureboot
>> prm_330234_001.pdf
>> - Section A1 - table 7 ?
>>
>> So if we boot a 4.x kernel with that initial firmware version 0.75 if memory
>> serves - it's important that the capsule.c code handles the MFH.
>>
>
> Already got agreement with Matt that Quark Security Header patch will not
> be upstream to mainline as it is not a standard header. So Intel will carry this
> patch ourselves.

Right... so what sort of capsule are you testing with ?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1241122 — RE: [PATCH v7 1/2] efi: export efi_capsule_supported() function symbol

From"Kweh, Hock Leong" <hock.leong.kweh@intel.com>
Date2015-10-07 04:10 +0200
SubjectRE: [PATCH v7 1/2] efi: export efi_capsule_supported() function symbol
Message-ID<qgMl3-7I4-3@gated-at.bofh.it>
In reply to#1240524
> -----Original Message-----
> From: Bryan O'Donoghue [mailto:pure.logic@nexus-software.ie]
> Sent: Tuesday, October 06, 2015 10:54 PM
> >>
> >> Aside from that, I'm curious which types of capsules you've used here
> >> too - does it include the MFH header ? Keep in mind the initial
> >> firmware that shipped with Galileo will depend on that MFH being
> present.
> >>
> >>
> http://download.intel.com/support/processors/quark/sb/quark_secureboo
> >> t
> >> prm_330234_001.pdf
> >> - Section A1 - table 7 ?
> >>
> >> So if we boot a 4.x kernel with that initial firmware version 0.75 if
> >> memory serves - it's important that the capsule.c code handles the MFH.
> >>
> >
> > Already got agreement with Matt that Quark Security Header patch will
> > not be upstream to mainline as it is not a standard header. So Intel
> > will carry this patch ourselves.
> 
> Right... so what sort of capsule are you testing with ?

I am testing on Intel Galileo Gen 1 with bios version v0.7.5, v0.8.0, v1.0.1 & v1.0.2.

Thanks & Regards,
Wilson
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1241229

FromBryan O'Donoghue <pure.logic@nexus-software.ie>
Date2015-10-07 10:30 +0200
Message-ID<qgSgO-7JK-9@gated-at.bofh.it>
In reply to#1241122
On 07/10/15 03:01, Kweh, Hock Leong wrote:
>> -----Original Message-----
>> From: Bryan O'Donoghue [mailto:pure.logic@nexus-software.ie]
>> Sent: Tuesday, October 06, 2015 10:54 PM
>>>>
>>>> Aside from that, I'm curious which types of capsules you've used here
>>>> too - does it include the MFH header ? Keep in mind the initial
>>>> firmware that shipped with Galileo will depend on that MFH being
>> present.
>>>>
>>>>
>> http://download.intel.com/support/processors/quark/sb/quark_secureboo
>>>> t
>>>> prm_330234_001.pdf
>>>> - Section A1 - table 7 ?
>>>>
>>>> So if we boot a 4.x kernel with that initial firmware version 0.75 if
>>>> memory serves - it's important that the capsule.c code handles the MFH.
>>>>
>>>
>>> Already got agreement with Matt that Quark Security Header patch will
>>> not be upstream to mainline as it is not a standard header. So Intel
>>> will carry this patch ourselves.
>>
>> Right... so what sort of capsule are you testing with ?
>
> I am testing on Intel Galileo Gen 1 with bios version v0.7.5, v0.8.0, v1.0.1 & v1.0.2.
>
> Thanks & Regards,
> Wilson
>

Hmm.

That's pretty confusing.

The 0.75 BIOS requires the MFH as far as I remember. If the capsule you 
are using doesn't have the MFH - how is this working ?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1244028 — Re: [PATCH v7 1/2] efi: export efi_capsule_supported() function symbol

FromMatt Fleming <matt@console-pimps.org>
Date2015-10-11 00:10 +0200
SubjectRe: [PATCH v7 1/2] efi: export efi_capsule_supported() function symbol
Message-ID<qiav0-5AN-5@gated-at.bofh.it>
In reply to#1239544
On Mon, 05 Oct, at 03:13:50PM, Borislav Petkov wrote:
> On Tue, Oct 06, 2015 at 04:15:54AM +0800, Kweh, Hock Leong wrote:
> > From: "Kweh, Hock Leong" <hock.leong.kweh@intel.com>
> > 
> > This patch export efi_capsule_supported() function symbol for capsule
> > kernel module to use.
> > 
> > Cc: Matt Fleming <matt.fleming@intel.com>
> > Signed-off-by: Kweh, Hock Leong <hock.leong.kweh@intel.com>
> > ---
> >  drivers/firmware/efi/capsule.c |    1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/firmware/efi/capsule.c b/drivers/firmware/efi/capsule.c
> > index d8cd75c0..738d437 100644
> > --- a/drivers/firmware/efi/capsule.c
> > +++ b/drivers/firmware/efi/capsule.c
> > @@ -101,6 +101,7 @@ out:
> >  	kfree(capsule);
> >  	return rv;
> >  }
> > +EXPORT_SYMBOL_GPL(efi_capsule_supported);
> 
> So this one is still a separate patch.
> 
> If you're going to ignore review comments, maybe I should stop wasting
> my time reviewing your stuff...

I agree that it makes sense to fold this patch into your PATCH 2,
because then we know why we need the above symbol to be exported.

-- 
Matt Fleming, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1244139 — RE: [PATCH v7 1/2] efi: export efi_capsule_supported() function symbol

From"Kweh, Hock Leong" <hock.leong.kweh@intel.com>
Date2015-10-11 16:30 +0200
SubjectRE: [PATCH v7 1/2] efi: export efi_capsule_supported() function symbol
Message-ID<qipNn-2B9-3@gated-at.bofh.it>
In reply to#1244028
> -----Original Message-----
> From: Matt Fleming [mailto:matt@console-pimps.org]
> Sent: Sunday, October 11, 2015 6:02 AM
> 
> I agree that it makes sense to fold this patch into your PATCH 2, because then
> we know why we need the above symbol to be exported.
> 

Okay, I will squash that into my patch and re-submit v9. Before that,
are there any comments to my v8 patchset?

Thanks & Regards,
Wilson

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1244188 — Re: [PATCH v7 1/2] efi: export efi_capsule_supported() function symbol

FromMatt Fleming <matt@console-pimps.org>
Date2015-10-11 21:10 +0200
SubjectRe: [PATCH v7 1/2] efi: export efi_capsule_supported() function symbol
Message-ID<qiuam-zO-49@gated-at.bofh.it>
In reply to#1244139
On Sun, 11 Oct, at 02:28:30PM, Kweh Hock Leong wrote:
> > -----Original Message-----
> > From: Matt Fleming [mailto:matt@console-pimps.org]
> > Sent: Sunday, October 11, 2015 6:02 AM
> > 
> > I agree that it makes sense to fold this patch into your PATCH 2, because then
> > we know why we need the above symbol to be exported.
> > 
> 
> Okay, I will squash that into my patch and re-submit v9. Before that,
> are there any comments to my v8 patchset?

Yeah, I've got some comments on your v8. Please wait until I send them
before mailing the next version of this patch series.

-- 
Matt Fleming, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web