Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1239337 > unrolled thread
| Started by | MyungJoo Ham <myungjoo.ham@samsung.com> |
|---|---|
| First post | 2015-10-05 10:10 +0200 |
| Last post | 2015-10-05 12:40 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
Re: [PATCH v2] extcon: gpio: Add the support for Device tree bindings MyungJoo Ham <myungjoo.ham@samsung.com> - 2015-10-05 10:10 +0200
Re: [PATCH v2] extcon: gpio: Add the support for Device tree bindings Chanwoo Choi <cw00.choi@samsung.com> - 2015-10-05 12:40 +0200
| From | MyungJoo Ham <myungjoo.ham@samsung.com> |
|---|---|
| Date | 2015-10-05 10:10 +0200 |
| Subject | Re: [PATCH v2] extcon: gpio: Add the support for Device tree bindings |
| Message-ID | <qg90m-1uU-25@gated-at.bofh.it> |
PiAgIA0KPiAgVGhpcyBwYXRjaCBhZGRzIHRoZSBzdXBwb3J0IGZvciBEZXZpY2UgdHJlZSBiaW5k aW5ncyBvZiBleHRjb24tZ3BpbyBkcml2ZXIuDQo+IFRoZSBleHRjb24tZ3BpbyBkZXZpY2UgdHJl ZSBub2RlIG11c3QgaW5jbHVkZSB0aGUgYm90aCAnZXh0Y29uLWlkJyBhbmQNCj4gJ2V4dGNvbi1n cGlvJyBwcm9wZXJ0eS4NCj4gDQpbXQ0KPiANCj4gU2lnbmVkLW9mZi1ieTogQ2hhbndvbyBDaG9p IDxjdzAwLmNob2lAc2Ftc3VuZy5jb20+DQoNCg0KRXhjZXB0IGZvciBzb21lIGJlYXV0aWZpY2F0 aW9uIGlzc3VlcyBkZXNjcmliZWQgYmVsb3csDQoNClNpZ25lZC1vZmYtYnk6IE15dW5nSm9vIEhh bSA8bXl1bmdqb28uaGFtQHNhbXN1bmcuY29tPg0KDQo+IC0tLQ0KPiBUaGlzIHBhdGNoIGlzIGJh c2VkIG9uIGZvbGxvd2luZyBwYXRjaFsxXS4NCj4gWzFdIGh0dHBzOi8vbGttbC5vcmcvbGttbC8y MDE1LzEwLzMvMzA0DQo+IA0KPiBDaGFuZ2VzIGZyb20gdjE6DQo+IC0gQ3JlYXRlIHRoZSBpbmNs dWRlL2R0LWJpbmRpbmdzL2V4dGNvbi9leHRjb24uaCBpbmNsdWRpbmcgdGhlIGlkZW50aWZpY2F0 aW9uDQo+ICAgb2YgZXh0ZXJuYWwgY29ubmVjdG9yLiBUaGVzZSBkZWZpbml0aW9ucyBhcmUgdXNl ZCBpbiBkdHMgZmlsZS4NCj4gLSBGaXggZXJyb3IgaWYgQ09ORklHX09GIGlzIGRpc2FibGVkLg0K PiANCj4gIC4uLi9kZXZpY2V0cmVlL2JpbmRpbmdzL2V4dGNvbi9leHRjb24tZ3Bpby50eHQgICAg IHwgIDM4ICsrKysrKysNCj4gIGRyaXZlcnMvZXh0Y29uL2V4dGNvbi1ncGlvLmMgICAgICAgICAg ICAgICAgICAgICAgIHwgMTEwICsrKysrKysrKysrKysrKystLS0tLQ0KPiAgaW5jbHVkZS9kdC1i aW5kaW5ncy9leHRjb24vZXh0Y29uLmggICAgICAgICAgICAgICAgfCAgNDQgKysrKysrKysrDQo+ ICBpbmNsdWRlL2xpbnV4L2V4dGNvbi9leHRjb24tZ3Bpby5oICAgICAgICAgICAgICAgICB8ICAg NiArLQ0KPiAgNCBmaWxlcyBjaGFuZ2VkLCAxNzMgaW5zZXJ0aW9ucygrKSwgMjUgZGVsZXRpb25z KC0pDQo+ICBjcmVhdGUgbW9kZSAxMDA2NDQgRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRp bmdzL2V4dGNvbi9leHRjb24tZ3Bpby50eHQNCj4gIGNyZWF0ZSBtb2RlIDEwMDY0NCBpbmNsdWRl L2R0LWJpbmRpbmdzL2V4dGNvbi9leHRjb24uaA0KPiANCj4gZGlmZiAtLWdpdCBhL0RvY3VtZW50 YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9leHRjb24vZXh0Y29uLWdwaW8udHh0IGIvRG9jdW1l bnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2V4dGNvbi9leHRjb24tZ3Bpby50eHQNCj4gbmV3 IGZpbGUgbW9kZSAxMDA2NDQNCj4gaW5kZXggMDAwMDAwMDAwMDAwLi43MGMzNmY3Mjk5NjMNCj4g LS0tIC9kZXYvbnVsbA0KPiArKysgYi9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3Mv ZXh0Y29uL2V4dGNvbi1ncGlvLnR4dA0KW10NCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZXh0Y29u L2V4dGNvbi1ncGlvLmMgYi9kcml2ZXJzL2V4dGNvbi9leHRjb24tZ3Bpby5jDQo+IGluZGV4IDI3 OWZmOGY2NjM3ZC4uN2YzZTI0YWFlMGM0IDEwMDY0NA0KPiAtLS0gYS9kcml2ZXJzL2V4dGNvbi9l eHRjb24tZ3Bpby5jDQo+ICsrKyBiL2RyaXZlcnMvZXh0Y29uL2V4dGNvbi1ncGlvLmMNCj4gQEAg LTEsOCArMSw4IEBADQo+ICAvKg0KPiAgICogZXh0Y29uX2dwaW8uYyAtIFNpbmdsZS1zdGF0ZSBH UElPIGV4dGNvbiBkcml2ZXIgYmFzZWQgb24gZXh0Y29uIGNsYXNzDQo+ICAgKg0KPiAtICogQ29w eXJpZ2h0IChDKSAyMDA4IEdvb2dsZSwgSW5jLg0KPiAtICogQXV0aG9yOiBNaWtlIExvY2t3b29k IDxsb2Nrd29vZEBhbmRyb2lkLmNvbT4NCj4gKyAqIENvcHlyaWdodCAoQykgMjAxNSBDaGFud29v IENob2kgPGN3MDAuY2hvaUBzYW1zdW5nLmNvbT4sIFNhbXN1bmcgRWxlY3Ryb25pY3MNCj4gKyAq IENvcHlyaWdodCAoQykgMjAwOCBNaWtlIExvY2t3b29kIDxsb2Nrd29vZEBhbmRyb2lkLmNvbT4s IEdvb2dsZSwgSW5jLg0KPiAgICoNCj4gICAqIE1vZGlmaWVkIGJ5IE15dW5nSm9vIEhhbSA8bXl1 bmdqb28uaGFtQHNhbXN1bmcuY29tPiB0byBzdXBwb3J0IGV4dGNvbg0KPiAgICogKG9yaWdpbmFs bHkgc3dpdGNoIGNsYXNzIGlzIHN1cHBvcnRlZCkNCg0KTGV0J3MgbWFrZSBpdCBpbiBjaHJvbm9s b2dpY2FsIG9yZGVyLg0KKG1heSBuZWVkIHRvICJiZWF1dGlmeSB0aGUgbGFzdCB0d28gbGluZXMg YXMgd2VsbCkNCg0KSS5lLiwgMjAwOC0tPjIwMTItLT4yMDE1IG9yIDIwMTUtLT4yMDEyLS0+MjAw OC4NCk5vdCAyMDE1LS0+MjAwOC0tPjIwMTINCg0KDQo+IEBAIC0yNiwxMiArMjYsMTQgQEANCltd DQo+IGRpZmYgLS1naXQgYS9pbmNsdWRlL2R0LWJpbmRpbmdzL2V4dGNvbi9leHRjb24uaCBiL2lu Y2x1ZGUvZHQtYmluZGluZ3MvZXh0Y29uL2V4dGNvbi5oDQo+IG5ldyBmaWxlIG1vZGUgMTAwNjQ0 DQo+IGluZGV4IDAwMDAwMDAwMDAwMC4uMTRjN2YzNmIyMjA2DQo+IC0tLSAvZGV2L251bGwNCj4g KysrIGIvaW5jbHVkZS9kdC1iaW5kaW5ncy9leHRjb24vZXh0Y29uLmgNCltdDQo+IGRpZmYgLS1n aXQgYS9pbmNsdWRlL2xpbnV4L2V4dGNvbi9leHRjb24tZ3Bpby5oIGIvaW5jbHVkZS9saW51eC9l eHRjb24vZXh0Y29uLWdwaW8uaA0KPiBpbmRleCA3Y2FjYWZiNzhiMDkuLmJjYzZkN2Y3MTE2YSAx MDA2NDQNCj4gLS0tIGEvaW5jbHVkZS9saW51eC9leHRjb24vZXh0Y29uLWdwaW8uaA0KPiArKysg Yi9pbmNsdWRlL2xpbnV4L2V4dGNvbi9leHRjb24tZ3Bpby5oDQpbXQ0KPiBAQCAtMzgsNyArMzgs NyBAQCBzdHJ1Y3QgZ3Bpb19leHRjb25fcGRhdGEgew0KPiAgCXVuc2lnbmVkIGludCBleHRjb25f aWQ7DQo+ICAJdW5zaWduZWQgZ3BpbzsNCj4gIAlib29sIGdwaW9fYWN0aXZlX2xvdzsNCj4gLQl1 bnNpZ25lZCBsb25nIGRlYm91bmNlOw0KPiArCXVuc2lnbmVkIGludCBkZWJvdW5jZTsNCg0KV2hh dCBhYm91dCB1MzIsIG1ha2luZyBpdCBtb3JlIGNsZWFyPw0KKCA+ICsJZGV2aWNlX3Byb3BlcnR5 X3JlYWRfdTMyKGRldiwgImRlYm91bmNlLW1zIiwgJnBkYXRhLT5kZWJvdW5jZSk7ICkNCg0KPiAg CXVuc2lnbmVkIGxvbmcgaXJxX2ZsYWdzOw0KPiAgDQo+ICAJYm9vbCBjaGVja19vbl9yZXN1bWU7 DQo+IC0tIA0KPiAxLjguMA0K -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Chanwoo Choi <cw00.choi@samsung.com> |
|---|---|
| Date | 2015-10-05 12:40 +0200 |
| Message-ID | <qgblv-4JR-11@gated-at.bofh.it> |
| In reply to | #1239337 |
On 2015년 10월 05일 17:03, MyungJoo Ham wrote:
>>
>> This patch adds the support for Device tree bindings of extcon-gpio driver.
>> The extcon-gpio device tree node must include the both 'extcon-id' and
>> 'extcon-gpio' property.
>>
> []
>>
>> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
>
>
> Except for some beautification issues described below,
>
> Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>
>
>> ---
>> This patch is based on following patch[1].
>> [1] https://lkml.org/lkml/2015/10/3/304
>>
>> Changes from v1:
>> - Create the include/dt-bindings/extcon/extcon.h including the identification
>> of external connector. These definitions are used in dts file.
>> - Fix error if CONFIG_OF is disabled.
>>
>> .../devicetree/bindings/extcon/extcon-gpio.txt | 38 +++++++
>> drivers/extcon/extcon-gpio.c | 110 ++++++++++++++++-----
>> include/dt-bindings/extcon/extcon.h | 44 +++++++++
>> include/linux/extcon/extcon-gpio.h | 6 +-
>> 4 files changed, 173 insertions(+), 25 deletions(-)
>> create mode 100644 Documentation/devicetree/bindings/extcon/extcon-gpio.txt
>> create mode 100644 include/dt-bindings/extcon/extcon.h
>>
>> diff --git a/Documentation/devicetree/bindings/extcon/extcon-gpio.txt b/Documentation/devicetree/bindings/extcon/extcon-gpio.txt
>> new file mode 100644
>> index 000000000000..70c36f729963
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/extcon/extcon-gpio.txt
> []
>> diff --git a/drivers/extcon/extcon-gpio.c b/drivers/extcon/extcon-gpio.c
>> index 279ff8f6637d..7f3e24aae0c4 100644
>> --- a/drivers/extcon/extcon-gpio.c
>> +++ b/drivers/extcon/extcon-gpio.c
>> @@ -1,8 +1,8 @@
>> /*
>> * extcon_gpio.c - Single-state GPIO extcon driver based on extcon class
>> *
>> - * Copyright (C) 2008 Google, Inc.
>> - * Author: Mike Lockwood <lockwood@android.com>
>> + * Copyright (C) 2015 Chanwoo Choi <cw00.choi@samsung.com>, Samsung Electronics
>> + * Copyright (C) 2008 Mike Lockwood <lockwood@android.com>, Google, Inc.
>> *
>> * Modified by MyungJoo Ham <myungjoo.ham@samsung.com> to support extcon
>> * (originally switch class is supported)
>
> Let's make it in chronological order.
> (may need to "beautify the last two lines as well)
>
> I.e., 2008-->2012-->2015 or 2015-->2012-->2008.
> Not 2015-->2008-->2012
OK. I'll modify it.
>
>
>> @@ -26,12 +26,14 @@
> []
>> diff --git a/include/dt-bindings/extcon/extcon.h b/include/dt-bindings/extcon/extcon.h
>> new file mode 100644
>> index 000000000000..14c7f36b2206
>> --- /dev/null
>> +++ b/include/dt-bindings/extcon/extcon.h
> []
>> diff --git a/include/linux/extcon/extcon-gpio.h b/include/linux/extcon/extcon-gpio.h
>> index 7cacafb78b09..bcc6d7f7116a 100644
>> --- a/include/linux/extcon/extcon-gpio.h
>> +++ b/include/linux/extcon/extcon-gpio.h
> []
>> @@ -38,7 +38,7 @@ struct gpio_extcon_pdata {
>> unsigned int extcon_id;
>> unsigned gpio;
>> bool gpio_active_low;
>> - unsigned long debounce;
>> + unsigned int debounce;
>
> What about u32, making it more clear?
> ( > + device_property_read_u32(dev, "debounce-ms", &pdata->debounce); )
OK.
Thanks,
Chanwoo Choi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web