Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1239305 > unrolled thread
| Started by | Ritesh Raj Sarraf <rrs@debian.org> |
|---|---|
| First post | 2015-10-05 08:50 +0200 |
| Last post | 2015-10-05 18:20 +0200 |
| Articles | 5 — 4 participants |
Back to article view | Back to linux.kernel
[PATCH] Add quirk for Lenovo Yoga 2 with ITE Chips Ritesh Raj Sarraf <rrs@debian.org> - 2015-10-05 08:50 +0200
Re: [PATCH] Add quirk for Lenovo Yoga 2 with ITE Chips Greg KH <gregkh@linuxfoundation.org> - 2015-10-05 12:00 +0200
Re: [PATCH] Add quirk for Lenovo Yoga 2 with ITE Chips Jiri Kosina <jikos@kernel.org> - 2015-10-05 13:30 +0200
Re: [PATCH] Add quirk for Lenovo Yoga 2 with ITE Chips Ritesh Raj Sarraf <rrs@debian.org> - 2015-10-05 13:50 +0200
Re: [PATCH] Add quirk for Lenovo Yoga 2 with ITE Chips Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> - 2015-10-05 18:20 +0200
| From | Ritesh Raj Sarraf <rrs@debian.org> |
|---|---|
| Date | 2015-10-05 08:50 +0200 |
| Subject | [PATCH] Add quirk for Lenovo Yoga 2 with ITE Chips |
| Message-ID | <qg7KW-7Yq-5@gated-at.bofh.it> |
Signed-off-by: Ritesh Raj Sarraf <rrs@debian.org>
---
drivers/hid/hid-ids.h | 1 +
drivers/hid/hid-sensor-hub.c | 3 +++
2 files changed, 4 insertions(+)
diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
index f769208..127c777 100644
--- a/drivers/hid/hid-ids.h
+++ b/drivers/hid/hid-ids.h
@@ -510,6 +510,7 @@
#define USB_VENDOR_ID_ITE 0x048d
#define USB_DEVICE_ID_ITE_LENOVO_YOGA 0x8386
+#define USB_DEVICE_ID_ITE_LENOVO_YOGA2 0x8350
#define USB_VENDOR_ID_JABRA 0x0b0e
#define USB_DEVICE_ID_JABRA_SPEAK_410 0x0412
diff --git a/drivers/hid/hid-sensor-hub.c b/drivers/hid/hid-sensor-hub.c
index a76eb2a..05afa25 100644
--- a/drivers/hid/hid-sensor-hub.c
+++ b/drivers/hid/hid-sensor-hub.c
@@ -777,6 +777,9 @@ static const struct hid_device_id sensor_hub_devices[] = {
{ HID_DEVICE(HID_BUS_ANY, HID_GROUP_SENSOR_HUB, USB_VENDOR_ID_ITE,
USB_DEVICE_ID_ITE_LENOVO_YOGA),
.driver_data = HID_SENSOR_HUB_ENUM_QUIRK},
+ { HID_DEVICE(HID_BUS_ANY, HID_GROUP_SENSOR_HUB, USB_VENDOR_ID_ITE,
+ USB_DEVICE_ID_ITE_LENOVO_YOGA2),
+ .driver_data = HID_SENSOR_HUB_ENUM_QUIRK},
{ HID_DEVICE(HID_BUS_ANY, HID_GROUP_SENSOR_HUB, HID_ANY_ID,
HID_ANY_ID) },
{ }
--
2.5.3
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Greg KH <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2015-10-05 12:00 +0200 |
| Message-ID | <qgaIP-3Ld-19@gated-at.bofh.it> |
| In reply to | #1239305 |
On Mon, Oct 05, 2015 at 12:07:24PM +0530, Ritesh Raj Sarraf wrote: > Signed-off-by: Ritesh Raj Sarraf <rrs@debian.org> > --- > drivers/hid/hid-ids.h | 1 + > drivers/hid/hid-sensor-hub.c | 3 +++ > 2 files changed, 4 insertions(+) Please use scripts/get_maintainer.pl for who to send such patches too. Also, this is not how to get a patch into the stable kernel tree, please read Documentation/stable_kernel_rules.txt for how to do that. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Jiri Kosina <jikos@kernel.org> |
|---|---|
| Date | 2015-10-05 13:30 +0200 |
| Message-ID | <qgc7U-5TG-11@gated-at.bofh.it> |
| In reply to | #1239305 |
On Mon, 5 Oct 2015, Ritesh Raj Sarraf wrote:
Please insert a little bit more verbose changelog here (what exactly this
device is, why does it need such quirk, etc).
> Signed-off-by: Ritesh Raj Sarraf <rrs@debian.org>
Adding Srinivas to CC as well.
> ---
> drivers/hid/hid-ids.h | 1 +
> drivers/hid/hid-sensor-hub.c | 3 +++
> 2 files changed, 4 insertions(+)
>
> diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
> index f769208..127c777 100644
> --- a/drivers/hid/hid-ids.h
> +++ b/drivers/hid/hid-ids.h
> @@ -510,6 +510,7 @@
>
> #define USB_VENDOR_ID_ITE 0x048d
> #define USB_DEVICE_ID_ITE_LENOVO_YOGA 0x8386
> +#define USB_DEVICE_ID_ITE_LENOVO_YOGA2 0x8350
>
> #define USB_VENDOR_ID_JABRA 0x0b0e
> #define USB_DEVICE_ID_JABRA_SPEAK_410 0x0412
> diff --git a/drivers/hid/hid-sensor-hub.c b/drivers/hid/hid-sensor-hub.c
> index a76eb2a..05afa25 100644
> --- a/drivers/hid/hid-sensor-hub.c
> +++ b/drivers/hid/hid-sensor-hub.c
> @@ -777,6 +777,9 @@ static const struct hid_device_id sensor_hub_devices[] = {
> { HID_DEVICE(HID_BUS_ANY, HID_GROUP_SENSOR_HUB, USB_VENDOR_ID_ITE,
> USB_DEVICE_ID_ITE_LENOVO_YOGA),
> .driver_data = HID_SENSOR_HUB_ENUM_QUIRK},
> + { HID_DEVICE(HID_BUS_ANY, HID_GROUP_SENSOR_HUB, USB_VENDOR_ID_ITE,
> + USB_DEVICE_ID_ITE_LENOVO_YOGA2),
> + .driver_data = HID_SENSOR_HUB_ENUM_QUIRK},
> { HID_DEVICE(HID_BUS_ANY, HID_GROUP_SENSOR_HUB, HID_ANY_ID,
> HID_ANY_ID) },
> { }
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Ritesh Raj Sarraf <rrs@debian.org> |
|---|---|
| Date | 2015-10-05 13:50 +0200 |
| Message-ID | <qgcrf-6gj-1@gated-at.bofh.it> |
| In reply to | #1239476 |
[Multipart message — attachments visible in raw view] — view raw
On Mon, 2015-10-05 at 13:28 +0200, Jiri Kosina wrote: > On Mon, 5 Oct 2015, Ritesh Raj Sarraf wrote: > > Please insert a little bit more verbose changelog here (what exactly > this > device is, why does it need such quirk, etc). > > > Signed-off-by: Ritesh Raj Sarraf <rrs@debian.org> > > Adding Srinivas to CC as well. Dropping stable This patch is a follow-up to the one below. The USB ID is different for the Lenovo Yoga 2 13. What Guilhem sent you was verified against Yoga 2 11 and Yoga 3 14. I guess this product line comes with a couple of variants. Without the quirk, no data is received from the accelerometer. I have verified the patch, testing this on 4.3-rc4 (and 4.2 stable). With this patch, proper orientation data is received. rrs@learner:~/Community/UpstreamSources/linux-upstream_GIT (stable-42)$ monitor-sensor ** Message: Accelerometer orientation changed: bottom-up ** Message: Light changed: 0.000000 (lux) ±** Message: Accelerometer orientation changed: left-up ** Message: Accelerometer orientation changed: bottom-up ** Message: Accelerometer orientation changed: left-up ** Message: Accelerometer orientation changed: normal ** Message: Light changed: 29.999999 (lux) monitor-sensor can be found in the iio-sensor-proxy tool. commit 47eeca8a4838714e582c2a3058458408a328ed60 Author: Guilhem Lettron <guilhem@lettron.fr> Date: Sat Jun 27 17:02:23 2015 +0200 HID: sensor-hub: Add in quirk for Lenovo Yogas with ITE Like yogas with TEXAS_INSTRUMENTS, yogas with ITE chips needs to be initialized with enumeration quirks. Signed-off-by: Jiri Kosina <jkosina@suse.com> -- Ritesh Raj Sarraf | http://people.debian.org/~rrs Debian - The Universal Operating System
[toc] | [prev] | [next] | [standalone]
| From | Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> |
|---|---|
| Date | 2015-10-05 18:20 +0200 |
| Message-ID | <qggEz-3ZZ-29@gated-at.bofh.it> |
| In reply to | #1239481 |
On Mon, 2015-10-05 at 17:12 +0530, Ritesh Raj Sarraf wrote: > On Mon, 2015-10-05 at 13:28 +0200, Jiri Kosina wrote: > > On Mon, 5 Oct 2015, Ritesh Raj Sarraf wrote: > > > > Please insert a little bit more verbose changelog here (what exactly > > this > > device is, why does it need such quirk, etc). > > > > > Signed-off-by: Ritesh Raj Sarraf <rrs@debian.org> > > > > Adding Srinivas to CC as well. > > Dropping stable > > This patch is a follow-up to the one below. The USB ID is different for > the Lenovo Yoga 2 13. What Guilhem sent you was verified against Yoga 2 > 11 and Yoga 3 14. I guess this product line comes with a couple of > variants. > > Without the quirk, no data is received from the accelerometer. I have > verified the patch, testing this on 4.3-rc4 (and 4.2 stable). With this > patch, proper orientation data is received. > Please add the above in the description including with the commit id for the previous Yoga quirk and resend. Thanks, Srinivas > rrs@learner:~/Community/UpstreamSources/linux-upstream_GIT (stable-42)$ > monitor-sensor > ** Message: Accelerometer orientation changed: bottom-up > ** Message: Light changed: 0.000000 (lux) > ±** Message: Accelerometer orientation changed: left-up > ** Message: Accelerometer orientation changed: bottom-up > ** Message: Accelerometer orientation changed: left-up > ** Message: Accelerometer orientation changed: normal > ** Message: Light changed: 29.999999 (lux) > > > monitor-sensor can be found in the iio-sensor-proxy tool. > > > commit 47eeca8a4838714e582c2a3058458408a328ed60 > Author: Guilhem Lettron <guilhem@lettron.fr> > Date: Sat Jun 27 17:02:23 2015 +0200 > > HID: sensor-hub: Add in quirk for Lenovo Yogas with ITE > > Like yogas with TEXAS_INSTRUMENTS, yogas with ITE chips needs > to be initialized with enumeration quirks. > > Signed-off-by: Jiri Kosina <jkosina@suse.com> > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web