Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1239397 > unrolled thread

[PATCH] ARM64:Fix MINSIGSTKSZ and SIGSTKSZ

Back to article view | Back to linux.kernel

Contents

  [PATCH] ARM64:Fix MINSIGSTKSZ and SIGSTKSZ Manjeet Pawar <manjeet.p@samsung.com> - 2015-10-05 12:00 +0200
    Re: [PATCH] ARM64:Fix MINSIGSTKSZ and SIGSTKSZ Arnd Bergmann <arnd@arndb.de> - 2015-10-05 13:00 +0200

#1239397 — [PATCH] ARM64:Fix MINSIGSTKSZ and SIGSTKSZ

MINSIGSTKSZ and SIGSTKSZ for ARM64 are not correctly set in latest kernel.
This patch fixes this issue.

This issue is reported in LTP (testcase: sigaltstack02.c).
Testcase failed when sigaltstack() called with stack size "MINSIGSTKSZ - 1"
Since in Glibc-2.22, MINSIGSTKSZ is set to 5120 but in kernel
it is set to 2048 so testcase gets failed.

Testcase Output:
sigaltstack02 1  TPASS  :  stgaltstack() fails, Invalid Flag value,errno:22
sigaltstack02 2  TFAIL  :  sigaltstack() returned 0, expected -1,errno:12

Reported Issue in Glibc Bugzilla:
https://sourceware.org/bugzilla/show_bug.cgi?id=16850

Bugfix in Glibc-2.22:
https://sourceware.org/git/gitweb.cgi?p=glibc.git;a=blob;f=sysdeps/unix/
sysv/linux/aarch64/bits/sigstack.h;h=8f2fb76e3e81734ef8a9cf9ae40daf4705
f31c35;hb=b763f6ae859ecea70a5dacb8ad45c71d5f667e2e

Signed-off-by: Akhilesh Kumar <akhilesh.k@samsung.com>
Signed-off-by: Manjeet Pawar <manjeet.p@samsung.com>
Signed-off-by: Rohit Thapliyal <r.thapliyal@samsung.com>
---
 include/uapi/asm-generic/signal.h |    9 +++++++--
 1 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/include/uapi/asm-generic/signal.h b/include/uapi/asm-generic/signal.h
index 9df61f1..2ffbe38 100644
--- a/include/uapi/asm-generic/signal.h
+++ b/include/uapi/asm-generic/signal.h
@@ -80,8 +80,13 @@
  *	SA_RESTORER	0x04000000
  */
 
-#define MINSIGSTKSZ	2048
-#define SIGSTKSZ	8192
+#ifdef CONFIG_ARM64
+#define MINSIGSTKSZ 5120
+#define SIGSTKSZ    16384
+#else
+#define MINSIGSTKSZ 2048
+#define SIGSTKSZ    8192
+#endif
 
 #ifndef __ASSEMBLY__
 typedef struct {
-- 
1.7.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1239455

On Monday 05 October 2015 15:26:09 Manjeet Pawar wrote:
> -#define MINSIGSTKSZ    2048
> -#define SIGSTKSZ       8192
> +#ifdef CONFIG_ARM64
> +#define MINSIGSTKSZ 5120
> +#define SIGSTKSZ    16384
> +#else
> +#define MINSIGSTKSZ 2048
> +#define SIGSTKSZ    8192
> +#endif

uapi header files cannot use CONFIG_* symbols, as they are not visible
in user space.

If these have to be architecture-specific, override them in
arch/arm64/include/uapi/asm/signal.h

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web