Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1241428 > unrolled thread

[PATCH 2/2] mfd: rtsx: fix build warning

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH 2/2] mfd: rtsx: fix build warning Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-10-07 14:30 +0200
    Re: [PATCH 2/2] mfd: rtsx: fix build warning Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-10-07 14:50 +0200
      Re: [kbuild-all] [PATCH 2/2] mfd: rtsx: fix build warning Fengguang Wu <lkp@intel.com> - 2015-10-07 15:50 +0200
        Re: [kbuild-all] [PATCH 2/2] mfd: rtsx: fix build warning Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-10-07 17:50 +0200
          Re: [kbuild-all] [PATCH 2/2] mfd: rtsx: fix build warning Fengguang Wu <lkp@intel.com> - 2015-10-08 03:00 +0200
            Re: [kbuild-all] [PATCH 2/2] mfd: rtsx: fix build warning Greg KH <gregkh@linuxfoundation.org> - 2015-10-08 08:40 +0200
              Re: [kbuild-all] [PATCH 2/2] mfd: rtsx: fix build warning Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-10-08 09:50 +0200
    Re: [PATCH 2/2] mfd: rtsx: fix build warning Lee Jones <lee.jones@linaro.org> - 2015-10-13 10:50 +0200

#1241428 — [PATCH 2/2] mfd: rtsx: fix build warning

We were getting build warning about unused variable 'err'.
The commit a3c29b099829 has removed the use of err but missed removing
the variable which is unused now.

Fixes: a3c29b099829 ("mfd: rtsx: Simplify function return logic")
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
---
 drivers/mfd/rtsx_pcr.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/mfd/rtsx_pcr.c b/drivers/mfd/rtsx_pcr.c
index b98cf1d..d63f3a8 100644
--- a/drivers/mfd/rtsx_pcr.c
+++ b/drivers/mfd/rtsx_pcr.c
@@ -561,8 +561,6 @@ EXPORT_SYMBOL_GPL(rtsx_pci_write_ppbuf);
 
 static int rtsx_pci_set_pull_ctl(struct rtsx_pcr *pcr, const u32 *tbl)
 {
-	int err;
-
 	rtsx_pci_init_cmd(pcr);
 
 	while (*tbl & 0xFFFF0000) {
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1241455

On Wed, Oct 07, 2015 at 08:40:37PM +0800, kbuild test robot wrote:
> Hi Sudip,
> 
> [auto build test ERROR on v4.3-rc4 -- if it's inappropriate base, please ignore]
v4.3-rc4 is not appropriate base. Please use next-20151007 for both.

regards
sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1241513 — Re: [kbuild-all] [PATCH 2/2] mfd: rtsx: fix build warning

On Wed, Oct 07, 2015 at 06:16:52PM +0530, Sudip Mukherjee wrote:
> On Wed, Oct 07, 2015 at 08:40:37PM +0800, kbuild test robot wrote:
> > Hi Sudip,
> > 
> > [auto build test ERROR on v4.3-rc4 -- if it's inappropriate base, please ignore]
> v4.3-rc4 is not appropriate base. Please use next-20151007 for both.

OK. FYI, if you use [PATCH (next|-next|linux-next)] next time,
the robot will select linux-next/master as the base tree.

Thanks,
Fengguang
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1241609 — Re: [kbuild-all] [PATCH 2/2] mfd: rtsx: fix build warning

On Wed, Oct 07, 2015 at 09:48:16PM +0800, Fengguang Wu wrote:
> On Wed, Oct 07, 2015 at 06:16:52PM +0530, Sudip Mukherjee wrote:
> > On Wed, Oct 07, 2015 at 08:40:37PM +0800, kbuild test robot wrote:
> > > Hi Sudip,
> > > 
> > > [auto build test ERROR on v4.3-rc4 -- if it's inappropriate base, please ignore]
> > v4.3-rc4 is not appropriate base. Please use next-20151007 for both.
> 
> OK. FYI, if you use [PATCH (next|-next|linux-next)] next time,
> the robot will select linux-next/master as the base tree.
Ok. Great. And for staging should it be [PATCH staging-testing] ?

regards
sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1241910 — Re: [kbuild-all] [PATCH 2/2] mfd: rtsx: fix build warning

On Wed, Oct 07, 2015 at 09:11:25PM +0530, Sudip Mukherjee wrote:
> On Wed, Oct 07, 2015 at 09:48:16PM +0800, Fengguang Wu wrote:
> > On Wed, Oct 07, 2015 at 06:16:52PM +0530, Sudip Mukherjee wrote:
> > > On Wed, Oct 07, 2015 at 08:40:37PM +0800, kbuild test robot wrote:
> > > > Hi Sudip,
> > > > 
> > > > [auto build test ERROR on v4.3-rc4 -- if it's inappropriate base, please ignore]
> > > v4.3-rc4 is not appropriate base. Please use next-20151007 for both.
> > 
> > OK. FYI, if you use [PATCH (next|-next|linux-next)] next time,
> > the robot will select linux-next/master as the base tree.
> Ok. Great. And for staging should it be [PATCH staging-testing] ?

It looks some patches already use the form [PATCH staging], I wonder
which branch Greg typically apply them to, staging-testing or staging-next?

Thanks,
Fengguang
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1241996 — Re: [kbuild-all] [PATCH 2/2] mfd: rtsx: fix build warning

On Thu, Oct 08, 2015 at 08:56:38AM +0800, Fengguang Wu wrote:
> On Wed, Oct 07, 2015 at 09:11:25PM +0530, Sudip Mukherjee wrote:
> > On Wed, Oct 07, 2015 at 09:48:16PM +0800, Fengguang Wu wrote:
> > > On Wed, Oct 07, 2015 at 06:16:52PM +0530, Sudip Mukherjee wrote:
> > > > On Wed, Oct 07, 2015 at 08:40:37PM +0800, kbuild test robot wrote:
> > > > > Hi Sudip,
> > > > > 
> > > > > [auto build test ERROR on v4.3-rc4 -- if it's inappropriate base, please ignore]
> > > > v4.3-rc4 is not appropriate base. Please use next-20151007 for both.
> > > 
> > > OK. FYI, if you use [PATCH (next|-next|linux-next)] next time,
> > > the robot will select linux-next/master as the base tree.
> > Ok. Great. And for staging should it be [PATCH staging-testing] ?
> 
> It looks some patches already use the form [PATCH staging], I wonder
> which branch Greg typically apply them to, staging-testing or staging-next?

I start by putting things in staging-testing to "test" them on my
systems, and yours, and if they survive, I then move them to -next.
staging-testing can be rebased if there is problems, but -next can not,
which is why I do this.

hope this helps,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1242031 — Re: [kbuild-all] [PATCH 2/2] mfd: rtsx: fix build warning

On Thu, Oct 08, 2015 at 07:30:22AM +0100, Greg KH wrote:
> On Thu, Oct 08, 2015 at 08:56:38AM +0800, Fengguang Wu wrote:
> > On Wed, Oct 07, 2015 at 09:11:25PM +0530, Sudip Mukherjee wrote:
> > > On Wed, Oct 07, 2015 at 09:48:16PM +0800, Fengguang Wu wrote:
> > > > On Wed, Oct 07, 2015 at 06:16:52PM +0530, Sudip Mukherjee wrote:
> > > > > On Wed, Oct 07, 2015 at 08:40:37PM +0800, kbuild test robot wrote:
> > > > > > Hi Sudip,
> > > > > > 
> > > > > > [auto build test ERROR on v4.3-rc4 -- if it's inappropriate base, please ignore]
> > > > > v4.3-rc4 is not appropriate base. Please use next-20151007 for both.
> > > > 
> > > > OK. FYI, if you use [PATCH (next|-next|linux-next)] next time,
> > > > the robot will select linux-next/master as the base tree.
> > > Ok. Great. And for staging should it be [PATCH staging-testing] ?
> > 
> > It looks some patches already use the form [PATCH staging], I wonder
> > which branch Greg typically apply them to, staging-testing or staging-next?
> 
> I start by putting things in staging-testing to "test" them on my
> systems, and yours, and if they survive, I then move them to -next.
> staging-testing can be rebased if there is problems, but -next can not,
> which is why I do this.

HI Fengguang,
I have a question for you. My build system is mostly based on your
make.cross file, which I have modified again to suit my build system in
travis-ci. But for some arch the compilers used by make.cross are really
old and it generated gcc bug while compiling. I faced them for two arch
in recent past. Current one is for cris. I was ablr to find out which
commit was responsible for that build fail but since its old gcc version
no one is interested. How do you handle that? Is there no way to get the
latest compilers to test with?

regards
sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1245471

On Wed, 07 Oct 2015, Sudip Mukherjee wrote:

> We were getting build warning about unused variable 'err'.
> The commit a3c29b099829 has removed the use of err but missed removing
> the variable which is unused now.
> 
> Fixes: a3c29b099829 ("mfd: rtsx: Simplify function return logic")
> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> ---
>  drivers/mfd/rtsx_pcr.c | 2 --
>  1 file changed, 2 deletions(-)

Applied, thanks.

> diff --git a/drivers/mfd/rtsx_pcr.c b/drivers/mfd/rtsx_pcr.c
> index b98cf1d..d63f3a8 100644
> --- a/drivers/mfd/rtsx_pcr.c
> +++ b/drivers/mfd/rtsx_pcr.c
> @@ -561,8 +561,6 @@ EXPORT_SYMBOL_GPL(rtsx_pci_write_ppbuf);
>  
>  static int rtsx_pci_set_pull_ctl(struct rtsx_pcr *pcr, const u32 *tbl)
>  {
> -	int err;
> -
>  	rtsx_pci_init_cmd(pcr);
>  
>  	while (*tbl & 0xFFFF0000) {

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web