Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1241110 > unrolled thread

Re: [PATCH v2] perf: Fix build break on powerpc due to sample_reg_masks

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v2] perf: Fix build break on powerpc due to  sample_reg_masks Michael Ellerman <mpe@ellerman.id.au> - 2015-10-07 02:50 +0200
    Re: [PATCH v2] perf: Fix build break on powerpc due to  sample_reg_masks Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-10-07 15:20 +0200

#1241110 — Re: [PATCH v2] perf: Fix build break on powerpc due to sample_reg_masks

On Wed, 2015-09-30 at 16:45 -0300, Arnaldo Carvalho de Melo wrote:
> Em Wed, Sep 30, 2015 at 09:09:09PM +0200, Jiri Olsa escreveu:
> > On Wed, Sep 30, 2015 at 11:28:36AM -0700, Sukadev Bhattiprolu wrote:
> > > From e29aeeee7236122c4d807ec9ebc721b5d7d75c8d Mon Sep 17 00:00:00 2001
> > > From: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
> > > Date: Thu, 24 Sep 2015 17:53:49 -0400
> > > Subject: [PATCH v2] perf: Fix build break on powerpc due to sample_reg_masks
> > > 
> > > perf_regs.c does not get built on Powerpc as CONFIG_PERF_REGS is false.
> > > So the weak definition for 'sample_regs_masks' doesn't get picked up.
> > > 
> > > Adding perf_regs.o to util/Build unconditionally, exposes a redefinition
> > > error for 'perf_reg_value()' function (due to the static inline version
> > > in util/perf_regs.h). So use #ifdef HAVE_PERF_REGS_SUPPORT' around that
> > > function.
> > > 
> > > Signed-off-by: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
> > 
> > Acked-by: Jiri Olsa <jolsa@kernel.org>
> 
> Thanks, applied.

Is this going to Linus' tree any time soon?

I have folks pinging me to say that perf is broken on powerpc.

cheers


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1241473

Em Wed, Oct 07, 2015 at 11:46:38AM +1100, Michael Ellerman escreveu:
> On Wed, 2015-09-30 at 16:45 -0300, Arnaldo Carvalho de Melo wrote:
> > Em Wed, Sep 30, 2015 at 09:09:09PM +0200, Jiri Olsa escreveu:
> > > On Wed, Sep 30, 2015 at 11:28:36AM -0700, Sukadev Bhattiprolu wrote:
> > > > From e29aeeee7236122c4d807ec9ebc721b5d7d75c8d Mon Sep 17 00:00:00 2001
> > > > From: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
> > > > Date: Thu, 24 Sep 2015 17:53:49 -0400
> > > > Subject: [PATCH v2] perf: Fix build break on powerpc due to sample_reg_masks
> > > > 
> > > > perf_regs.c does not get built on Powerpc as CONFIG_PERF_REGS is false.
> > > > So the weak definition for 'sample_regs_masks' doesn't get picked up.
> > > > 
> > > > Adding perf_regs.o to util/Build unconditionally, exposes a redefinition
> > > > error for 'perf_reg_value()' function (due to the static inline version
> > > > in util/perf_regs.h). So use #ifdef HAVE_PERF_REGS_SUPPORT' around that
> > > > function.
> > > > 
> > > > Signed-off-by: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
> > > 
> > > Acked-by: Jiri Olsa <jolsa@kernel.org>
> > 
> > Thanks, applied.
> 
> Is this going to Linus' tree any time soon?
> 
> I have folks pinging me to say that perf is broken on powerpc.

Checking this now.

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web