Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1241439 > unrolled thread

[PATCH 1/2] mfd: lm3533: fix build warning

Back to article view | Back to linux.kernel

Contents

  [PATCH 1/2] mfd: lm3533: fix build warning Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-10-07 14:30 +0200
    Re: [PATCH 1/2] mfd: lm3533: fix build warning kbuild test robot <lkp@intel.com> - 2015-10-07 14:50 +0200
    Re: [PATCH 1/2] mfd: lm3533: fix build warning Lee Jones <lee.jones@linaro.org> - 2015-10-13 10:50 +0200

#1241439 — [PATCH 1/2] mfd: lm3533: fix build warning

We were getting build warning about unused variable 'ret'.
The commit c749db571dcf has removed the use of ret but missed removing
the variable which is unused now.

Fixes: c749db571dcf ("mfd: lm3533: Simplify function return logic")
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
---
 drivers/mfd/lm3533-core.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/mfd/lm3533-core.c b/drivers/mfd/lm3533-core.c
index 193ecee1..5abcbb2 100644
--- a/drivers/mfd/lm3533-core.c
+++ b/drivers/mfd/lm3533-core.c
@@ -592,7 +592,6 @@ static int lm3533_i2c_probe(struct i2c_client *i2c,
 					const struct i2c_device_id *id)
 {
 	struct lm3533 *lm3533;
-	int ret;
 
 	dev_dbg(&i2c->dev, "%s\n", __func__);
 
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1241458

[Multipart message — attachments visible in raw view] — view raw

Hi Sudip,

[auto build test ERROR on v4.3-rc4 -- if it's inappropriate base, please ignore]

config: x86_64-randconfig-x002-201540 (attached as .config)
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All errors (new ones prefixed by >>):

   drivers/mfd/lm3533-core.c: In function 'lm3533_i2c_probe':
>> drivers/mfd/lm3533-core.c:615:2: error: 'ret' undeclared (first use in this function)
     ret = lm3533_device_init(lm3533);
     ^
   drivers/mfd/lm3533-core.c:615:2: note: each undeclared identifier is reported only once for each function it appears in

vim +/ret +615 drivers/mfd/lm3533-core.c

fa648e51 Johan Hovold 2012-05-15  609  	if (IS_ERR(lm3533->regmap))
fa648e51 Johan Hovold 2012-05-15  610  		return PTR_ERR(lm3533->regmap);
16c5c023 Johan Hovold 2012-05-03  611  
16c5c023 Johan Hovold 2012-05-03  612  	lm3533->dev = &i2c->dev;
16c5c023 Johan Hovold 2012-05-03  613  	lm3533->irq = i2c->irq;
16c5c023 Johan Hovold 2012-05-03  614  
16c5c023 Johan Hovold 2012-05-03 @615  	ret = lm3533_device_init(lm3533);
16c5c023 Johan Hovold 2012-05-03  616  	if (ret)
fa648e51 Johan Hovold 2012-05-15  617  		return ret;
16c5c023 Johan Hovold 2012-05-03  618  

:::::: The code at line 615 was first introduced by commit
:::::: 16c5c023aac86228e3e94c4bf6d19708ea861a05 mfd: Add LM3533 lighting-power core driver

:::::: TO: Johan Hovold <jhovold@gmail.com>
:::::: CC: Samuel Ortiz <sameo@linux.intel.com>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[toc] | [prev] | [next] | [standalone]

#1245475

On Wed, 07 Oct 2015, Sudip Mukherjee wrote:

> We were getting build warning about unused variable 'ret'.
> The commit c749db571dcf has removed the use of ret but missed removing
> the variable which is unused now.
> 
> Fixes: c749db571dcf ("mfd: lm3533: Simplify function return logic")
> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> ---
>  drivers/mfd/lm3533-core.c | 1 -
>  1 file changed, 1 deletion(-)

Applied, thanks.

> diff --git a/drivers/mfd/lm3533-core.c b/drivers/mfd/lm3533-core.c
> index 193ecee1..5abcbb2 100644
> --- a/drivers/mfd/lm3533-core.c
> +++ b/drivers/mfd/lm3533-core.c
> @@ -592,7 +592,6 @@ static int lm3533_i2c_probe(struct i2c_client *i2c,
>  					const struct i2c_device_id *id)
>  {
>  	struct lm3533 *lm3533;
> -	int ret;
>  
>  	dev_dbg(&i2c->dev, "%s\n", __func__);
>  

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web