Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1241119 > unrolled thread

Re: ver_linux: proposed implementation feedback request

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: ver_linux: proposed implementation feedback request Theodore Ts'o <tytso@mit.edu> - 2015-10-07 03:30 +0200
    Re: ver_linux: proposed implementation feedback request Alexander Kapshuk <alexander.kapshuk@gmail.com> - 2015-10-07 20:10 +0200

#1241119 — Re: ver_linux: proposed implementation feedback request

On Mon, Oct 05, 2015 at 08:00:40PM +0300, Alexander Kapshuk wrote:
> Thanks very much for everyone's feedback.
> 
> Instead of flooding this mailing list with another bunch of ver_linux
> patches, I thought I would post another implementation, and see if you
> find any of the proposed changes worth submitting as a patch. I will
> be happy with whatever feedback you can give me. And we will leave it
> at that. Thanks.

Can you also explain what the changes are that you're making?  That
might be very helpful.

I'm also curious if someone suggested that you break apart the patch
into a separate one for each program?  In my opinion that actually
made it harder to review the patch set (especially when I was cc'ed on
the one for tune2fs, but not the patch that set $tune2fs :-).

My suggestion would be to break it apart by functional changes.  If
the main change is to support different version numbers emitted by a
wide range of version numbers, just say something like: fixed the
version number detection of the FOO, BAR, and BAZ packages.

Cheers,

					- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1241723

On Wed, Oct 7, 2015 at 4:25 AM, Theodore Ts'o <tytso@mit.edu> wrote:
> On Mon, Oct 05, 2015 at 08:00:40PM +0300, Alexander Kapshuk wrote:
>> Thanks very much for everyone's feedback.
>>
>> Instead of flooding this mailing list with another bunch of ver_linux
>> patches, I thought I would post another implementation, and see if you
>> find any of the proposed changes worth submitting as a patch. I will
>> be happy with whatever feedback you can give me. And we will leave it
>> at that. Thanks.
>
> Can you also explain what the changes are that you're making?  That
> might be very helpful.
>
> I'm also curious if someone suggested that you break apart the patch
> into a separate one for each program?  In my opinion that actually
> made it harder to review the patch set (especially when I was cc'ed on
> the one for tune2fs, but not the patch that set $tune2fs :-).
>
> My suggestion would be to break it apart by functional changes.  If
> the main change is to support different version numbers emitted by a
> wide range of version numbers, just say something like: fixed the
> version number detection of the FOO, BAR, and BAZ packages.
>
> Cheers,
>
>                                         - Ted

Thanks. It has been suggested to me before to break the patch apart
into individual patches, as you suggested as well.

I'm looking into the process of making and submitting patches using
git at the moment. Not something I've done before. So please bear with
me. I should be able to get back to the list with git-generated
patches some time soon.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web