Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1240406 > unrolled thread
| Started by | Jiri Slaby <jslaby@suse.cz> |
|---|---|
| First post | 2015-10-06 14:30 +0200 |
| Last post | 2015-10-07 00:40 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH -resend 1/1] fcoe: use continue instead of goto+label Jiri Slaby <jslaby@suse.cz> - 2015-10-06 14:30 +0200
Re: [PATCH -resend 1/1] fcoe: use continue instead of goto+label Johannes Thumshirn <jthumshirn@suse.de> - 2015-10-06 14:30 +0200
Re: [PATCH -resend 1/1] fcoe: use continue instead of goto+label Vasu Dev <vasu.dev@linux.intel.com> - 2015-10-07 00:40 +0200
| From | Jiri Slaby <jslaby@suse.cz> |
|---|---|
| Date | 2015-10-06 14:30 +0200 |
| Subject | [PATCH -resend 1/1] fcoe: use continue instead of goto+label |
| Message-ID | <qgzxw-63y-19@gated-at.bofh.it> |
There is a label pointing to the start of a while loop and a goto
nested only in the loop. The goto jumps to the label in some cases.
Replace the goto and the label by simple continue.
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Cc: Robert Love <robert.w.love@intel.com>
Cc: fcoe-devel@open-fcoe.org
---
Sent on:
May 5
drivers/scsi/fcoe/fcoe.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/scsi/fcoe/fcoe.c b/drivers/scsi/fcoe/fcoe.c
index d3eb80c46bbe..d187ba9b361d 100644
--- a/drivers/scsi/fcoe/fcoe.c
+++ b/drivers/scsi/fcoe/fcoe.c
@@ -1873,7 +1873,6 @@ static int fcoe_percpu_receive_thread(void *arg)
set_user_nice(current, MIN_NICE);
-retry:
while (!kthread_should_stop()) {
spin_lock_bh(&p->fcoe_rx_list.lock);
@@ -1883,7 +1882,7 @@ retry:
set_current_state(TASK_INTERRUPTIBLE);
spin_unlock_bh(&p->fcoe_rx_list.lock);
schedule();
- goto retry;
+ continue;
}
spin_unlock_bh(&p->fcoe_rx_list.lock);
--
2.6.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Johannes Thumshirn <jthumshirn@suse.de> |
|---|---|
| Date | 2015-10-06 14:30 +0200 |
| Message-ID | <qgzxw-63y-23@gated-at.bofh.it> |
| In reply to | #1240406 |
On Tuesday 06 October 2015 14:27:45 Jiri Slaby wrote:
> There is a label pointing to the start of a while loop and a goto
> nested only in the loop. The goto jumps to the label in some cases.
> Replace the goto and the label by simple continue.
>
> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
> Cc: Robert Love <robert.w.love@intel.com>
> Cc: fcoe-devel@open-fcoe.org
> ---
> Sent on:
> May 5
>
> drivers/scsi/fcoe/fcoe.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/fcoe/fcoe.c b/drivers/scsi/fcoe/fcoe.c
> index d3eb80c46bbe..d187ba9b361d 100644
> --- a/drivers/scsi/fcoe/fcoe.c
> +++ b/drivers/scsi/fcoe/fcoe.c
> @@ -1873,7 +1873,6 @@ static int fcoe_percpu_receive_thread(void *arg)
>
> set_user_nice(current, MIN_NICE);
>
> -retry:
> while (!kthread_should_stop()) {
>
> spin_lock_bh(&p->fcoe_rx_list.lock);
> @@ -1883,7 +1882,7 @@ retry:
> set_current_state(TASK_INTERRUPTIBLE);
> spin_unlock_bh(&p->fcoe_rx_list.lock);
> schedule();
> - goto retry;
> + continue;
> }
>
> spin_unlock_bh(&p->fcoe_rx_list.lock);
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
--
Johannes Thumshirn Storage
jthumshirn@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Vasu Dev <vasu.dev@linux.intel.com> |
|---|---|
| Date | 2015-10-07 00:40 +0200 |
| Message-ID | <qgJ3R-2UE-41@gated-at.bofh.it> |
| In reply to | #1240406 |
On Tue, 2015-10-06 at 14:27 +0200, Jiri Slaby wrote:
> There is a label pointing to the start of a while loop and a goto
> nested only in the loop. The goto jumps to the label in some cases.
> Replace the goto and the label by simple continue.
>
> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
> Cc: Robert Love <robert.w.love@intel.com>
> Cc: fcoe-devel@open-fcoe.org
> ---
> Sent on:
> May 5
>
> drivers/scsi/fcoe/fcoe.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/fcoe/fcoe.c b/drivers/scsi/fcoe/fcoe.c
> index d3eb80c46bbe..d187ba9b361d 100644
> --- a/drivers/scsi/fcoe/fcoe.c
> +++ b/drivers/scsi/fcoe/fcoe.c
> @@ -1873,7 +1873,6 @@ static int fcoe_percpu_receive_thread(void *arg)
>
> set_user_nice(current, MIN_NICE);
>
> -retry:
> while (!kthread_should_stop()) {
>
> spin_lock_bh(&p->fcoe_rx_list.lock);
> @@ -1883,7 +1882,7 @@ retry:
> set_current_state(TASK_INTERRUPTIBLE);
> spin_unlock_bh(&p->fcoe_rx_list.lock);
> schedule();
> - goto retry;
> + continue;
> }
>
> spin_unlock_bh(&p->fcoe_rx_list.lock);
Acked-by: Vasu Dev <vasu.dev@intel.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web