Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1240235 > unrolled thread
| Started by | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| First post | 2015-10-06 10:10 +0200 |
| Last post | 2015-10-06 17:40 +0200 |
| Articles | 4 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [RFC/PATCH 11/11] arm: boot: dts: omap: add missing default status for 32k counter Arnd Bergmann <arnd@arndb.de> - 2015-10-06 10:10 +0200
Re: [RFC/PATCH 11/11] arm: boot: dts: omap: add missing default status for 32k counter Felipe Balbi <balbi@ti.com> - 2015-10-06 17:00 +0200
Re: [RFC/PATCH 11/11] arm: boot: dts: omap: add missing default status for 32k counter Tony Lindgren <tony@atomide.com> - 2015-10-06 17:20 +0200
Re: [RFC/PATCH 11/11] arm: boot: dts: omap: add missing default status for 32k counter Felipe Balbi <balbi@ti.com> - 2015-10-06 17:40 +0200
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Date | 2015-10-06 10:10 +0200 |
| Subject | Re: [RFC/PATCH 11/11] arm: boot: dts: omap: add missing default status for 32k counter |
| Message-ID | <qgvtU-iV-15@gated-at.bofh.it> |
On Monday 05 October 2015 14:41:07 Felipe Balbi wrote:
>
> /**
> * omap_get_timer_dt - get a timer using device-tree
> * @match - device-tree match structure for matching a device type
> * @property - optional timer property to match
> *
> * Helper function to get a timer during early boot using device-tree for use
> * as kernel system timer. Optionally, the property argument can be used to
> * select a timer with a specific property. Once a timer is found then mark
> * the timer node in device-tree as disabled, to prevent the kernel from
> * registering this timer as a platform device and so no one else can use it.
> */
> static struct device_node * __init omap_get_timer_dt(const struct of_device_id *match,
> const char *property)
> {
> struct device_node *np;
>
> for_each_matching_node(np, match) {
> if (!of_device_is_available(np))
> continue;
>
> if (property && !of_get_property(np, property, NULL))
> continue;
>
> if (!property && (of_get_property(np, "ti,timer-alwon", NULL) ||
> of_get_property(np, "ti,timer-dsp", NULL) ||
> of_get_property(np, "ti,timer-pwm", NULL) ||
> of_get_property(np, "ti,timer-secure", NULL)))
> continue;
>
> of_add_property(np, &device_disabled);
> return np;
> }
>
> return NULL;
> }
>
> I'll patch this up and drop $subject
>
Ah, good.
I'm seeing the "ti,timer-alwon" property here, we probably need to take
that into account when setting the CLOCK_SOURCE_SUSPEND_NONSTOP flag, if
that isn't how it gets done already.
Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Felipe Balbi <balbi@ti.com> |
|---|---|
| Date | 2015-10-06 17:00 +0200 |
| Message-ID | <qgBSG-PD-3@gated-at.bofh.it> |
| In reply to | #1240235 |
[Multipart message — attachments visible in raw view] — view raw
Arnd Bergmann <arnd@arndb.de> writes:
> On Monday 05 October 2015 14:41:07 Felipe Balbi wrote:
>>
>> /**
>> * omap_get_timer_dt - get a timer using device-tree
>> * @match - device-tree match structure for matching a device type
>> * @property - optional timer property to match
>> *
>> * Helper function to get a timer during early boot using device-tree for use
>> * as kernel system timer. Optionally, the property argument can be used to
>> * select a timer with a specific property. Once a timer is found then mark
>> * the timer node in device-tree as disabled, to prevent the kernel from
>> * registering this timer as a platform device and so no one else can use it.
>> */
>> static struct device_node * __init omap_get_timer_dt(const struct of_device_id *match,
>> const char *property)
>> {
>> struct device_node *np;
>>
>> for_each_matching_node(np, match) {
>> if (!of_device_is_available(np))
>> continue;
>>
>> if (property && !of_get_property(np, property, NULL))
>> continue;
>>
>> if (!property && (of_get_property(np, "ti,timer-alwon", NULL) ||
>> of_get_property(np, "ti,timer-dsp", NULL) ||
>> of_get_property(np, "ti,timer-pwm", NULL) ||
>> of_get_property(np, "ti,timer-secure", NULL)))
>> continue;
>>
>> of_add_property(np, &device_disabled);
>> return np;
>> }
>>
>> return NULL;
>> }
>>
>> I'll patch this up and drop $subject
>>
>
> Ah, good.
>
> I'm seeing the "ti,timer-alwon" property here, we probably need to take
> that into account when setting the CLOCK_SOURCE_SUSPEND_NONSTOP flag, if
> that isn't how it gets done already.
that flag is not set for 32k in any dts. Seems like it should, though,
judging by the binding documentation:
- ti,timer-alwon: Indicates the timer is in an alway-on power
domain.
Tony, care to comment if we should add timer-alwon to 32k ?
--
balbi
[toc] | [prev] | [next] | [standalone]
| From | Tony Lindgren <tony@atomide.com> |
|---|---|
| Date | 2015-10-06 17:20 +0200 |
| Subject | Re: [RFC/PATCH 11/11] arm: boot: dts: omap: add missing default status for 32k counter |
| Message-ID | <qgCc1-1rP-3@gated-at.bofh.it> |
| In reply to | #1240519 |
* Felipe Balbi <balbi@ti.com> [151006 08:02]:
> Arnd Bergmann <arnd@arndb.de> writes:
>
> > On Monday 05 October 2015 14:41:07 Felipe Balbi wrote:
> >>
> >> /**
> >> * omap_get_timer_dt - get a timer using device-tree
> >> * @match - device-tree match structure for matching a device type
> >> * @property - optional timer property to match
> >> *
> >> * Helper function to get a timer during early boot using device-tree for use
> >> * as kernel system timer. Optionally, the property argument can be used to
> >> * select a timer with a specific property. Once a timer is found then mark
> >> * the timer node in device-tree as disabled, to prevent the kernel from
> >> * registering this timer as a platform device and so no one else can use it.
> >> */
> >> static struct device_node * __init omap_get_timer_dt(const struct of_device_id *match,
> >> const char *property)
> >> {
> >> struct device_node *np;
> >>
> >> for_each_matching_node(np, match) {
> >> if (!of_device_is_available(np))
> >> continue;
> >>
> >> if (property && !of_get_property(np, property, NULL))
> >> continue;
> >>
> >> if (!property && (of_get_property(np, "ti,timer-alwon", NULL) ||
> >> of_get_property(np, "ti,timer-dsp", NULL) ||
> >> of_get_property(np, "ti,timer-pwm", NULL) ||
> >> of_get_property(np, "ti,timer-secure", NULL)))
> >> continue;
> >>
> >> of_add_property(np, &device_disabled);
> >> return np;
> >> }
> >>
> >> return NULL;
> >> }
> >>
> >> I'll patch this up and drop $subject
> >>
> >
> > Ah, good.
> >
> > I'm seeing the "ti,timer-alwon" property here, we probably need to take
> > that into account when setting the CLOCK_SOURCE_SUSPEND_NONSTOP flag, if
> > that isn't how it gets done already.
>
> that flag is not set for 32k in any dts. Seems like it should, though,
> judging by the binding documentation:
>
> - ti,timer-alwon: Indicates the timer is in an alway-on power
> domain.
>
> Tony, care to comment if we should add timer-alwon to 32k ?
No that should not be needed for the 32k counter. We should be able
to do everything we want with CLOCK_SOURCE_SUSPEND_NONSTOP for the
32k counter.
We still need ti,timer-alwon for a while for gptimers 1 and 12 as
they are the only ones in the always-on domain. I guess that need
will eventually go away too once we have a proper interconnect
driver and are using genpd.
Regards,
Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Felipe Balbi <balbi@ti.com> |
|---|---|
| Date | 2015-10-06 17:40 +0200 |
| Message-ID | <qgCvp-1OO-45@gated-at.bofh.it> |
| In reply to | #1240535 |
[Multipart message — attachments visible in raw view] — view raw
Hi, Tony Lindgren <tony@atomide.com> writes: > * Felipe Balbi <balbi@ti.com> [151006 08:02]: >> - ti,timer-alwon: Indicates the timer is in an alway-on power >> domain. >> >> Tony, care to comment if we should add timer-alwon to 32k ? > > No that should not be needed for the 32k counter. We should be able > to do everything we want with CLOCK_SOURCE_SUSPEND_NONSTOP for the > 32k counter. > > We still need ti,timer-alwon for a while for gptimers 1 and 12 as > they are the only ones in the always-on domain. I guess that need > will eventually go away too once we have a proper interconnect > driver and are using genpd. cool, thanks. I'll try to respin this series, hopefully still this week. -- balbi
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web