Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1232930 > unrolled thread

Re: [PATCH] gpio: ath79: Convert to the state container design pattern

Started byLinus Walleij <linus.walleij@linaro.org>
First post2015-09-25 18:40 +0200
Last post2015-10-05 09:50 +0200
Articles 3 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH] gpio: ath79: Convert to the state container design pattern Linus Walleij <linus.walleij@linaro.org> - 2015-09-25 18:40 +0200
    Re: [PATCH] gpio: ath79: Convert to the state container design  pattern Alban <albeu@free.fr> - 2015-10-02 09:00 +0200
      Re: [PATCH] gpio: ath79: Convert to the state container design pattern Linus Walleij <linus.walleij@linaro.org> - 2015-10-05 09:50 +0200

#1232930 — Re: [PATCH] gpio: ath79: Convert to the state container design pattern

FromLinus Walleij <linus.walleij@linaro.org>
Date2015-09-25 18:40 +0200
SubjectRe: [PATCH] gpio: ath79: Convert to the state container design pattern
Message-ID<qcEcq-6SE-7@gated-at.bofh.it>
On Tue, Sep 1, 2015 at 2:38 AM, Alban Bedel <albeu@free.fr> wrote:

> Turn the ath79 driver into a true driver supporting multiple
> instances. While at it also removed unneed includes and make use of
> the BIT() macro.
>
> Signed-off-by: Alban Bedel <albeu@free.fr>
> ---
>
> This patch apply on top of my previous MIPS GPIO patches that are pending
> for 4.3, so it might be better to take it thru the MIPS tree.

Patch applied (for v4.4).

Would you consider sending a patch adding yourself as maintainer
for this file in MAINTAINERS?

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]


#1237983 — Re: [PATCH] gpio: ath79: Convert to the state container design pattern

FromAlban <albeu@free.fr>
Date2015-10-02 09:00 +0200
SubjectRe: [PATCH] gpio: ath79: Convert to the state container design pattern
Message-ID<qf2tY-4cT-13@gated-at.bofh.it>
In reply to#1232930
On Fri, 25 Sep 2015 09:39:51 -0700
Linus Walleij <linus.walleij@linaro.org> wrote:

> On Tue, Sep 1, 2015 at 2:38 AM, Alban Bedel <albeu@free.fr> wrote:
> 
> > Turn the ath79 driver into a true driver supporting multiple
> > instances. While at it also removed unneed includes and make use of
> > the BIT() macro.
> >
> > Signed-off-by: Alban Bedel <albeu@free.fr>
> > ---
> >
> > This patch apply on top of my previous MIPS GPIO patches that are
> > pending for 4.3, so it might be better to take it thru the MIPS
> > tree.
> 
> Patch applied (for v4.4).
> 
> Would you consider sending a patch adding yourself as maintainer
> for this file in MAINTAINERS?

Yes, I'll send that soon.

However while looking at adding IRQ support I stumbled upon the bgpio
API from the generic gpio driver. I think it might make more sense
to simply move to this API instead of doing the above cleanup. I'll
send a patch for this in the next days.

Alban
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]


#1239326

FromLinus Walleij <linus.walleij@linaro.org>
Date2015-10-05 09:50 +0200
Message-ID<qg8GZ-Ta-9@gated-at.bofh.it>
In reply to#1237983
On Fri, Oct 2, 2015 at 8:52 AM, Alban <albeu@free.fr> wrote:

>> Would you consider sending a patch adding yourself as maintainer
>> for this file in MAINTAINERS?
>
> Yes, I'll send that soon.

Thanks!

> However while looking at adding IRQ support I stumbled upon the bgpio
> API from the generic gpio driver. I think it might make more sense
> to simply move to this API instead of doing the above cleanup. I'll
> send a patch for this in the next days.

Yeah maybe that is better. For IRQ support please use GPIOLIB_IRQCHIP
if you can. I think I saw that OpenWRT has implemented IRQ support for
ath79 with some outoftree patch right?

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web