Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1238770 > unrolled thread

[PATCH 2/2] NTB: remove unused variable

Started bySudip Mukherjee <sudipm.mukherjee@gmail.com>
First post2015-10-03 10:20 +0200
Last post2015-10-05 04:50 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  [PATCH 2/2] NTB: remove unused variable Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-10-03 10:20 +0200
    Re: [PATCH 2/2] NTB: remove unused variable Jon Mason <jdmason@kudzu.us> - 2015-10-05 04:50 +0200

#1238770 — [PATCH 2/2] NTB: remove unused variable

FromSudip Mukherjee <sudipm.mukherjee@gmail.com>
Date2015-10-03 10:20 +0200
Subject[PATCH 2/2] NTB: remove unused variable
Message-ID<qfqcW-4Ce-17@gated-at.bofh.it>
These variables were not used anywhere. So remove them.

Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
---
 drivers/ntb/ntb_transport.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/ntb/ntb_transport.c b/drivers/ntb/ntb_transport.c
index 69953ee..28f9a03 100644
--- a/drivers/ntb/ntb_transport.c
+++ b/drivers/ntb/ntb_transport.c
@@ -928,7 +928,6 @@ static int ntb_transport_init_queue(struct ntb_transport_ctx *nt,
 				    unsigned int qp_num)
 {
 	struct ntb_transport_qp *qp;
-	struct ntb_transport_mw *mw;
 	phys_addr_t mw_base;
 	resource_size_t mw_size;
 	unsigned int num_qps_mw, tx_size;
@@ -939,7 +938,6 @@ static int ntb_transport_init_queue(struct ntb_transport_ctx *nt,
 	qp_count = nt->qp_count;
 
 	mw_num = QP_TO_MW(nt, qp_num);
-	mw = &nt->mw_vec[mw_num];
 
 	qp = &nt->qp_vec[qp_num];
 	qp->qp_num = qp_num;
@@ -1930,13 +1928,11 @@ EXPORT_SYMBOL_GPL(ntb_transport_link_up);
  */
 void ntb_transport_link_down(struct ntb_transport_qp *qp)
 {
-	struct pci_dev *pdev;
 	int val;
 
 	if (!qp)
 		return;
 
-	pdev = qp->ndev->pdev;
 	qp->client_ready = false;
 
 	val = ntb_spad_read(qp->ndev, QP_LINKS);
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]


#1239260

FromJon Mason <jdmason@kudzu.us>
Date2015-10-05 04:50 +0200
Message-ID<qg40F-2yx-1@gated-at.bofh.it>
In reply to#1238770
On Sat, Oct 3, 2015 at 4:09 AM, Sudip Mukherjee
<sudipm.mukherjee@gmail.com> wrote:
> These variables were not used anywhere. So remove them.
>
> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>

Applied.

Thanks,
Jon

> ---
>  drivers/ntb/ntb_transport.c | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/drivers/ntb/ntb_transport.c b/drivers/ntb/ntb_transport.c
> index 69953ee..28f9a03 100644
> --- a/drivers/ntb/ntb_transport.c
> +++ b/drivers/ntb/ntb_transport.c
> @@ -928,7 +928,6 @@ static int ntb_transport_init_queue(struct ntb_transport_ctx *nt,
>                                     unsigned int qp_num)
>  {
>         struct ntb_transport_qp *qp;
> -       struct ntb_transport_mw *mw;
>         phys_addr_t mw_base;
>         resource_size_t mw_size;
>         unsigned int num_qps_mw, tx_size;
> @@ -939,7 +938,6 @@ static int ntb_transport_init_queue(struct ntb_transport_ctx *nt,
>         qp_count = nt->qp_count;
>
>         mw_num = QP_TO_MW(nt, qp_num);
> -       mw = &nt->mw_vec[mw_num];
>
>         qp = &nt->qp_vec[qp_num];
>         qp->qp_num = qp_num;
> @@ -1930,13 +1928,11 @@ EXPORT_SYMBOL_GPL(ntb_transport_link_up);
>   */
>  void ntb_transport_link_down(struct ntb_transport_qp *qp)
>  {
> -       struct pci_dev *pdev;
>         int val;
>
>         if (!qp)
>                 return;
>
> -       pdev = qp->ndev->pdev;
>         qp->client_ready = false;
>
>         val = ntb_spad_read(qp->ndev, QP_LINKS);
> --
> 1.9.1
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web