Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1238972 > unrolled thread

[PATCH 3/3] signal: remove jffs2_garbage_collect_thread()->allow_signal(SIGCONT)

Started byOleg Nesterov <oleg@redhat.com>
First post2015-10-03 20:20 +0200
Last post2015-10-04 19:30 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  [PATCH 3/3] signal: remove  jffs2_garbage_collect_thread()->allow_signal(SIGCONT) Oleg Nesterov <oleg@redhat.com> - 2015-10-03 20:20 +0200
    Re: [PATCH 3/3] signal: remove  jffs2_garbage_collect_thread()->allow_signal(SIGCONT) Tejun Heo <tj@kernel.org> - 2015-10-04 19:30 +0200

#1238972 — [PATCH 3/3] signal: remove jffs2_garbage_collect_thread()->allow_signal(SIGCONT)

FromOleg Nesterov <oleg@redhat.com>
Date2015-10-03 20:20 +0200
Subject[PATCH 3/3] signal: remove jffs2_garbage_collect_thread()->allow_signal(SIGCONT)
Message-ID<qfzzz-1bp-3@gated-at.bofh.it>
jffs2_garbage_collect_thread() does allow_signal(SIGCONT) for no reason,
SIGCONT will wake a stopped task up even if it is ignored.

Signed-off-by: Oleg Nesterov <oleg@redhat.com>
---
 fs/jffs2/background.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/fs/jffs2/background.c b/fs/jffs2/background.c
index 53cc735..e5c1783 100644
--- a/fs/jffs2/background.c
+++ b/fs/jffs2/background.c
@@ -80,7 +80,6 @@ static int jffs2_garbage_collect_thread(void *_c)
 	siginitset(&hupmask, sigmask(SIGHUP));
 	allow_signal(SIGKILL);
 	allow_signal(SIGSTOP);
-	allow_signal(SIGCONT);
 	allow_signal(SIGHUP);
 
 	c->gc_task = current;
-- 
2.4.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]


#1239167

FromTejun Heo <tj@kernel.org>
Date2015-10-04 19:30 +0200
Message-ID<qfVgL-6VO-31@gated-at.bofh.it>
In reply to#1238972
On Sat, Oct 03, 2015 at 08:13:41PM +0200, Oleg Nesterov wrote:
> jffs2_garbage_collect_thread() does allow_signal(SIGCONT) for no reason,
> SIGCONT will wake a stopped task up even if it is ignored.
> 
> Signed-off-by: Oleg Nesterov <oleg@redhat.com>

Reviewed-by: Tejun Heo <tj@kernel.org>

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web