Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1238883 > unrolled thread

[PATCH 19/24] ver_linux: net-tools.patch

Back to article view | Back to linux.kernel

Contents

  [PATCH 19/24] ver_linux: net-tools.patch Alexander Kapshuk <alexander.kapshuk@gmail.com> - 2015-10-03 15:50 +0200

#1238883 — [PATCH 19/24] ver_linux: net-tools.patch

The current implementation relies on 'ifconfig' to be available in the
PATH. It also uses both 'grep' and 'awk' for text processing here, which
may be alright as a quick solution to be run on the command line. While
in a script, 'sed' or 'awk' would be a better choice. On top of that,
the current implementation expects the version number to be found in
the last field as seen by 'awk'. Should the output format be different,
this approach would no longer be reliable.

The proposed implementation locates 'ifconfig', and uses 'sed' as a more
flexible tool to handle varying output formats.

Tested on:
Gentoo Linux
Debian 6.0.10
Oracle Linux Server release 7.1
Arch Linux
openSuSE 13.2


Signed-off-by: Alexander Kapshuk <alexander.kapshuk@gmail.com>
---
--- linux/scripts/ver_linux.orig    2015-10-03 13:41:57.118790241 +0300
+++ linux/scripts/ver_linux    2015-10-03 13:59:18.269210304 +0300
@@ -71,8 +71,14 @@
 ps --version 2>&1 | grep version | awk \
 'NR==1{print "Procps                ", $NF}'

-ifconfig --version 2>&1 | grep tools | awk \
-'NR==1{print "Net-tools             ", $NF}'
+test -x "$ifconfig" &&
+$ifconfig --version 2>&1 |
+sed '
+    /net-tools/!d
+    s/\([0-9]\)-.*/\1/
+    s/[ \t]/\t\t/
+    s/_.*//
+'

 # Kbd needs 'loadkeys -h',
 loadkeys -h 2>&1 | awk \
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [standalone]

Back to top | Article view | linux.kernel

csiph-web