Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1234536 > unrolled thread
| Started by | Petr Cvek <petr.cvek@tul.cz> |
|---|---|
| First post | 2015-09-28 23:50 +0200 |
| Last post | 2015-10-03 15:10 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH v4 26/26] ARM: pxa: magician: Move platform_add_devices() to the end of magician_init() Petr Cvek <petr.cvek@tul.cz> - 2015-09-28 23:50 +0200
Re: [PATCH v4 26/26] ARM: pxa: magician: Move platform_add_devices() to the end of magician_init() Philipp Zabel <philipp.zabel@gmail.com> - 2015-10-03 15:10 +0200
| From | Petr Cvek <petr.cvek@tul.cz> |
|---|---|
| Date | 2015-09-28 23:50 +0200 |
| Subject | [PATCH v4 26/26] ARM: pxa: magician: Move platform_add_devices() to the end of magician_init() |
| Message-ID | <qdOt4-3rn-7@gated-at.bofh.it> |
This patch moves platform_add_devices() (standard declaration of devices) outside of the platform specific device declarations. Moving to the end of the magician_init() clarifies the source code (standard and specific declaration are not mixed). Signed-off-by: Petr Cvek <petr.cvek@tul.cz> --- arch/arm/mach-pxa/magician.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-pxa/magician.c b/arch/arm/mach-pxa/magician.c index 8d3946d..3aba1c4 100644 --- a/arch/arm/mach-pxa/magician.c +++ b/arch/arm/mach-pxa/magician.c @@ -1099,8 +1099,6 @@ static void __init magician_init(void) pxa_set_ffuart_info(NULL); pxa_set_btuart_info(NULL); - platform_add_devices(ARRAY_AND_SIZE(devices)); - pxa_set_ficp_info(&magician_ficp_info); pxa27x_set_i2c_power_info(&magician_i2c_power_info); pxa_set_i2c_info(&i2c_info); @@ -1137,6 +1135,8 @@ static void __init magician_init(void) regulator_register_always_on(0, "power", pwm_backlight_supply, ARRAY_SIZE(pwm_backlight_supply), 5000000); + + platform_add_devices(ARRAY_AND_SIZE(devices)); } MACHINE_START(MAGICIAN, "HTC Magician") -- 1.7.12.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Philipp Zabel <philipp.zabel@gmail.com> |
|---|---|
| Date | 2015-10-03 15:10 +0200 |
| Subject | Re: [PATCH v4 26/26] ARM: pxa: magician: Move platform_add_devices() to the end of magician_init() |
| Message-ID | <qfuJA-2GX-17@gated-at.bofh.it> |
| In reply to | #1234536 |
Am Montag, den 28.09.2015, 23:42 +0200 schrieb Petr Cvek: > This patch moves platform_add_devices() (standard declaration of > devices) > outside of the platform specific device declarations. Moving to the > end > of the magician_init() clarifies the source code (standard and > specific > declaration are not mixed). > > Signed-off-by: Petr Cvek <petr.cvek@tul.cz> Acked-by: Philipp Zabel <philipp.zabel@gmail.com> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web