Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1238827 > unrolled thread
| Started by | Anjali Menon <cse.anjalimenon@gmail.com> |
|---|---|
| First post | 2015-10-03 13:50 +0200 |
| Last post | 2015-10-03 18:00 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] staging: lustre: lustre: llite: Added a blank line Anjali Menon <cse.anjalimenon@gmail.com> - 2015-10-03 13:50 +0200
Re: [PATCH] staging: lustre: lustre: llite: Added a blank line "Drokin, Oleg" <oleg.drokin@intel.com> - 2015-10-03 18:00 +0200
| From | Anjali Menon <cse.anjalimenon@gmail.com> |
|---|---|
| Date | 2015-10-03 13:50 +0200 |
| Subject | [PATCH] staging: lustre: lustre: llite: Added a blank line |
| Message-ID | <qftu9-K6-7@gated-at.bofh.it> |
Added a blank line after declaration to fix the coding
style warning detected by checkpatch.pl
WARNING: Missing a blank line after declarations
Signed-off-by: Anjali Menon <cse.anjalimenon@gmail.com>
---
drivers/staging/lustre/lustre/llite/llite_capa.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/lustre/lustre/llite/llite_capa.c b/drivers/staging/lustre/lustre/llite/llite_capa.c
index aec9a44..a626871 100644
--- a/drivers/staging/lustre/lustre/llite/llite_capa.c
+++ b/drivers/staging/lustre/lustre/llite/llite_capa.c
@@ -140,6 +140,7 @@ static void sort_add_capa(struct obd_capa *ocapa, struct list_head *head)
static inline int obd_capa_open_count(struct obd_capa *oc)
{
struct ll_inode_info *lli = ll_i2info(oc->u.cli.inode);
+
return atomic_read(&lli->lli_open_count);
}
--
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | "Drokin, Oleg" <oleg.drokin@intel.com> |
|---|---|
| Date | 2015-10-03 18:00 +0200 |
| Message-ID | <qfxo6-6iD-5@gated-at.bofh.it> |
| In reply to | #1238827 |
On Oct 3, 2015, at 7:39 AM, Anjali Menon wrote:
> Added a blank line after declaration to fix the coding
> style warning detected by checkpatch.pl
>
> WARNING: Missing a blank line after declarations
>
> Signed-off-by: Anjali Menon <cse.anjalimenon@gmail.com>
> ---
> drivers/staging/lustre/lustre/llite/llite_capa.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/lustre/lustre/llite/llite_capa.c b/drivers/staging/lustre/lustre/llite/llite_capa.c
> index aec9a44..a626871 100644
> --- a/drivers/staging/lustre/lustre/llite/llite_capa.c
> +++ b/drivers/staging/lustre/lustre/llite/llite_capa.c
> @@ -140,6 +140,7 @@ static void sort_add_capa(struct obd_capa *ocapa, struct list_head *head)
> static inline int obd_capa_open_count(struct obd_capa *oc)
This whole file has been recently removed.
In general at least with Lustre (and probably with other staging code) it's best to
base your work on Greg's staging-next (or even staging-testing) tree because this
is where the most up to date code is (And this is where Greg tries to apply it anyway).
> {
> struct ll_inode_info *lli = ll_i2info(oc->u.cli.inode);
> +
> return atomic_read(&lli->lli_open_count);
> }
>
> --
> 1.9.1
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web