Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1238738 > unrolled thread

Re: [PATCH] ceph:Remove unused goto labels in decode crush map functions

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] ceph:Remove unused goto labels in decode crush map functions Ilya Dryomov <idryomov@gmail.com> - 2015-10-03 07:50 +0200

#1238738 — Re: [PATCH] ceph:Remove unused goto labels in decode crush map functions

On Fri, Oct 2, 2015 at 9:48 PM, Nicholas Krause <xerofoify@gmail.com> wrote:
> This removes unused goto labels in decode crush map functions related
> to error paths due to them never being used on any error path for these
> particular functions in the file, osdmap.c.
>
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> ---
>  net/ceph/osdmap.c | 10 ----------
>  1 file changed, 10 deletions(-)
>
> diff --git a/net/ceph/osdmap.c b/net/ceph/osdmap.c
> index 7d8f581..2f8e41c 100644
> --- a/net/ceph/osdmap.c
> +++ b/net/ceph/osdmap.c
> @@ -59,8 +59,6 @@ static int crush_decode_uniform_bucket(void **p, void *end,
>         ceph_decode_need(p, end, (1+b->h.size) * sizeof(u32), bad);
                                                                ^^^
>         b->item_weight = ceph_decode_32(p);
>         return 0;
> -bad:
   ^^^
> -       return -EINVAL;
>  }

I realize that these macros are sneaky, but you should at least
compile-test your patches before you send them out.

Thanks,

                Ilya
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [standalone]

Back to top | Article view | linux.kernel

csiph-web