Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1238333 > unrolled thread
| Started by | Javier Martinez Canillas <javier@osg.samsung.com> |
|---|---|
| First post | 2015-10-02 16:50 +0200 |
| Last post | 2015-10-02 20:00 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] Input: goldfish - Allow compile the driver with COMPILE_TEST Javier Martinez Canillas <javier@osg.samsung.com> - 2015-10-02 16:50 +0200
Re: [PATCH] Input: goldfish - Allow compile the driver with COMPILE_TEST Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2015-10-02 20:00 +0200
| From | Javier Martinez Canillas <javier@osg.samsung.com> |
|---|---|
| Date | 2015-10-02 16:50 +0200 |
| Subject | [PATCH] Input: goldfish - Allow compile the driver with COMPILE_TEST |
| Message-ID | <qf9ON-6ks-7@gated-at.bofh.it> |
The driver depends on GOLDFISH but there isn't a build dependency so it's a good idea to allow the driver to be built even if that option is disabled, if the COMPILE_TEST option is enabled. That way, the driver can be built with a config generated by make allyesconfig and can be checked if a patch would break the build. Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> --- drivers/input/keyboard/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/keyboard/Kconfig b/drivers/input/keyboard/Kconfig index 2e80107ff630..ddd8148d51d7 100644 --- a/drivers/input/keyboard/Kconfig +++ b/drivers/input/keyboard/Kconfig @@ -516,7 +516,7 @@ config KEYBOARD_SAMSUNG module will be called samsung-keypad. config KEYBOARD_GOLDFISH_EVENTS - depends on GOLDFISH + depends on GOLDFISH || COMPILE_TEST tristate "Generic Input Event device for Goldfish" help Say Y here to get an input event device for the Goldfish virtual -- 2.4.3 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Dmitry Torokhov <dmitry.torokhov@gmail.com> |
|---|---|
| Date | 2015-10-02 20:00 +0200 |
| Subject | Re: [PATCH] Input: goldfish - Allow compile the driver with COMPILE_TEST |
| Message-ID | <qfcMH-29a-11@gated-at.bofh.it> |
| In reply to | #1238333 |
On Fri, Oct 02, 2015 at 04:47:58PM +0200, Javier Martinez Canillas wrote: > The driver depends on GOLDFISH but there isn't a build dependency > so it's a good idea to allow the driver to be built even if that > option is disabled, if the COMPILE_TEST option is enabled. > > That way, the driver can be built with a config generated by make > allyesconfig and can be checked if a patch would break the build. > > Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> > Applied, thank you. > --- > > drivers/input/keyboard/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/input/keyboard/Kconfig b/drivers/input/keyboard/Kconfig > index 2e80107ff630..ddd8148d51d7 100644 > --- a/drivers/input/keyboard/Kconfig > +++ b/drivers/input/keyboard/Kconfig > @@ -516,7 +516,7 @@ config KEYBOARD_SAMSUNG > module will be called samsung-keypad. > > config KEYBOARD_GOLDFISH_EVENTS > - depends on GOLDFISH > + depends on GOLDFISH || COMPILE_TEST > tristate "Generic Input Event device for Goldfish" > help > Say Y here to get an input event device for the Goldfish virtual > -- > 2.4.3 > -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web