Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1235392 > unrolled thread
| Started by | Tejun Heo <tj@kernel.org> |
|---|---|
| First post | 2015-09-29 18:50 +0200 |
| Last post | 2015-10-02 16:20 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH 2/5] writeback: fix bdi_writeback iteration in wakeup_dirtytime_writeback() Tejun Heo <tj@kernel.org> - 2015-09-29 18:50 +0200
Re: [PATCH 2/5] writeback: fix bdi_writeback iteration in wakeup_dirtytime_writeback() Jan Kara <jack@suse.cz> - 2015-10-02 16:20 +0200
| From | Tejun Heo <tj@kernel.org> |
|---|---|
| Date | 2015-09-29 18:50 +0200 |
| Subject | [PATCH 2/5] writeback: fix bdi_writeback iteration in wakeup_dirtytime_writeback() |
| Message-ID | <qe6gj-3Gy-29@gated-at.bofh.it> |
wakeup_dirtytime_writeback() walks and wakes up all wb's of all bdi's;
unfortunately, it was always waking up bdi->wb instead of the wb being
walked. Fix it.
Signed-off-by: Tejun Heo <tj@kernel.org>
Fixes: 001fe6f617b1 ("writeback: make wakeup_dirtytime_writeback() handle multiple bdi_writeback's")
---
fs/fs-writeback.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c
index 091a364..d0da306 100644
--- a/fs/fs-writeback.c
+++ b/fs/fs-writeback.c
@@ -1897,8 +1897,8 @@ static void wakeup_dirtytime_writeback(struct work_struct *w)
struct wb_iter iter;
bdi_for_each_wb(wb, bdi, &iter, 0)
- if (!list_empty(&bdi->wb.b_dirty_time))
- wb_wakeup(&bdi->wb);
+ if (!list_empty(&wb->b_dirty_time))
+ wb_wakeup(wb);
}
rcu_read_unlock();
schedule_delayed_work(&dirtytime_work, dirtytime_expire_interval * HZ);
--
2.4.3
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Jan Kara <jack@suse.cz> |
|---|---|
| Date | 2015-10-02 16:20 +0200 |
| Subject | Re: [PATCH 2/5] writeback: fix bdi_writeback iteration in wakeup_dirtytime_writeback() |
| Message-ID | <qf9lM-5Mt-9@gated-at.bofh.it> |
| In reply to | #1235392 |
On Tue 29-09-15 12:47:51, Tejun Heo wrote:
> wakeup_dirtytime_writeback() walks and wakes up all wb's of all bdi's;
> unfortunately, it was always waking up bdi->wb instead of the wb being
> walked. Fix it.
Looks good. You can add:
Reviewed-by: Jan Kara <jack@suse.com>
Honza
>
> Signed-off-by: Tejun Heo <tj@kernel.org>
> Fixes: 001fe6f617b1 ("writeback: make wakeup_dirtytime_writeback() handle multiple bdi_writeback's")
> ---
> fs/fs-writeback.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c
> index 091a364..d0da306 100644
> --- a/fs/fs-writeback.c
> +++ b/fs/fs-writeback.c
> @@ -1897,8 +1897,8 @@ static void wakeup_dirtytime_writeback(struct work_struct *w)
> struct wb_iter iter;
>
> bdi_for_each_wb(wb, bdi, &iter, 0)
> - if (!list_empty(&bdi->wb.b_dirty_time))
> - wb_wakeup(&bdi->wb);
> + if (!list_empty(&wb->b_dirty_time))
> + wb_wakeup(wb);
> }
> rcu_read_unlock();
> schedule_delayed_work(&dirtytime_work, dirtytime_expire_interval * HZ);
> --
> 2.4.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web