Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1238241 > unrolled thread
| Started by | Nicolas Schichan <nschichan@freebox.fr> |
|---|---|
| First post | 2015-10-02 15:40 +0200 |
| Last post | 2015-10-05 15:50 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH net] ARM: net: make BPF_LD | BPF_IND instruction trigger r_X initialisation to 0. Nicolas Schichan <nschichan@freebox.fr> - 2015-10-02 15:40 +0200
Re: [PATCH net] ARM: net: make BPF_LD | BPF_IND instruction trigger r_X initialisation to 0. David Miller <davem@davemloft.net> - 2015-10-05 15:50 +0200
| From | Nicolas Schichan <nschichan@freebox.fr> |
|---|---|
| Date | 2015-10-02 15:40 +0200 |
| Subject | [PATCH net] ARM: net: make BPF_LD | BPF_IND instruction trigger r_X initialisation to 0. |
| Message-ID | <qf8J7-4MS-87@gated-at.bofh.it> |
Without this patch, if the only instructions using r_X are of the BPF_LD | BPF_IND type, r_X would not be reset to 0, using whatever value was there when entering the jited code. With this patch, r_X will be correctly marked as used so it will be reset to 0 in the prologue code. This fix also makes the test "LD_IND byte default X" pass in the test_bpf module when the ARM JIT is enabled. Signed-off-by: Nicolas Schichan <nschichan@freebox.fr> --- arch/arm/net/bpf_jit_32.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/net/bpf_jit_32.c b/arch/arm/net/bpf_jit_32.c index 876060b..b8efb8c 100644 --- a/arch/arm/net/bpf_jit_32.c +++ b/arch/arm/net/bpf_jit_32.c @@ -614,6 +614,7 @@ load_common: case BPF_LD | BPF_B | BPF_IND: load_order = 0; load_ind: + update_on_xread(ctx); OP_IMM3(ARM_ADD, r_off, r_X, k, ctx); goto load_common; case BPF_LDX | BPF_IMM: -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | David Miller <davem@davemloft.net> |
|---|---|
| Date | 2015-10-05 15:50 +0200 |
| Subject | Re: [PATCH net] ARM: net: make BPF_LD | BPF_IND instruction trigger r_X initialisation to 0. |
| Message-ID | <qgejo-uJ-13@gated-at.bofh.it> |
| In reply to | #1238241 |
From: Nicolas Schichan <nschichan@freebox.fr> Date: Fri, 2 Oct 2015 15:39:12 +0200 > Without this patch, if the only instructions using r_X are of the > BPF_LD | BPF_IND type, r_X would not be reset to 0, using whatever > value was there when entering the jited code. With this patch, r_X > will be correctly marked as used so it will be reset to 0 in the > prologue code. > > This fix also makes the test "LD_IND byte default X" pass in the > test_bpf module when the ARM JIT is enabled. > > Signed-off-by: Nicolas Schichan <nschichan@freebox.fr> Applied. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web