Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1235997 > unrolled thread

[GIT PULL] clockevents: a couple of fixes 4.3

Started byDaniel Lezcano <daniel.lezcano@linaro.org>
First post2015-09-30 12:10 +0200
Last post2015-09-30 12:20 +0200
Articles 5 — 3 participants

Back to article view | Back to linux.kernel

Contents

  [GIT PULL] clockevents: a couple of fixes 4.3 Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-09-30 12:10 +0200
    [PATCH 2/2] clocksource/drivers/keystone: Fix bad NO_IRQ usage Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-09-30 12:10 +0200
      Re: [PATCH 2/2] clocksource/drivers/keystone: Fix bad NO_IRQ usage santosh shilimkar <santosh.shilimkar@oracle.com> - 2015-09-30 17:30 +0200
    [PATCH 1/2] clocksource/drivers/rockchip: Fix bad NO_IRQ usage Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-09-30 12:10 +0200
      Re: [PATCH 1/2] clocksource/drivers/rockchip: Fix bad NO_IRQ usage Caesar Wang <caesar.upstream@gmail.com> - 2015-09-30 12:20 +0200

#1235997 — [GIT PULL] clockevents: a couple of fixes 4.3

FromDaniel Lezcano <daniel.lezcano@linaro.org>
Date2015-09-30 12:10 +0200
Subject[GIT PULL] clockevents: a couple of fixes 4.3
Message-ID<qemuL-1NX-27@gated-at.bofh.it>
Hi Thomas,

this pull request contains a couple of fixes removing the NO_IRQ usage:

  - Removed bad usage of the NO_IRQ macro which prevent to detect an 
error when calling irq_of_parse_and_map on the rockchip and keystone 
timers (Daniel Lezcano)

Thanks !

   -- Daniel


The following changes since commit eef7635a22f6b144206b5ca2f1398f637acffc4d:

   clockevents: Remove unused set_mode() callback (2015-09-14 11:00:55 
+0200)

are available in the git repository at:

   http://git.linaro.org/people/daniel.lezcano/clockevents.git 
clockevents/4.3-fixes

for you to fetch changes up to bdf7344e14d826d0df438a55fc51146d179e198d:

   clocksource/drivers/keystone: Fix bad NO_IRQ usage (2015-09-29 
14:33:51 +0200)

----------------------------------------------------------------
Daniel Lezcano (2):
       clocksource/drivers/rockchip: Fix bad NO_IRQ usage
       clocksource/drivers/keystone: Fix bad NO_IRQ usage

  drivers/clocksource/rockchip_timer.c | 2 +-
  drivers/clocksource/timer-keystone.c | 2 +-
  2 files changed, 2 insertions(+), 2 deletions(-)

-- 
  <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1236005 — [PATCH 2/2] clocksource/drivers/keystone: Fix bad NO_IRQ usage

FromDaniel Lezcano <daniel.lezcano@linaro.org>
Date2015-09-30 12:10 +0200
Subject[PATCH 2/2] clocksource/drivers/keystone: Fix bad NO_IRQ usage
Message-ID<qemuM-1NX-45@gated-at.bofh.it>
In reply to#1235997
The current code assumes the 'irq_of_parse_and_map' will return NO_IRQ in case
of failure. Unfortunately, the NO_IRQ is not consistent across the different
architectures and we must not rely on it.

NO_IRQ is equal to '-1' on ARM and 'irq_of_parse_and_map' returns '0' in case
of an error. Hence, the latter won't be detected and will lead to a crash.

Fix this by just checking 'irq' is different from zero.

Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
---
 drivers/clocksource/timer-keystone.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clocksource/timer-keystone.c b/drivers/clocksource/timer-keystone.c
index edacf39..1cea08c 100644
--- a/drivers/clocksource/timer-keystone.c
+++ b/drivers/clocksource/timer-keystone.c
@@ -152,7 +152,7 @@ static void __init keystone_timer_init(struct device_node *np)
 	int irq, error;
 
 	irq  = irq_of_parse_and_map(np, 0);
-	if (irq == NO_IRQ) {
+	if (!irq) {
 		pr_err("%s: failed to map interrupts\n", __func__);
 		return;
 	}
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1236436 — Re: [PATCH 2/2] clocksource/drivers/keystone: Fix bad NO_IRQ usage

Fromsantosh shilimkar <santosh.shilimkar@oracle.com>
Date2015-09-30 17:30 +0200
SubjectRe: [PATCH 2/2] clocksource/drivers/keystone: Fix bad NO_IRQ usage
Message-ID<qeruq-w4-11@gated-at.bofh.it>
In reply to#1236005
On 9/30/2015 3:08 AM, Daniel Lezcano wrote:
> The current code assumes the 'irq_of_parse_and_map' will return NO_IRQ in case
> of failure. Unfortunately, the NO_IRQ is not consistent across the different
> architectures and we must not rely on it.
>
> NO_IRQ is equal to '-1' on ARM and 'irq_of_parse_and_map' returns '0' in case
> of an error. Hence, the latter won't be detected and will lead to a crash.
>
> Fix this by just checking 'irq' is different from zero.
>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> ---
>   drivers/clocksource/timer-keystone.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
Acked-by: Santosh Shilimkar <ssantosh@kernel.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1236007 — [PATCH 1/2] clocksource/drivers/rockchip: Fix bad NO_IRQ usage

FromDaniel Lezcano <daniel.lezcano@linaro.org>
Date2015-09-30 12:10 +0200
Subject[PATCH 1/2] clocksource/drivers/rockchip: Fix bad NO_IRQ usage
Message-ID<qemuM-1NX-47@gated-at.bofh.it>
In reply to#1235997
The current code assumes the 'irq_of_parse_and_map' will return NO_IRQ in case
of failure. Unfortunately, the NO_IRQ is not consistent across the different
architectures and we must not rely on it.

NO_IRQ is equal to '-1' on ARM and 'irq_of_parse_and_map' returns '0' in case
of an error. Hence, the latter won't be detected and will lead to a crash.

Fix this by just checking 'irq' is different from zero.

Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
---
 drivers/clocksource/rockchip_timer.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clocksource/rockchip_timer.c b/drivers/clocksource/rockchip_timer.c
index bb2c2b0..d3c1742 100644
--- a/drivers/clocksource/rockchip_timer.c
+++ b/drivers/clocksource/rockchip_timer.c
@@ -148,7 +148,7 @@ static void __init rk_timer_init(struct device_node *np)
 	bc_timer.freq = clk_get_rate(timer_clk);
 
 	irq = irq_of_parse_and_map(np, 0);
-	if (irq == NO_IRQ) {
+	if (!irq) {
 		pr_err("Failed to map interrupts for '%s'\n", TIMER_NAME);
 		return;
 	}
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1236024 — Re: [PATCH 1/2] clocksource/drivers/rockchip: Fix bad NO_IRQ usage

FromCaesar Wang <caesar.upstream@gmail.com>
Date2015-09-30 12:20 +0200
SubjectRe: [PATCH 1/2] clocksource/drivers/rockchip: Fix bad NO_IRQ usage
Message-ID<qemEr-1ZQ-13@gated-at.bofh.it>
In reply to#1236007

在 2015年09月30日 18:08, Daniel Lezcano 写道:
> The current code assumes the 'irq_of_parse_and_map' will return NO_IRQ in case
> of failure. Unfortunately, the NO_IRQ is not consistent across the different
> architectures and we must not rely on it.
>
> NO_IRQ is equal to '-1' on ARM and 'irq_of_parse_and_map' returns '0' in case
> of an error. Hence, the latter won't be detected and will lead to a crash.
>
> Fix this by just checking 'irq' is different from zero.
>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>

As Per- discuss,  you can free add my test tag.

  Tested-by: Caesar Wang <wxt@rock-chips.com>

> ---
>   drivers/clocksource/rockchip_timer.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clocksource/rockchip_timer.c b/drivers/clocksource/rockchip_timer.c
> index bb2c2b0..d3c1742 100644
> --- a/drivers/clocksource/rockchip_timer.c
> +++ b/drivers/clocksource/rockchip_timer.c
> @@ -148,7 +148,7 @@ static void __init rk_timer_init(struct device_node *np)
>   	bc_timer.freq = clk_get_rate(timer_clk);
>   
>   	irq = irq_of_parse_and_map(np, 0);
> -	if (irq == NO_IRQ) {
> +	if (!irq) {
>   		pr_err("Failed to map interrupts for '%s'\n", TIMER_NAME);
>   		return;
>   	}


-- 
Thanks,
Caesar

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web