Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1235893 > unrolled thread

[PATCH] mtd: mtdram: fix build error

Back to article view | Back to linux.kernel

Contents

  [PATCH] mtd: mtdram: fix build error Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-09-30 10:40 +0200
    Re: [PATCH] mtd: mtdram: fix build error kbuild test robot <lkp@intel.com> - 2015-09-30 11:00 +0200
    Re: [PATCH] mtd: mtdram: fix build error Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-09-30 11:50 +0200

#1235893 — [PATCH] mtd: mtdram: fix build error

i386 allmodconfig fails with:
ERROR: "__umoddi3" [drivers/mtd/devices/mtdram.ko] undefined!
ERROR: "__moddi3" [drivers/mtd/devices/mtdram.ko] undefined!

arm allmodconfig fails with:
ERROR: "__aeabi_uldivmod" [drivers/mtd/devices/mtdram.ko] undefined!
ERROR: "__aeabi_ldivmod" [drivers/mtd/devices/mtdram.ko] undefined!

The modulus operation is not being supported by these compilers. Use
do_div() instead which returns the remainder.

Fixes: 7827e3acad2d ("mtd: mtdram: check offs and len in mtdram->erase")
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
---
 drivers/mtd/devices/mtdram.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/drivers/mtd/devices/mtdram.c b/drivers/mtd/devices/mtdram.c
index 73fa297..d085167 100644
--- a/drivers/mtd/devices/mtdram.c
+++ b/drivers/mtd/devices/mtdram.c
@@ -35,15 +35,21 @@ static struct mtd_info *mtd_info;
 static int check_offs_len(struct mtd_info *mtd, loff_t ofs, uint64_t len)
 {
 	int ret = 0;
+	unsigned long temp_len, rem;
 
 	/* Start address must align on block boundary */
-	if (ofs % mtd->erasesize) {
+	temp_len = ofs;
+	rem = do_div(temp_len, mtd->erasesize);
+	if (rem) {
 		pr_debug("%s: unaligned address\n", __func__);
 		ret = -EINVAL;
 	}
 
 	/* Length must align on block boundary */
-	if (len % mtd->erasesize) {
+	temp_len = len;
+	rem = do_div(temp_len, mtd->erasesize);
+
+	if (rem) {
 		pr_debug("%s: length not block aligned\n", __func__);
 		ret = -EINVAL;
 	}
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1235912

[Multipart message — attachments visible in raw view] — view raw

Hi Sudip,

[auto build test results on next-20150930 -- if it's inappropriate base, please ignore]

config: cris-etrax-100lx_v2_defconfig (attached as .config)
reproduce:
  wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
  chmod +x ~/bin/make.cross
  git checkout f2fe6774b45537be1dca5fee8e89943524bc777b
  # save the attached .config to linux build tree
  make.cross ARCH=cris 

All warnings (new ones prefixed by >>):

   drivers/mtd/devices/mtdram.c: In function 'check_offs_len':
>> drivers/mtd/devices/mtdram.c:42:8: warning: comparison of distinct pointer types lacks a cast [enabled by default]
>> drivers/mtd/devices/mtdram.c:42:2: warning: right shift count >= width of type [enabled by default]
>> drivers/mtd/devices/mtdram.c:42:2: warning: passing argument 1 of '__div64_32' from incompatible pointer type [enabled by default]
   include/asm-generic/div64.h:35:17: note: expected 'uint64_t *' but argument is of type 'long unsigned int *'
   drivers/mtd/devices/mtdram.c:50:8: warning: comparison of distinct pointer types lacks a cast [enabled by default]
   drivers/mtd/devices/mtdram.c:50:2: warning: right shift count >= width of type [enabled by default]
   drivers/mtd/devices/mtdram.c:50:2: warning: passing argument 1 of '__div64_32' from incompatible pointer type [enabled by default]
   include/asm-generic/div64.h:35:17: note: expected 'uint64_t *' but argument is of type 'long unsigned int *'

vim +42 drivers/mtd/devices/mtdram.c

    26	module_param(total_size, ulong, 0);
    27	MODULE_PARM_DESC(total_size, "Total device size in KiB");
    28	module_param(erase_size, ulong, 0);
    29	MODULE_PARM_DESC(erase_size, "Device erase block size in KiB");
    30	#endif
    31	
    32	// We could store these in the mtd structure, but we only support 1 device..
    33	static struct mtd_info *mtd_info;
    34	
    35	static int check_offs_len(struct mtd_info *mtd, loff_t ofs, uint64_t len)
    36	{
    37		int ret = 0;
    38		unsigned long temp_len, rem;
    39	
    40		/* Start address must align on block boundary */
    41		temp_len = ofs;
  > 42		rem = do_div(temp_len, mtd->erasesize);
    43		if (rem) {
    44			pr_debug("%s: unaligned address\n", __func__);
    45			ret = -EINVAL;
    46		}
    47	
    48		/* Length must align on block boundary */
    49		temp_len = len;
    50		rem = do_div(temp_len, mtd->erasesize);

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[toc] | [prev] | [next] | [standalone]

#1235953

On Wed, Sep 30, 2015 at 05:28:10PM +0800, kbuild test robot wrote:
> Hi Sudip,
Thanks for the warning info. v2 is getting tested on arm, cris and
xtensa. Will post after checking them.

regards
sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web