Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1235408 > unrolled thread
| Started by | Arjun Krishna Babu <arjunkrishnababu96@gmail.com> |
|---|---|
| First post | 2015-09-29 19:10 +0200 |
| Last post | 2015-09-30 05:00 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] staging: vt6655: Fixed two lines over 80 characters Arjun Krishna Babu <arjunkrishnababu96@gmail.com> - 2015-09-29 19:10 +0200
Re: [PATCH] staging: vt6655: Fixed two lines over 80 characters Greg KH <gregkh@linuxfoundation.org> - 2015-09-30 05:00 +0200
| From | Arjun Krishna Babu <arjunkrishnababu96@gmail.com> |
|---|---|
| Date | 2015-09-29 19:10 +0200 |
| Subject | [PATCH] staging: vt6655: Fixed two lines over 80 characters |
| Message-ID | <qe6zE-4i6-11@gated-at.bofh.it> |
Two lines of code that were over 80 characters long is fixed by splitting them into multiple lines. This way, the lines of code are now easier to read. Issue found by checkpatch. Signed-off-by: Arjun Krishna Babu <arjunkrishnababu96@gmail.com> --- drivers/staging/vt6655/baseband.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/staging/vt6655/baseband.c b/drivers/staging/vt6655/baseband.c index 9e61f2d..3639f9d 100644 --- a/drivers/staging/vt6655/baseband.c +++ b/drivers/staging/vt6655/baseband.c @@ -2089,9 +2089,18 @@ bool BBbVT3253Init(struct vnt_private *priv) byVT3253B0_UW2451[ii][0], byVT3253B0_UW2451[ii][1]); - /* Init ANT B select,TX Config CR09 = 0x61->0x45, 0x45->0x41(VC1/VC2 define, make the ANT_A, ANT_B inverted) */ + /* Init ANT B select, + * TX Config CR09 = 0x61->0x45, + * 0x45->0x41(VC1/VC2 define, make the ANT_A, ANT_B inverted) + */ + /*bResult &= BBbWriteEmbedded(dwIoBase,0x09,0x41);*/ - /* Init ANT B select,RX Config CR10 = 0x28->0x2A, 0x2A->0x28(VC1/VC2 define, make the ANT_A, ANT_B inverted) */ + + /* Init ANT B select, + * RX Config CR10 = 0x28->0x2A, + * 0x2A->0x28(VC1/VC2 define, make the ANT_A, ANT_B inverted) + */ + /*bResult &= BBbWriteEmbedded(dwIoBase,0x0a,0x28);*/ /* Select VC1/VC2, CR215 = 0x02->0x06 */ bResult &= BBbWriteEmbedded(priv, 0xd7, 0x06); -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Greg KH <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2015-09-30 05:00 +0200 |
| Message-ID | <qefMB-oO-9@gated-at.bofh.it> |
| In reply to | #1235408 |
On Tue, Sep 29, 2015 at 10:37:24PM +0530, Arjun Krishna Babu wrote: > Two lines of code that were over 80 characters long is fixed by > splitting them into multiple lines. > > This way, the lines of code are now easier to read. > > Issue found by checkpatch. > > Signed-off-by: Arjun Krishna Babu <arjunkrishnababu96@gmail.com> > --- > drivers/staging/vt6655/baseband.c | 13 +++++++++++-- > 1 file changed, 11 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/vt6655/baseband.c b/drivers/staging/vt6655/baseband.c > index 9e61f2d..3639f9d 100644 > --- a/drivers/staging/vt6655/baseband.c > +++ b/drivers/staging/vt6655/baseband.c > @@ -2089,9 +2089,18 @@ bool BBbVT3253Init(struct vnt_private *priv) > byVT3253B0_UW2451[ii][0], > byVT3253B0_UW2451[ii][1]); > > - /* Init ANT B select,TX Config CR09 = 0x61->0x45, 0x45->0x41(VC1/VC2 define, make the ANT_A, ANT_B inverted) */ > + /* Init ANT B select, > + * TX Config CR09 = 0x61->0x45, > + * 0x45->0x41(VC1/VC2 define, make the ANT_A, ANT_B inverted) > + */ > + > /*bResult &= BBbWriteEmbedded(dwIoBase,0x09,0x41);*/ > - /* Init ANT B select,RX Config CR10 = 0x28->0x2A, 0x2A->0x28(VC1/VC2 define, make the ANT_A, ANT_B inverted) */ > + > + /* Init ANT B select, > + * RX Config CR10 = 0x28->0x2A, > + * 0x2A->0x28(VC1/VC2 define, make the ANT_A, ANT_B inverted) > + */ > + Please always run your patches through checkpatch.pl, so that you don't get an email from the maintainers saying that you need to run your patch through checkpatch.pl. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web