Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1237714 > unrolled thread

RE: [PATCH] storvsc: use small sg_tablesize on x86

Started byKY Srinivasan <kys@microsoft.com>
First post2015-10-01 22:40 +0200
Last post2015-10-02 19:20 +0200
Articles 4 — 3 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  RE: [PATCH] storvsc: use small sg_tablesize on x86 KY Srinivasan <kys@microsoft.com> - 2015-10-01 22:40 +0200
    Re: [PATCH] storvsc: use small sg_tablesize on x86 James Bottomley <James.Bottomley@HansenPartnership.com> - 2015-10-01 23:00 +0200
      RE: [PATCH] storvsc: use small sg_tablesize on x86 KY Srinivasan <kys@microsoft.com> - 2015-10-01 23:50 +0200
      Re: [PATCH] storvsc: use small sg_tablesize on x86 Olaf Hering <olaf@aepfle.de> - 2015-10-02 19:20 +0200

#1237714 — RE: [PATCH] storvsc: use small sg_tablesize on x86

FromKY Srinivasan <kys@microsoft.com>
Date2015-10-01 22:40 +0200
SubjectRE: [PATCH] storvsc: use small sg_tablesize on x86
Message-ID<qeSNY-71t-23@gated-at.bofh.it>

> -----Original Message-----
> From: Olaf Hering [mailto:olaf@aepfle.de]
> Sent: Tuesday, September 8, 2015 3:07 AM
> To: KY Srinivasan <kys@microsoft.com>; Haiyang Zhang
> <haiyangz@microsoft.com>; JBottomley@odin.com
> Cc: linux-kernel@vger.kernel.org; linux-scsi@vger.kernel.org; Olaf Hering
> <olaf@aepfle.de>
> Subject: [PATCH] storvsc: use small sg_tablesize on x86
> 
> Reducing the sg_tablesize allows booting of 32bit kernels in VMs, after
> commit be0cf6ca301c61458dc4aa1a37acf4f58d2ed3d6 ("scsi: storvsc: Set the
> tablesize based on the information given by the host")
> 
> [    5.567138] hv_storvsc vmbus_1: adjusting sg_tablesize 0x800 -> 0x20
> 
> Signed-off-by: Olaf Hering <olaf@aepfle.de>
Reviewed-by: K. Y. Srinivasan <kys@microsoft.com>
> ---
>  drivers/scsi/storvsc_drv.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c
> index 40c43ae..36bf183 100644
> --- a/drivers/scsi/storvsc_drv.c
> +++ b/drivers/scsi/storvsc_drv.c
> @@ -1907,6 +1907,11 @@ static int storvsc_probe(struct hv_device *device,
>  	 * from the host.
>  	 */
>  	host->sg_tablesize = (stor_device->max_transfer_bytes >>
> PAGE_SHIFT);
> +#if defined(CONFIG_X86_32)
> +	dev_warn(&device->device, "adjusting sg_tablesize 0x%x -> 0x%x",
> +			host->sg_tablesize,
> MAX_MULTIPAGE_BUFFER_COUNT);
> +	host->sg_tablesize = MAX_MULTIPAGE_BUFFER_COUNT;
> +#endif
> 
>  	/* Register the HBA and start the scsi bus scan */
>  	ret = scsi_add_host(host, &device->device);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1237738

FromJames Bottomley <James.Bottomley@HansenPartnership.com>
Date2015-10-01 23:00 +0200
Message-ID<qeT7m-7th-45@gated-at.bofh.it>
In reply to#1237714
On Thu, 2015-10-01 at 20:30 +0000, KY Srinivasan wrote:
> 
> > -----Original Message-----
> > From: Olaf Hering [mailto:olaf@aepfle.de]
> > Sent: Tuesday, September 8, 2015 3:07 AM
> > To: KY Srinivasan <kys@microsoft.com>; Haiyang Zhang
> > <haiyangz@microsoft.com>; JBottomley@odin.com
> > Cc: linux-kernel@vger.kernel.org; linux-scsi@vger.kernel.org; Olaf Hering
> > <olaf@aepfle.de>
> > Subject: [PATCH] storvsc: use small sg_tablesize on x86
> > 
> > Reducing the sg_tablesize allows booting of 32bit kernels in VMs, after
> > commit be0cf6ca301c61458dc4aa1a37acf4f58d2ed3d6 ("scsi: storvsc: Set the
> > tablesize based on the information given by the host")
> > 
> > [    5.567138] hv_storvsc vmbus_1: adjusting sg_tablesize 0x800 -> 0x20
> > 
> > Signed-off-by: Olaf Hering <olaf@aepfle.de>
> Reviewed-by: K. Y. Srinivasan <kys@microsoft.com>
> > ---
> >  drivers/scsi/storvsc_drv.c | 5 +++++
> >  1 file changed, 5 insertions(+)
> > 
> > diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c
> > index 40c43ae..36bf183 100644
> > --- a/drivers/scsi/storvsc_drv.c
> > +++ b/drivers/scsi/storvsc_drv.c
> > @@ -1907,6 +1907,11 @@ static int storvsc_probe(struct hv_device *device,
> >  	 * from the host.
> >  	 */
> >  	host->sg_tablesize = (stor_device->max_transfer_bytes >>
> > PAGE_SHIFT);
> > +#if defined(CONFIG_X86_32)
> > +	dev_warn(&device->device, "adjusting sg_tablesize 0x%x -> 0x%x",
> > +			host->sg_tablesize,
> > MAX_MULTIPAGE_BUFFER_COUNT);
> > +	host->sg_tablesize = MAX_MULTIPAGE_BUFFER_COUNT;
> > +#endif

Um, this is a bit architecture specific (I know Azure is x86, but
still).  Can you make the define check CONFIG_32BIT rather than
CONFIG_X86_32?

James



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1237763

FromKY Srinivasan <kys@microsoft.com>
Date2015-10-01 23:50 +0200
Message-ID<qeTTH-eK-5@gated-at.bofh.it>
In reply to#1237738
DQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogSmFtZXMgQm90dG9tbGV5
IFttYWlsdG86SmFtZXMuQm90dG9tbGV5QEhhbnNlblBhcnRuZXJzaGlwLmNvbV0NCj4gU2VudDog
VGh1cnNkYXksIE9jdG9iZXIgMSwgMjAxNSAxOjUyIFBNDQo+IFRvOiBLWSBTcmluaXZhc2FuIDxr
eXNAbWljcm9zb2Z0LmNvbT4NCj4gQ2M6IE9sYWYgSGVyaW5nIDxvbGFmQGFlcGZsZS5kZT47IEhh
aXlhbmcgWmhhbmcNCj4gPGhhaXlhbmd6QG1pY3Jvc29mdC5jb20+OyBsaW51eC1rZXJuZWxAdmdl
ci5rZXJuZWwub3JnOyBsaW51eC0NCj4gc2NzaUB2Z2VyLmtlcm5lbC5vcmcNCj4gU3ViamVjdDog
UmU6IFtQQVRDSF0gc3RvcnZzYzogdXNlIHNtYWxsIHNnX3RhYmxlc2l6ZSBvbiB4ODYNCj4gDQo+
IE9uIFRodSwgMjAxNS0xMC0wMSBhdCAyMDozMCArMDAwMCwgS1kgU3Jpbml2YXNhbiB3cm90ZToN
Cj4gPg0KPiA+ID4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gPiA+IEZyb206IE9sYWYg
SGVyaW5nIFttYWlsdG86b2xhZkBhZXBmbGUuZGVdDQo+ID4gPiBTZW50OiBUdWVzZGF5LCBTZXB0
ZW1iZXIgOCwgMjAxNSAzOjA3IEFNDQo+ID4gPiBUbzogS1kgU3Jpbml2YXNhbiA8a3lzQG1pY3Jv
c29mdC5jb20+OyBIYWl5YW5nIFpoYW5nDQo+ID4gPiA8aGFpeWFuZ3pAbWljcm9zb2Z0LmNvbT47
IEpCb3R0b21sZXlAb2Rpbi5jb20NCj4gPiA+IENjOiBsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwu
b3JnOyBsaW51eC1zY3NpQHZnZXIua2VybmVsLm9yZzsgT2xhZiBIZXJpbmcNCj4gPiA+IDxvbGFm
QGFlcGZsZS5kZT4NCj4gPiA+IFN1YmplY3Q6IFtQQVRDSF0gc3RvcnZzYzogdXNlIHNtYWxsIHNn
X3RhYmxlc2l6ZSBvbiB4ODYNCj4gPiA+DQo+ID4gPiBSZWR1Y2luZyB0aGUgc2dfdGFibGVzaXpl
IGFsbG93cyBib290aW5nIG9mIDMyYml0IGtlcm5lbHMgaW4gVk1zLCBhZnRlcg0KPiA+ID4gY29t
bWl0IGJlMGNmNmNhMzAxYzYxNDU4ZGM0YWExYTM3YWNmNGY1OGQyZWQzZDYgKCJzY3NpOiBzdG9y
dnNjOiBTZXQNCj4gdGhlDQo+ID4gPiB0YWJsZXNpemUgYmFzZWQgb24gdGhlIGluZm9ybWF0aW9u
IGdpdmVuIGJ5IHRoZSBob3N0IikNCj4gPiA+DQo+ID4gPiBbICAgIDUuNTY3MTM4XSBodl9zdG9y
dnNjIHZtYnVzXzE6IGFkanVzdGluZyBzZ190YWJsZXNpemUgMHg4MDAgLT4gMHgyMA0KPiA+ID4N
Cj4gPiA+IFNpZ25lZC1vZmYtYnk6IE9sYWYgSGVyaW5nIDxvbGFmQGFlcGZsZS5kZT4NCj4gPiBS
ZXZpZXdlZC1ieTogSy4gWS4gU3Jpbml2YXNhbiA8a3lzQG1pY3Jvc29mdC5jb20+DQo+ID4gPiAt
LS0NCj4gPiA+ICBkcml2ZXJzL3Njc2kvc3RvcnZzY19kcnYuYyB8IDUgKysrKysNCj4gPiA+ICAx
IGZpbGUgY2hhbmdlZCwgNSBpbnNlcnRpb25zKCspDQo+ID4gPg0KPiA+ID4gZGlmZiAtLWdpdCBh
L2RyaXZlcnMvc2NzaS9zdG9ydnNjX2Rydi5jIGIvZHJpdmVycy9zY3NpL3N0b3J2c2NfZHJ2LmMN
Cj4gPiA+IGluZGV4IDQwYzQzYWUuLjM2YmYxODMgMTAwNjQ0DQo+ID4gPiAtLS0gYS9kcml2ZXJz
L3Njc2kvc3RvcnZzY19kcnYuYw0KPiA+ID4gKysrIGIvZHJpdmVycy9zY3NpL3N0b3J2c2NfZHJ2
LmMNCj4gPiA+IEBAIC0xOTA3LDYgKzE5MDcsMTEgQEAgc3RhdGljIGludCBzdG9ydnNjX3Byb2Jl
KHN0cnVjdCBodl9kZXZpY2UNCj4gKmRldmljZSwNCj4gPiA+ICAJICogZnJvbSB0aGUgaG9zdC4N
Cj4gPiA+ICAJICovDQo+ID4gPiAgCWhvc3QtPnNnX3RhYmxlc2l6ZSA9IChzdG9yX2RldmljZS0+
bWF4X3RyYW5zZmVyX2J5dGVzID4+DQo+ID4gPiBQQUdFX1NISUZUKTsNCj4gPiA+ICsjaWYgZGVm
aW5lZChDT05GSUdfWDg2XzMyKQ0KPiA+ID4gKwlkZXZfd2FybigmZGV2aWNlLT5kZXZpY2UsICJh
ZGp1c3Rpbmcgc2dfdGFibGVzaXplIDB4JXggLT4gMHgleCIsDQo+ID4gPiArCQkJaG9zdC0+c2df
dGFibGVzaXplLA0KPiA+ID4gTUFYX01VTFRJUEFHRV9CVUZGRVJfQ09VTlQpOw0KPiA+ID4gKwlo
b3N0LT5zZ190YWJsZXNpemUgPSBNQVhfTVVMVElQQUdFX0JVRkZFUl9DT1VOVDsNCj4gPiA+ICsj
ZW5kaWYNCj4gDQo+IFVtLCB0aGlzIGlzIGEgYml0IGFyY2hpdGVjdHVyZSBzcGVjaWZpYyAoSSBr
bm93IEF6dXJlIGlzIHg4NiwgYnV0DQo+IHN0aWxsKS4gIENhbiB5b3UgbWFrZSB0aGUgZGVmaW5l
IGNoZWNrIENPTkZJR18zMkJJVCByYXRoZXIgdGhhbg0KPiBDT05GSUdfWDg2XzMyPw0KDQpUaGFu
a3MsIHdpbGwgZG8uDQoNCksuIFkNCj4gDQo+IEphbWVzDQo+IA0KPiANCg0K
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1238429

FromOlaf Hering <olaf@aepfle.de>
Date2015-10-02 19:20 +0200
Message-ID<qfc9Y-1mW-19@gated-at.bofh.it>
In reply to#1237738
On Thu, Oct 01, James Bottomley wrote:

> On Thu, 2015-10-01 at 20:30 +0000, KY Srinivasan wrote:

> > > +#if defined(CONFIG_X86_32)

> Um, this is a bit architecture specific (I know Azure is x86, but
> still).  Can you make the define check CONFIG_32BIT rather than
> CONFIG_X86_32?

According to arch/x86/Kconfig there is no such thing.

Olaf
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web