Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1237141 > unrolled thread

Re: [PATCH v2] fsl-ifc: fix compilation error on ARM's 42 bit VA

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v2] fsl-ifc: fix compilation error on ARM's 42 bit VA Arnd Bergmann <arnd@arndb.de> - 2015-10-01 10:40 +0200
    Re: [PATCH v2] fsl-ifc: fix compilation error on ARM's 42 bit VA Arnd Bergmann <arnd@arndb.de> - 2015-10-01 23:10 +0200

#1237141 — Re: [PATCH v2] fsl-ifc: fix compilation error on ARM's 42 bit VA

On Wednesday 30 September 2015 17:55:42 Lijun Pan wrote:
> Need to include sched.h to fix the following compilation error
> if FSL_IFC is enabled on ARM64 machine.

That's good, but you did not change the subject line accordingly.

> Also, sort the include files by alphabetical order.

No need to reorder the other lines, just try to fit it in as good
as possible.

> Since ./arch/arm64/include/asm/stat.h does not
> include ./arch/arm64/include/asm/compat.h,
> it will not include include/linux/sched.h
> Hence we have to manually add "#include <linux/sched.h>"
> in drivers/memory/fsl_ifc.c

Ok, good job explaining what happened.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1237739

On Thursday 01 October 2015 10:55:16 Lijun Pan wrote:
> Lijun Pan
> On Oct 1, 2015 3:34 AM, "Arnd Bergmann" <arnd@arndb.de> wrote:
> >
> > On Wednesday 30 September 2015 17:55:42 Lijun Pan wrote:
> > > Need to include sched.h to fix the following compilation error
> > > if FSL_IFC is enabled on ARM64 machine.
> >
> > That's good, but you did not change the subject line accordingly.
> >
> 
> I actually add 'ARM's ' in the subject.
> How about I change it to
> fsl-ifc: fix compiler error with ARMv8's 42 bit VA and FSL_IFC enabled
> I assume above subject is longer than 65 characters. Is that OK to you?
> Do you have a better subject in mind?
> 
> Thanks for your kind review.

I think the '42 bit VA' part is what is actually misleading, that
is the part that confused me. From your description it sounds like
the problem is CONFIG_COMPAT being disabled, and that would
also be possible with 39-bit VA. Also, it would be clearer to
mention ARM64 instead of ARM, as from the kernel's perspective
those are two different architectures.

How about simply

fsl-ifc: add missing include on ARM64

that would be sufficient for readers, and they can get the
background from the changelog text. If you want to get more
specific, it could be

fsl-ifc: add missing include on ARM64 without CONFIG_COMPAT

Note that 'missing include' more or less implies a compile error
and better describes /what/ the patch does while the changelog
describes why we do it (the compiler output and why that happened).

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web